feat: address remaining review suggestions

* don't delete formik values
* correctly check when rejeting duplicate email
This commit is contained in:
marekful 2026-11-15 08:49:48 +00:00
parent cd9bd041ed
commit 0101c334dc
No known key found for this signature in database
GPG key ID: 537474212712EE0D
2 changed files with 5 additions and 2 deletions

View file

@ -81,7 +81,11 @@ const getProvisionedUser = async (config, claims, users) => {
}
// Reject provision with existing email (enforce unique)
if (existingEmailUser && (existingEmailUser.subject !== claims.sub || existingEmailUser.issuer !== claims.iss)) {
if (
existingEmailUser &&
existingEmailUser.email === claims.email &&
(existingEmailUser.subject !== claims.sub || existingEmailUser.issuer !== claims.iss))
{
throw new Error("sso.error.signup.unique-email");
}

View file

@ -46,7 +46,6 @@ const SingleSignOnClientModal = EasyModal.create((prop: Props) => {
setErrorMsg(null);
values.meta = { roleMap: [...(values.provisionRoleMap || [])] };
delete values.provisionRoleMap;
const { ...payload } = {
id: id.toString().includes("new") ? undefined : id,