From 0101c334dcdd9368df278d20f899b93dca565cd4 Mon Sep 17 00:00:00 2001 From: marekful Date: Sun, 15 Nov 2026 08:49:48 +0000 Subject: [PATCH] feat: address remaining review suggestions * don't delete formik values * correctly check when rejeting duplicate email --- backend/lib/sso/lib.js | 6 +++++- frontend/src/modals/SingleSignOnClientModal.tsx | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/backend/lib/sso/lib.js b/backend/lib/sso/lib.js index 07dd795c9..026e5e881 100644 --- a/backend/lib/sso/lib.js +++ b/backend/lib/sso/lib.js @@ -81,7 +81,11 @@ const getProvisionedUser = async (config, claims, users) => { } // Reject provision with existing email (enforce unique) - if (existingEmailUser && (existingEmailUser.subject !== claims.sub || existingEmailUser.issuer !== claims.iss)) { + if ( + existingEmailUser && + existingEmailUser.email === claims.email && + (existingEmailUser.subject !== claims.sub || existingEmailUser.issuer !== claims.iss)) + { throw new Error("sso.error.signup.unique-email"); } diff --git a/frontend/src/modals/SingleSignOnClientModal.tsx b/frontend/src/modals/SingleSignOnClientModal.tsx index e480b3f6c..a88daff16 100644 --- a/frontend/src/modals/SingleSignOnClientModal.tsx +++ b/frontend/src/modals/SingleSignOnClientModal.tsx @@ -46,7 +46,6 @@ const SingleSignOnClientModal = EasyModal.create((prop: Props) => { setErrorMsg(null); values.meta = { roleMap: [...(values.provisionRoleMap || [])] }; - delete values.provisionRoleMap; const { ...payload } = { id: id.toString().includes("new") ? undefined : id,