* Fix isOverDataLimit logic to stop allowing 0 traffic byte
issue #1515
This if statement is just wrong and doesn't block access when traffic limit is set to 0 byte. This one character fixes it.
Now if we create a new access key, set the limit to 0 before first usage, the client no longer will be able to connect.
* Rename `isOverDataLimit` to `reachedDataLimit`.
* Add a test case to prevent regression.
* Rename old variable.
* Update comment now that variable has changed meaning slightly.
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
---------
Co-authored-by: sbruens <sbruens@users.noreply.github.com>
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
* Check if `countries` is an array.
* Use `VALID_REPORT` in `postConnectionMetrics` test.
* Make realistic legacy reports and silently drop them during validation.
* Add more explicit support for legacy report types.
* Make diff smaller.
* Update `@typescript-eslint/eslint-plugin` dependency.
* Revert some changes.
* Revert "Update `@typescript-eslint/eslint-plugin` dependency."
This reverts commit a2f3edff09.
* Update test variables to improve readability.
* Add back in `userId` tests.
* Remove check that at least 1 of `userId` or `countries` is set.
* Remove unneeded test.
* feat(metrics_server): add support for tunnel time
* Add tests.
* Update `nodejs` runtime to 18.
* Update integration test.
* Use seconds instead of ms.
* Inline the minimun tunnel time and remove the unnecessary comment.
* Add field types to test case names.
* Make tunnel time optional.
* Add TODO to drop `userId`.
* Undo use of gdate.
* feat(metrics_server): drop the `userId`
* Update README.
* Fix bad merge.
* Fix bad merge on test.
* Revert change of country.
* Add types for the valid reports.
* Remove unrealistic test case with empty country list.
* feat(metrics_server): add support for tunnel time
* Add tests.
* Update `nodejs` runtime to 18.
* Update integration test.
* Use seconds instead of ms.
* Inline the minimun tunnel time and remove the unnecessary comment.
* Add field types to test case names.
* Make tunnel time optional.
* Add TODO to drop `userId`.
* Undo use of gdate.
* Make the test reports more realistic with 1 country.
* Update `update_mmdb.sh` script to download ASN database.
* Provide the `ASN` db file to `outline-ss-server`.
* Add an API to opt-in to the ASN metrics.
* Remove unused import.
* Add the ASN setting to the persisted server config.
* Continue trying to find other database if 1 of them fails.
* Resolve lint warning
* Use `outline-ss-server` v1.5.0.
* chore(docs): simplify and update `README` to reflect manager move
* Add pointer to shadowbox README.
* Cleanup the Shadowbox `README`
* Move around the Shadowbox instructions to make Node.js and Docker equal options for running the Shadowbox.
* Address review comments.
* Revert intro sentence to what was there before.
* Address review comments.
* chore(sentry_webhook): update Salesforce record IDs for new contact form
* Add new `accessKeySource` and `build`.
* Add new fields `subject` and `isUpdatedForm`.
* Change `type` field to new `role` field.
* Normalize `cloudProvider` value based on allowed picklist values.
* Update tests.
* feat(server): extend key creation API to allow specifying a port
* Use `validateNumberParam` in `setPortForNewAccessKey`.
* Only check if the port is valid if it was specified.
* Undo the removal of use of `Promise.all(...)`.
* Fix tests.
* Only run validation if parameters are provided.
* Correct types for API validation methods where `undefined` is a possible return type.
* feat(server): add optional `id` parameter to `createNewAccessKey` method
* Use `PUT` instead of `POST`.
* Make changes based on review.
* Update access key creation path to only allow ID on `PUT` calls.
* Expand test scenarios for key generation to `createAccessKey`.
* Add a `toHavePropertiesOf` custom Jasmine matcher.
* Add explicit test case for `ConflictError`.
* Revert "Add a `toHavePropertiesOf` custom Jasmine matcher."
This reverts commit 134e0df441.
