Commit graph

19500 commits

Author SHA1 Message Date
rudolf-blue
e6423bc05c Fix spacing edges in serialized launch args 2026-10-08 23:59:57 -04:00
rudolf-blue
2dc9687573 Fix deleting displayed and base animation frames 2026-10-08 23:59:57 -04:00
rudolf-blue
8637b48ad2 Fix escape handling in parse_input_from_terminal 2026-10-08 23:59:57 -04:00
rudolf-blue
37bfa25d0e Fix fractional scroll losing sub-line pixel remainders 2026-10-08 23:59:57 -04:00
rudolf-blue
fc63c2590f Fix off by one continued flag in dump_lines_with_attrs 2026-10-08 23:59:57 -04:00
rudolf-blue
f16d09603e Allow 16 entries on the pointer shape stack 2026-10-08 23:59:57 -04:00
rudolf-blue
d2a272bb98 Fix dotted and dashed underline SGR in as_ansi output 2026-10-08 23:59:57 -04:00
rudolf-blue
f7441cc323 Fix parsing of rgbi colors 2026-10-08 23:59:57 -04:00
rudolf-blue
dbab66501d Return a new reference for NotImplemented in font feature comparison 2026-10-08 23:59:57 -04:00
rudolf-blue
aee2e560c0 Fix reference leaks in font loading 2026-10-08 23:59:57 -04:00
rudolf-blue
9952b8275c Fix render_decoration raising KeyError for known decorations 2026-10-08 23:59:57 -04:00
rudolf-blue
518552241f Show the spec in the invalid font feature error 2026-10-08 23:59:57 -04:00
rudolf-blue
5f75c46ae5 Encrypt disk cache entries outside the lock 2026-10-08 23:59:56 -04:00
rudolf-blue
f3b74cdeac Fix key leak and stale entry accounting in disk cache defrag 2026-10-08 23:59:56 -04:00
rudolf-blue
3979ce68ff Fix size type passed to Py_BuildValue y# in load_png_data 2026-10-08 23:59:56 -04:00
rudolf-blue
9cfd91e812 Fix crash in png_from_32bit_rgba_data on invalid input 2026-10-08 23:59:56 -04:00
rudolf-blue
4d2a12df72 Fix lazy drag data being cut off after the first chunk on Wayland 2026-10-08 23:59:56 -04:00
rudolf-blue
dcac4bb35f Fix partial drag data writes and a NULL mime_type dereference on Wayland 2026-10-08 23:59:56 -04:00
rudolf-blue
eff37ff291 Fix drop data buffer overflow and unchecked mmap on Wayland 2026-10-08 23:59:56 -04:00
rudolf-blue
a24311b240 Stop CHT once the cursor reaches the last column 2026-10-08 23:59:56 -04:00
rudolf-blue
3d007dbf9e Fix out of bounds write in single line DECCARA 2026-10-08 23:59:56 -04:00
rudolf-blue
e1250cf8fb Fix erase in line and display orphaning halves of multicell characters 2026-10-08 23:59:56 -04:00
rudolf-blue
a1dc62a710 Use framebuffer copies when growing sprite textures 2026-10-08 23:59:56 -04:00
rudolf-blue
33463560f5 Grow the sprite decorations map geometrically 2026-10-08 23:59:56 -04:00
rudolf-blue
7bdcd8e766 Grow the sprite texture rows geometrically 2026-10-08 23:59:56 -04:00
rudolf-blue
d0a7052ce6 Account for the extra sprite row when computing max sprite rows 2026-10-08 23:59:56 -04:00
Kovid Goyal
237a598cae
Fix heap buffer overflow in unicode_in_range()
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
When growing the buffer, realloc was passed the element count instead of
the byte count, shrinking the buffer while capacity was set to the larger
value. Lines with more than 4096 codepoints (e.g. many combining chars)
would then write past the end of the allocation.
2026-10-08 23:51:48 +05:30
Kovid Goyal
e81c993ce2
Cleanup previous PR
Fix dangling text pointer in buffered key events and test CSI param overflow

Key events buffered while waiting for an overlay to become ready stored
the text pointer from the GLFWkeyevent, which is only valid for the
duration of the key callback. Make the buffered events own a copy of
the text and free it in a single place.

Also add a test for the out of bounds write of is_sub_param when a
separator follows the last allowed CSI parameter.
2026-10-08 23:34:30 +05:30
Kovid Goyal
390306edcc Merge branch 'misc-fixes' of https://github.com/rudolf-blue/kitty 2026-10-08 23:26:21 +05:30
Kovid Goyal
f021526205
Fix #10628 2026-10-08 22:08:13 +05:30
rudolf-blue
20c24fa4f4 icat: Write unicode placeholders in a single write 2026-10-08 12:00:20 -04:00
rudolf-blue
799963bc38 Dont leak the reader goroutine in roundtrip_to_terminal 2026-10-08 12:00:20 -04:00
rudolf-blue
db5d7e027c Minor fixes 2026-10-08 12:00:20 -04:00
rudolf-blue
3a294df4da Round up poll timeout in the I/O loop
Truncating to ms made the loop spin with a zero timeout until the deadline.
2026-10-08 12:00:20 -04:00
rudolf-blue
7468112c0b Fix leak when growing buffered keys 2026-10-08 12:00:20 -04:00
Kovid Goyal
fa9f8dac18
Cleanup previous PR
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-08 08:31:32 +05:30
fairyhunter13
1bf03eabaa Graphics: move Unicode placeholder cell images with lines scrolled into history from a region
A line scrolled out of a region whose top is row 0 (tmux with a bottom status line) enters the history, but scroll_filter_margins_func left the refs of history lines in place, so they drew over other lines on the next scroll back. A reverse scroll also moved history refs although the history does not move.
2026-10-08 09:20:16 +07:00
Kovid Goyal
e4187643a6
Fix #10625
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-08 07:23:45 +05:30
Kovid Goyal
24f7369bb6
Drop Unicode placeholder cell images scrolled off the bottom of the screen
A full screen reverse scroll (ESC M at the top, CSI T) moves every image
ref down a row. scroll_filter_func() only removed refs that left through
the top, so a cell image on the bottom line ended up at row `lines`, off
screen, while its line was discarded. The next forward scroll brought it
back onto the bottom row, where the line has no placeholders.
screen_render_line_graphics() returns early for such lines, so nothing
removed the ref and a slice of the old image was drawn over the new text.
tmux and pagers send ESC M when scrolling down, so this shows up in
practice. Fix it by dropping cell image refs that move below the bottom
margin, the same way the margins scroll path drops refs that leave the
region.

This replaces PR #10623, which was not merged for these reasons:

- It does not find the cause. It removes cell image refs at render time
  for every line without placeholders, so the stale ref still exists and
  is still seen by anything that reads refs before the next render, such
  as graphics query and delete commands and the paused rendering path,
  which returns before the new code.
- It costs time on every frame. Whenever any image is loaded, even with
  no placeholders at all, each clean visible line and each visible
  history line triggers a walk over all images and refs. Before, such
  lines cost nothing. This fix adds one comparison to a loop that only
  runs when the screen scrolls.

Close #10623
2026-10-07 20:19:23 +05:30
Kovid Goyal
7e7355ccbe
make ty 85 happy
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-07 05:07:04 +05:30
Kovid Goyal
9f61eaf0f2
Increase notarization timeout 2026-10-07 04:32:42 +05:30
Kovid Goyal
96693f4c09
Merge branch 'fix/scroll-animation-close' of https://github.com/M-Hassan-Raza/kitty
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-06 19:30:29 +05:30
Hassan Raza
3142901159
Stop scroll animations when closing a window 2026-10-06 18:51:05 +05:00
Kovid Goyal
8ca3cc0d30
Merge branch 'fix/docs-command-examples' of https://github.com/M-Hassan-Raza/kitty
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-06 17:01:25 +05:30
Hassan Raza
35c9a02018
Use launch in the remote control example 2026-10-06 16:04:16 +05:00
Hassan Raza
f8470df186
Correct the documentation dependency install command 2026-10-06 16:04:16 +05:00
Kovid Goyal
ccd671c658
Merge branch 'toplevel_data_for_drag' of https://github.com/Safari77/kitty 2026-10-06 15:37:12 +05:30
Kovid Goyal
2932c6994a
Fix #10619 2026-10-06 15:36:13 +05:30
Kovid Goyal
a73c7cbc0a
Fix #10618 2026-10-06 15:29:26 +05:30
Sami Farin
712276412a toplevel_data_for_drag: check for NULL from as_file_url
Avoid segfault in strlen() inside finish_remote_data() if
as_file_url returns NULL.
2026-10-06 12:56:57 +03:00