Commit graph

19695 commits

Author SHA1 Message Date
Kovid Goyal
aef2bc2306
Fix continuous re-rendering when a selection exists and window is scrolled
The selection dirty check computed iteration data in a different
coordinate system than apply_selection() used to store last_rendered,
so the two never compared equal when scrolled back, causing the
selection buffer to be re-uploaded and the window redrawn every frame.
Use a common helper for both.

Fixes #10714
2026-10-21 21:07:39 +05:30
Kovid Goyal
ef58de6850
Transfer kitten: Replace existing links when receiving files
Receiving a regular file over an existing symlink or hard link used to
truncate and overwrite the file the link points to. Instead, write
received files to a temporary file in the destination directory and
atomically rename it into place once the transfer completes, as was
already done for delta transfers. This also means interrupted transfers
no longer leave truncated files behind.

If the destination directory is not writable, fall back to writing in
place, but only for regular files with a single link, so that no other
file can be affected.

Also use stat rather than lstat when deciding whether to use delta
transfers, so that symlinks to large files can use them, and remove
the temporary file of failed or aborted delta transfers.

Closes #10713
2026-10-21 20:35:07 +05:30
Kovid Goyal
b4f53626d9
Update changelog 2026-10-21 20:22:36 +05:30
Kovid Goyal
1c5a4829ae
Bump go version for CVEs
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-21 11:07:18 +05:30
Kovid Goyal
cda133cd26
Fix #10711 2026-10-21 10:45:01 +05:30
Kovid Goyal
f9bd7c2085
set-spacing: Accept the *-horizontal and *-vertical edge names in kitten @
The Go parser had its own copy of the edge name mapping, which had drifted
from the Python one. Generate the Go mapping from the Python one so there
is a single source of truth, and share the documentation of the spacing
syntax between set-spacing and launch --spacing, documenting the long
forms.

Closes #10712
2026-10-21 10:20:35 +05:30
Kovid Goyal
5f45d30e36
Fix #10708
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-21 06:26:04 +05:30
Kovid Goyal
05d3ee35ff
Transfer kitten: Clearer errors when the destination is a directory
Refuse to replace an existing directory, or a symlink to a directory, with
a file, reporting EISDIR before any data is transferred instead of a raw
OSError (or silently replacing the symlink). Report failures to create
parent directories with the actual errno and directory name. When a send
fails, the kitten now prints hints for the common causes: a missing
trailing slash on a directory destination and a ~ expanded by the shell
on the remote machine.

Fixes #8118
Closes #10710
2026-10-21 06:14:21 +05:30
Kovid Goyal
d4d75646bd
Drag and drop: Fix dropping a window on a temporarily shown title bar
The title bars shown only for a window drag were hidden before the drop
was classified, which moves the windows, so a drop on a title bar was
treated as a directional insert instead of a swap.

Classify the drop in on_window_drop() before hiding them. On Wayland the
drag source can finish before the drop is delivered, so when the drop is
on kitty, on_drag_source_finished() now leaves hiding them to the drop,
falling back to hiding them if the drop never arrives.

Closes #10709
2026-10-21 06:03:46 +05:30
Kovid Goyal
e26634004d
Update changelog
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-20 12:21:00 +05:30
Kovid Goyal
72ffcb5733
macOS: Fix a possible use-after-free of the tick lock when quitting
The I/O and talk threads can call glfwPostEmptyEvent() until
Boss.destroy() joins them, which is after the main loop has returned and
released the NSLock, so they could message a freed lock. The lock only
guarded a single flag, so replace it with an atomic exchange. This
removes the lifetime problem entirely, is cheaper than locking on every
wakeup, also fixes the unsynchronized access of the flag from the main
thread and no longer drops wakeups posted before the main loop starts.

Closes #10705
2026-10-20 09:20:58 +05:30
Kovid Goyal
8da5bf3f7c
set-colors: Fix encoding of colors with special values in the Go client
wayland_titlebar_color, macos_titlebar_color, scrollbar_handle_color and
scrollbar_track_color store a special value in their lowest byte with
actual colors shifted into the upper bytes. The Go client sent them as
plain RGB values, so kitty interpreted the blue component as the special
value, for example, scrollbar_track_color=#ff0000 used the foreground
color. It also rejected special values such as background and dark.

Encode them the same way as the Python parsers do.
2026-10-20 07:39:42 +05:30
Kovid Goyal
48674a7869
set-colors: Clean up parsing of colors and conf files
Pass the CLI options to parse_colors_and_files instead of reading
global state, and have it set all and configured when reset is
specified, matching the Python client.

Read conf files with the standard config parser so that tabs,
indentation, long lines and include directives work, and report
invalid colors instead of silently ignoring them. Non-color settings
and special values of colors such as wayland_titlebar_color are still
ignored, as in the Python client.

Allow special_parse functions to take over fields that are backed by
options in the generated Go remote control code.
2026-10-20 07:32:15 +05:30
Kovid Goyal
a3da75bcef
Merge branch 'codex/fix-set-colors-reset-arguments' of https://github.com/hezhizhen/kitty 2026-10-20 07:28:54 +05:30
Kovid Goyal
e70086f64d
Merge branch 'autoformat-skip-dependencies' of https://github.com/renchris/kitty 2026-10-20 07:15:16 +05:30
Zhizhen He
de43c108f5
set-colors: Ignore color arguments when resetting colors
Skip color argument parsing for --reset, as documented and already done
by the Python command path. Add a payload-creation regression covering
invalid colors, missing files and valid colors with and without reset.
2026-10-20 00:54:13 +08:00
Chris Ren
fe8502b77a Don't autoformat the dependencies folder
./dev.sh build unpacks the prebuilt dependencies, headers included,
into the gitignored dependencies folder. autoformat walks it and runs
clang-format over the vendored headers and sources there, rewriting
them in place. Skip it like bypy and 3rdparty; setup.py clean already
excludes it.
2026-10-19 11:21:00 -05:00
Kovid Goyal
9a8c61d402
set-background-opacity: Reject NaN and improve the invalid opacity error
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
Go's min/max propagate NaN, so "nan" got past parse_opacity and failed
later with an unclear json.Marshal error, while the Python parser
silently clamped it to 0. Reject NaN in both, report a clear error
message for invalid opacity values, and replace the regression test with
a table test of parse_opacity covering clamping and invalid inputs.
2026-10-19 21:36:00 +05:30
Kovid Goyal
090003aab7
Merge branch 'codex/reject-invalid-background-opacity' of https://github.com/hezhizhen/kitty 2026-10-19 21:34:58 +05:30
Zhizhen He
5f5ae32753
set-background-opacity: Reject invalid numeric arguments
Return ParseFloat errors instead of silently treating malformed input as zero opacity. Add a payload-creation regression and changelog entry.
2026-10-19 23:42:39 +08:00
Kovid Goyal
fcd69c04c8
Merge branch 'patch-1' of https://github.com/desvaters/kitty 2026-10-19 21:06:54 +05:30
desvaters
6a7b01eed9
Restore removal of the clear progress timer on window destruction
5c4f6b39b removed the timer in Window.destroy() so that it cannot call
back into a destroyed window, but 100c78bbb dropped those lines again,
presumably by accident. Closing a window whose program had reported
progress via OSC 9;4 then leaves the timer running, and once the
progress goes stale clear_progress_if_needed() raises:

    AttributeError: 'Window' object has no attribute 'screen'
2026-10-19 16:53:40 +02:00
Kovid Goyal
29c80b42f1
Merge branch 'dependabot/github_actions/actions-90fd21f639' of https://github.com/kovidgoyal/kitty
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-19 10:49:58 +05:30
Kovid Goyal
9bba3efbe4
Merge branch 'dependabot/go_modules/all-go-deps-f51a02473e' of https://github.com/kovidgoyal/kitty 2026-10-19 10:49:42 +05:30
Kovid Goyal
24201d3080
Implement session saving on Logout for Linux as well 2026-10-19 10:49:22 +05:30
dependabot[bot]
f50296372f
Bump github/codeql-action from 4.38.2 to 4.38.3 in the actions group
Bumps the actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).


Updates `github/codeql-action` from 4.38.2 to 4.38.3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v4.38.2...v4.38.3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.38.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-10-19 03:45:51 +00:00
dependabot[bot]
3d528b0d10
Bump the all-go-deps group with 2 updates
Bumps the all-go-deps group with 2 updates: [github.com/bmatcuk/doublestar/v4](https://github.com/bmatcuk/doublestar) and [github.com/nwaples/rardecode/v2](https://github.com/nwaples/rardecode).


Updates `github.com/bmatcuk/doublestar/v4` from 4.10.2 to 4.10.3
- [Release notes](https://github.com/bmatcuk/doublestar/releases)
- [Commits](https://github.com/bmatcuk/doublestar/compare/v4.10.2...v4.10.3)

Updates `github.com/nwaples/rardecode/v2` from 2.4.2 to 2.4.4
- [Commits](https://github.com/nwaples/rardecode/compare/v2.4.2...v2.4.4)

---
updated-dependencies:
- dependency-name: github.com/bmatcuk/doublestar/v4
  dependency-version: 4.10.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-deps
- dependency-name: github.com/nwaples/rardecode/v2
  dependency-version: 2.4.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-10-19 03:42:54 +00:00
Kovid Goyal
bcc6627322
Custom shaders: Add animation_duration, animation_reverse and animation_loops
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
animation_duration sets how long animation_progress takes to rise to one,
after which it stays there, so effects can fade in and stay on. Previously
groups with no stop duration, such as toggled ones, always had a progress
of zero.

animation_reverse makes a group play its animation in reverse when it stops,
for any reason, instead of turning off immediately. With yes it takes as
long as animation_duration, or a number of milliseconds can be given.
Stopping part way through rising reverses from the current progress and
starting again while reversing rises from there.

animation_loops, used with animation_reverse, plays the animation forwards
and in reverse again after the first reverse, without holding at one, for
effects such as blinking a few times.

Also fix attached groups not having the same animation_progress as the group
they are attached to, as documented, and explain why the per-group values
are in KittyTextures rather than KittyCustomShaderData.

Fixes #10693
2026-10-19 07:57:46 +05:30
Kovid Goyal
47603c8a86
Linux: Fix updating an OSC 99 notification before it is created leaving the old notification on screen
Since the notification being replaced has no dbus id yet, it cannot be passed
as the replaces argument to Notify, so close it once the notification server
creates it.
2026-10-19 07:30:49 +05:30
Kovid Goyal
74d3477c9d
Linux: Fix OSC 99 close requests being dropped if they arrive before the notification is created
Fixes #10695
2026-10-19 07:27:08 +05:30
Kovid Goyal
4cb9765743
ssh kitten: Reconnect when a shared connection has silently died
When the connection of an existing ControlMaster to the server dies
without the master noticing, for example after a network change or
suspend, new sessions using it hang. ssh -O check does not detect this
as it only talks to the master over its local socket.

Check the master in parallel with starting the session, using a request
that requires a round trip to the server, so that there is no added
latency when the master is healthy. If the master does not respond in
time, kill the stuck session, stop the master and start the session
again over a new connection. Similarly time out the port forward request
used by forward_remote_control and retry it with a new master.

Fixes #10691
2026-10-19 07:20:03 +05:30
Kovid Goyal
baa63528da
...
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
2026-10-18 21:55:35 +05:30
Kovid Goyal
f8b1975692
set-font-size: Reject invalid sizes instead of misinterpreting them
Drop the abs() that silently flipped negative operands, reject non-finite
values and zero with an operator (which would otherwise reset the font
size). Validate in response_from_kitty too, so payloads sent by kitten @
get the same checks. Share the operator parsing with change_font_size.
2026-10-18 21:39:23 +05:30
Kovid Goyal
5275b6847d
Merge branch 'pr-10690'
# Conflicts:
#	docs/changelog.rst
2026-10-18 21:37:43 +05:30
Kovid Goyal
bd39555779
Cleanup previous PR
Shell integration: Only wrap run0 when it is installed

Do not define the run0 wrapper in bash/zsh when run0 is not on PATH, as
that makes command -v run0 succeed on systems without it. In zsh, do not
clobber a user defined run0 function. Share the TERMINFO/no-sudo guard
between the sudo and run0 wrappers in fish. Add a test and a changelog
entry.
2026-10-18 21:33:34 +05:30
Kovid Goyal
cfb9b25ec6
Merge branch 'pr-10692' 2026-10-18 21:28:12 +05:30
Arthur Cerqueira
ce6ab5124e
Shell integration: preserve TERMINFO when using run0 2026-10-18 21:28:12 +05:30
Kovid Goyal
a2b7721bfb
Fix #10694 2026-10-18 21:03:47 +05:30
Zhizhen He
23efab20d8
set-font-size: Support multiplication and division in mappings
Recognize all documented relative operators in the Python remote-control
parser and parse their numeric operand separately. Add regression coverage
for mapping dispatch with and without --all, and a changelog entry.
2026-10-18 18:56:11 +08:00
Kovid Goyal
56deb9e86d
transfer kitten: Fix receiving empty files
Some checks are pending
CI / Linux (python=3.14 cc=clang sanitize=1) (push) Waiting to run
CI / Linux (python=3.12 cc=gcc sanitize=0) (push) Waiting to run
CI / Linux (python=3.13 cc=gcc sanitize=1) (push) Waiting to run
CI / Linux package (push) Waiting to run
CI / Bundle test (macos-latest) (push) Waiting to run
CI / Bundle test (ubuntu-latest) (push) Waiting to run
CI / macOS Brew (push) Waiting to run
CI / Test ./dev.sh and benchmark (push) Waiting to run
CodeQL / CodeQL-Build (actions, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, macos-latest) (push) Waiting to run
CodeQL / CodeQL-Build (c, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (go, ubuntu-latest) (push) Waiting to run
CodeQL / CodeQL-Build (python, ubuntu-latest) (push) Waiting to run
Depscan / Scan dependencies for vulnerabilities (push) Waiting to run
The output file for a regular file was only created when the
decompressor first emitted data, which never happens for an empty file.
So empty files were not created and existing destination files were
left with their old contents. Open the output file as soon as the first
chunk for a regular file arrives instead.

Closes #10689
2026-10-18 14:33:13 +05:30
Kovid Goyal
3494fbda51
action: Give context in remote control parse error messages
Include the action definition in the error and avoid the quoted repr
that str() produces for KeyError. Use a spec'd Mock in the tests so
unexpected Boss attribute access fails, and reference the PR in the
changelog.
2026-10-18 14:16:11 +05:30
Kovid Goyal
9b8124ac23
Merge branch 'pr-10688' 2026-10-18 14:15:01 +05:30
Zhizhen He
9c21523215
action: Report parsing errors to remote control clients 2026-10-18 15:48:36 +08:00
Kovid Goyal
2d59dd477a
... 2026-10-18 12:55:28 +05:30
Kovid Goyal
26ebab22da
Merge branch 'fix/cli-required-values' of https://github.com/M-Hassan-Raza/kitty 2026-10-18 12:55:00 +05:30
Kovid Goyal
7871d53ab1
Fix #10686 2026-10-18 12:54:26 +05:30
Hassan Raza
3d3d2abfe0
Reference the CLI option fix in the changelog 2026-10-18 11:49:00 +05:00
Hassan Raza
a77b763960
Cover missing values after grouped and repeated options 2026-10-18 11:47:32 +05:00
Hassan Raza
608e46be33
Reject options whose required value is missing 2026-10-18 11:46:17 +05:00
Hassan Raza
b1df817c44
Cover missing values on CLI option aliases 2026-10-18 11:45:33 +05:00