mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-11-19 14:40:27 +00:00
Problem: a custom location with `proxy_set_header X-Test $missing_variable;` still blocked the whole host save. nginx reports `unknown "missing_variable" variable` without file or line (variables are checked after parsing), so the error never reached the per-location quarantine, which needs a line inside a location's markers. The check without this host passed, so the save was rejected as a "conflict with another host"; in bulk mode (startup, repair of another host) the whole host went offline instead of the one location. Fix: lib/nginx-locations.js gets isolateFaultyLocations(). When an error has no line and only this host's config causes it (no file named and the test without the host passes, or the host's file named without a line), configureHost() stubs the rendered locations: if the error stays with all of them stubbed it comes from the host itself and the result is unchanged. Otherwise each location is rendered alone with all the others still stubbed, and every one that brings the same error back is quarantined. Two broken locations with the same message are thus both found, and a working location is never quarantined for them (stubbing one at a time would leave the other's identical error and blame every candidate). Only when none fails alone (they fail only together) is each one stubbed alone and the first that makes the error go away (or change) quarantined, all of them when none does. The loop then tests the full config again, bounded by maxQuarantines as before. In a nested configure it is skipped when the host being saved is the cause (causedByProtected() handles that as before). After the search the config that failed is written back to the host's file, so a host rejected at host level in bulk mode keeps its real config as .err for inspection, not the last stubbed variant. When no location is to blame (the error stays with all of them stubbed, or the host has none), the host level check from the feat(nginx) commit applies as before: the host is only rejected as a conflict with another host when the error goes away with every other host's config moved aside (failsAlone()), otherwise it fails with a host level error such as `Advanced configuration: unknown variable "$x"`. Tests: nginx-location-isolate.test.js with unit tests for the search and configureHost() against a fake nginx -t that reports unknown variables without a line: the bad location is quarantined (503 stub) and the host stays online; two bad locations with different variables are both quarantined; two bad locations with the same variable around a clean one quarantine only the two, the clean one stays ok; the same variable in the host's advanced config still rejects the host at host level with an "Advanced configuration" message (not a conflict with another host), also for a host without locations, and in bulk mode its .err file holds the real config (proxy_pass, the variable), not 503 stubs, and its nginx_err names the advanced configuration. Cypress (ProxyHostLocations): a location with `$missing_variable` is quarantined with an unknown-variable message, the host stays online, its other location serves and the bad one answers 503. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| .vitepress | ||
| scripts | ||
| src | ||
| .gitignore | ||
| package.json | ||
| yarn.lock | ||