mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-11-19 14:40:27 +00:00
A location saved before v2.17 with forward host `app-$stage` (and `set $stage prod;` in its advanced config) answered 503 after the startup regeneration: preflightLocation() only allowed a host that is exactly one `$name` and quarantined every other host with a `$`. The renderer before custom location modes, and develop, write any stored value that can't add directives literally (`proxy_pass http://app-$stage:80;`), which works. isVariableHost() now accepts a forward host with an nginx variable that has none of the characters that would break out of the directive, the same structural rule as lib/nginx-values.js applies to stored rows: such a host is rendered literally (static, no DNS check, no rewrite) as `$backend` is, also with NPM_LOCATION_DYNAMIC_DNS=false. Braces (`app-${stage}`), spaces and `;` are still quarantined. The API refuses `$` in a forward host since v2.17, so this only concerns rows saved before. The frontend's isVariableHost() follows the same rule (no upstream check for such hosts). Tests: unit tests for the preflight, mode and rendering; nginx semantics harness cases /varmix/, /varmixfp/ and /vmrx/ (`ec$semhost`) compared with the legacy rendering (they answered 503 before, DIFFS=0 now). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| .vitepress | ||
| scripts | ||
| src | ||
| .gitignore | ||
| package.json | ||
| yarn.lock | ||