mirror of
https://github.com/docker/compose.git
synced 2026-11-20 15:09:50 +00:00
Several e2e tests used fixed host ports (8070, 8080, 8090, etc.), global buildx builders registered with --use, and a hardcoded IPC container name. Under parallel execution these shared daemon-level resources caused port conflicts, buildkitd container-name collisions, and intermittent failures. Separately, the standalone make target hardcoded -parallel=1, forcing the entire standalone suite to run serially even though the same tests run in parallel in plugin mode. Changes: - Convert fixed host ports in four fixtures (network-test, sentences, build-test, volume-test) to ephemeral bindings; add ServicePublishedPort helper to framework.go to resolve the actual mapped port at runtime. - Give each buildx-builder test a unique daemon-scoped name via BuilderName helper, preventing container-name collisions between parallel goroutines. Applies to TestBuildPlatformsWithCorrectBuildxConfig, TestBuildPrivileged, TestBuildBuilder, TestBuildEntitlements, TestBuildTLS. - Rename the fixed ipc_mode_container to a project-scoped name (ipc_e2e-src) and update the ipc-test fixture accordingly. - Replace the hardcoded -parallel=1 in make e2e-compose-standalone with E2E_PARALLEL_PLUGIN?=4 and E2E_STANDALONE_PARALLEL?=4, aligning both modes with the effective GOMAXPROCS on 4-core GitHub Actions runners. Both variables are overridable (E2E_STANDALONE_PARALLEL=1 restores serial local debugging). - Raise the poll delay in watch_test.go long-running polls (90s/120s timeout) from the default 100ms to 1s; bump cascade_test.go and publish_test.go from 100ms to 500ms. Reduces CPU pressure without affecting effective test duration. The logging-driver fixture retains its fixed port 24224: the Docker fluentd log driver encodes fluentd-address at service-start time, making ephemeral resolution non-trivial. TestLoggingDriver is serial so there is no collision risk in practice. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
73 lines
2.4 KiB
Go
73 lines
2.4 KiB
Go
//go:build !windows
|
|
|
|
/*
|
|
Copyright 2022 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/icmd"
|
|
"gotest.tools/v3/poll"
|
|
)
|
|
|
|
func TestCascadeStop(t *testing.T) {
|
|
NewScenario(t, "up --abort-on-container-exit must stop the project on the first exit, and exit 0 without --exit-code-from").
|
|
Step("up aborts once a container exits, reporting which one",
|
|
ComposeCmd("up", "--abort-on-container-exit").Within(60*time.Second),
|
|
OutputContains("exit-1 exited with code 0"),
|
|
ServiceState("running", "exited"))
|
|
}
|
|
|
|
func TestCascadeFail(t *testing.T) {
|
|
NewScenario(t, "up --abort-on-container-failure must propagate the failing container's exit code").
|
|
Step("up keeps going on clean exits and aborts on the failure, with its exit code",
|
|
ComposeCmd("up", "--abort-on-container-failure").MayFail().Within(60*time.Second),
|
|
ExitCode(111),
|
|
OutputContains("exit-1 exited with code 0"),
|
|
OutputContains("fail-1 exited with code 111"),
|
|
ServiceState("running", "exited"))
|
|
}
|
|
|
|
func TestCascadeIgnoresOneOffContainer(t *testing.T) {
|
|
const projectName = "compose-e2e-cascade-oneoff"
|
|
c := NewCLI(t, WithEnv("COMPOSE_PROJECT_NAME="+projectName))
|
|
t.Cleanup(func() {
|
|
c.RunDockerComposeCmd(t, "down")
|
|
})
|
|
|
|
cmd := c.NewDockerComposeCmd(t, "-f", "./fixtures/cascade/compose.yaml",
|
|
"up", "--abort-on-container-exit", "--menu=false", "running")
|
|
res := icmd.StartCmd(cmd)
|
|
t.Cleanup(func() {
|
|
_ = res.Cmd.Process.Kill()
|
|
})
|
|
|
|
poll.WaitOn(t, expectOutput(res, "Attaching to running-1"),
|
|
poll.WithDelay(500*time.Millisecond), poll.WithTimeout(30*time.Second))
|
|
|
|
c.RunDockerComposeCmd(t, "-f", "./fixtures/cascade/compose.yaml",
|
|
"run", "--rm", "--no-deps", "running", "/bin/true")
|
|
|
|
time.Sleep(3 * time.Second)
|
|
|
|
assert.Assert(t, !strings.Contains(res.Combined(), "Aborting on container exit"), res.Combined())
|
|
RequireServiceState(t, c, "running", "running")
|
|
}
|