mirror of
https://github.com/docker/compose.git
synced 2026-11-17 21:57:19 +00:00
A pre_start hook's output never reached anyone. The follow log stream was opened on the runner while it was still in "created" state, before ContainerStart; the engine ends such a stream at once, empty. So a foreground up never showed the hook's output, and the error of a failing hook carried no tail, though both are built from that stream. The stream is now opened once the hook is started. The runner is retained after it exits (AutoRemove is off), so a fast-exiting hook cannot make the stream hit a 404, which is what opening it first was meant to prevent. Once the hook has exited, the stream gets a short, bounded delay to deliver what the daemon buffered before it is cut, instead of being cut right away. The unit tests that pinned the old call order now pin the new one, and a scenario locks that a failing hook reports what it printed. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||