compose/cmd/compose/push_test.go
Guillaume Lours 289d8a0378
Some checks failed
ci / validate (lint) (push) Has been cancelled
ci / validate (relay-lint) (push) Has been cancelled
ci / validate (relay-test) (push) Has been cancelled
ci / validate (validate-docs) (push) Has been cancelled
ci / validate (validate-go-mod) (push) Has been cancelled
ci / validate (validate-headers) (push) Has been cancelled
ci / validate (validate-mocks) (push) Has been cancelled
ci / binary (push) Has been cancelled
ci / bin-image-test (push) Has been cancelled
ci / relay-image-test (push) Has been cancelled
ci / test (push) Has been cancelled
ci / e2e (plugin, oldstable, graphdriver) (push) Has been cancelled
ci / e2e (standalone, oldstable, graphdriver) (push) Has been cancelled
ci / e2e (plugin, stable, containerd) (push) Has been cancelled
ci / e2e (plugin, stable, graphdriver) (push) Has been cancelled
ci / e2e (standalone, stable, containerd) (push) Has been cancelled
ci / e2e (standalone, stable, graphdriver) (push) Has been cancelled
docs-upstream / docs-yaml (push) Has been cancelled
merge / bin-image-prepare (push) Has been cancelled
merge / relay-image (push) Has been cancelled
merge / module-image (push) Has been cancelled
Scorecards supply-chain security / Scorecards analysis (push) Has been cancelled
zizmor / zizmor (push) Has been cancelled
ci / binary-finalize (push) Has been cancelled
ci / coverage (push) Has been cancelled
ci / ci-ok (push) Has been cancelled
ci / release (push) Has been cancelled
docs-upstream / validate (push) Has been cancelled
merge / bin-image (push) Has been cancelled
feat(push): deprecate --ignore-push-failures in favor of --ignore-missing
--ignore-push-failures swallows every push error, including
authentication and registry ones, which hides real problems when the
only expectation is that some images were never built. --ignore-missing
now covers that case on its own.

Keep the flag working but mark it deprecated: it prints a warning and
is hidden from help and docs. Make it mutually exclusive with
--ignore-missing so the two cannot be combined ambiguously.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
2026-10-16 18:08:20 +02:00

64 lines
2.1 KiB
Go

/*
Copyright 2026 Docker Compose CLI authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package compose
import (
"bytes"
"strings"
"testing"
"github.com/spf13/cobra"
"gotest.tools/v3/assert"
)
func TestPushIgnorePushFailuresIsNotDiscoverable(t *testing.T) {
cmd := pushCommand(&ProjectOptions{}, nil, &BackendOptions{})
assert.Assert(t, !strings.Contains(cmd.UsageString(), "ignore-push-failures"))
}
// The real push command is run with RunE stubbed out, so only flag parsing
// and validation are exercised.
func TestPushIgnoreFlags(t *testing.T) {
tests := []struct {
name string
args []string
wantWarning bool
wantErr string
}{
{name: "ignore-push-failures is deprecated but usable", args: []string{"--ignore-push-failures"}, wantWarning: true},
{name: "ignore-missing alone", args: []string{"--ignore-missing"}},
{name: "both flags are mutually exclusive", args: []string{"--ignore-push-failures", "--ignore-missing"}, wantWarning: true, wantErr: "none of the others can be"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
cmd := pushCommand(&ProjectOptions{}, nil, &BackendOptions{})
cmd.RunE = func(*cobra.Command, []string) error { return nil }
var out bytes.Buffer
cmd.SetOut(&out)
cmd.SetErr(&out)
cmd.SetArgs(tt.args)
err := cmd.ExecuteContext(t.Context())
if tt.wantErr == "" {
assert.NilError(t, err)
} else {
assert.ErrorContains(t, err, tt.wantErr)
}
assert.Equal(t, strings.Contains(out.String(), "--ignore-push-failures has been deprecated"), tt.wantWarning, out.String())
})
}
}