mirror of
https://github.com/docker/compose.git
synced 2026-11-17 05:36:08 +00:00
Transposes the applicable findings from the review of the ttyWriter fix (#14119) to the rewritten renderer: - Done waits for the refresh goroutine to exit (outside the lock), so nothing can repaint after Done returns and output printed right after an operation cannot be garbled by a stray frame - a nested Start retires the previous cycle instead of leaking its refresh goroutine until the parent context is cancelled - build suspension no longer leaks across cycles: Start resets it and starts a fresh block below whatever buildkit wrote - drop the dead strings.ToLower in startDependencies: the unexported start only reads projectName when no Project is passed The remaining findings are structural to this rewrite: Done is a single critical section, and per-cycle context cancellation replaces the doneSignal handshake. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| colors.go | ||
| dryrun.go | ||
| json.go | ||
| json_test.go | ||
| mode.go | ||
| plain.go | ||
| quiet.go | ||
| tty.go | ||
| tty_layout.go | ||
| tty_model.go | ||
| tty_screen.go | ||
| tty_test.go | ||