Second Copilot review finding in the same vein as the previous network/volume fix: collectObservedState's mergeHookContainers call (getHookContainers, an extra ContainerList with a hook-specific label filter) is consumed exclusively by create-phase runner reconciliation (planPreStartHookRunners, reconcile.go) -- the start phase's own RunPreStart never reads observed.HookContainers at all; it executes a runner the create phase already prepared, or fails outright if none exists. Performing this query unconditionally meant a no-op `compose start` on a service declaring pre_start hooks could fail on a daemon call the old imperative engine never made. Gated behind the same scope.plansCreatePhase() check as the network/ volume listing. New regression test TestCollectObservedState_ScopeStartSkipsHookContainerQuery registers exactly one ContainerList expectation (the default Times(1)): gomock fails the test if the extra hook-container listing fires under ScopeStart. Verified by ablation (reverting the guard reproduces the failure deterministically, 3/3 runs). Verified: go build, go test ./pkg/compose/..., and golangci-lint all clean; full e2e suite re-run clean against a locally built binary (same 3 pre-existing, environment-specific failures as the stack's baseline: TestWatch, TestIPC, TestComposeModel). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .github | ||
| cmd | ||
| desktop-module | ||
| docs | ||
| internal | ||
| pkg | ||
| relay | ||
| .dockerignore | ||
| .gitattributes | ||
| .gitignore | ||
| .go-version | ||
| .golangci.yml | ||
| AGENTS.md | ||
| AI_POLICY.md | ||
| BUILDING.md | ||
| CLAUDE.md | ||
| codecov.yml | ||
| CONTRIBUTING.md | ||
| docker-bake.hcl | ||
| Dockerfile | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| logo.png | ||
| Makefile | ||
| NOTICE | ||
| README.md | ||
Table of Contents
Docker Compose
Docker Compose is a tool for running multi-container applications on Docker
defined using the Compose file format.
A Compose file is used to define how one or more containers that make up
your application are configured.
Once you have a Compose file, you can create and start your application with a
single command: docker compose up.
Note
Docker Swarm used to rely on the legacy compose file format but did not adopt the compose specification so is missing some of the recent enhancements in the compose syntax. After acquisition by Mirantis swarm isn't maintained by Docker Inc, and as such some Docker Compose features aren't accessible to swarm users.
Where to get Docker Compose
Windows and macOS
Docker Compose is included in Docker Desktop for Windows and macOS.
Linux
You can download Docker Compose binaries from the release page on this repository.
Rename the relevant binary for your OS to docker-compose and copy it to $HOME/.docker/cli-plugins
Or copy it into one of these folders to install it system-wide:
/usr/local/lib/docker/cli-pluginsOR/usr/local/libexec/docker/cli-plugins/usr/lib/docker/cli-pluginsOR/usr/libexec/docker/cli-plugins
(might require making the downloaded file executable with chmod +x)
Quick Start
Using Docker Compose is a three-step process:
- Define your app's environment with a
Dockerfileso it can be reproduced anywhere. - Define the services that make up your app in
compose.yamlso they can be run together in an isolated environment. - Lastly, run
docker compose upand Compose will start and run your entire app.
A Compose file looks like this:
services:
web:
build: .
ports:
- "5000:5000"
volumes:
- .:/code
redis:
image: redis
Contributing
Want to help develop Docker Compose? Check out our contributing documentation.
If you find an issue, please report it on the issue tracker.
Legacy
The Python version of Compose is available under the v1 branch.
