compose/pkg/compose
Nicolas De Loof cca3bfbe6a fix(up): drain in-flight log streams before tearing the session down
TestAttachRestart kept failing residually after the re-attach anchoring
fix, and its new daemon-view dump told exactly why: the daemon holds
all three 'world' lines while compose printed two. The monitor returns
on the final die event — an events-channel fact — and up canceled the
global context on the spot, killing the re-attach log streams with the
last run's line still in flight: the exit notice outran the output that
preceded it.

Re-attach streams are now counted in a WaitGroup, and the monitor
wrapper waits for them to reach their natural EOF — guaranteed once the
containers exited — before canceling, under a bound that only protects
against a wedged daemon and is skipped entirely when the context is
already down (Ctrl-C). AttachRestart passes 5/5 locally with this
drain; it failed within 2 CI attempts without it.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-09-22 14:45:23 +02:00
..
testdata
transform chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
api_versions.go
apiSocket.go
attach.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
attach_service.go
build.go remove buildx as a Go dependency 2026-08-25 17:27:26 +02:00
build_bake.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
build_bake_test.go fix(build): honor provenance/sbom false in per-service bake attest 2026-08-25 17:46:03 +02:00
build_classic.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
build_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
commit.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
compose.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
container.go
containers.go chore(compose): orphan semantics stated where up and down diverge 2026-08-31 17:09:19 +02:00
containers_test.go chore(compose): orphan semantics stated where up and down diverge 2026-08-31 17:09:19 +02:00
convert.go
cp.go feat(provider): publish-endpoint deploys a network relay for provider services 2026-09-16 17:03:23 +02:00
create.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
create_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
dependencies.go refactor: NewGraph stops mutating the project 2026-09-01 10:19:10 +02:00
dependencies_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
desktop.go
docker_cli_providers.go
down.go fix(provider): guard down's stopContainer against the relay too 2026-09-17 17:51:23 +02:00
down_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
envresolver.go
envresolver_test.go
events.go
exec.go feat(provider): publish-endpoint deploys a network relay for provider services 2026-09-16 17:03:23 +02:00
executor.go executor: split into ops + events files 2026-06-08 20:14:38 +02:00
executor_events.go executor: split into ops + events files 2026-06-08 20:14:38 +02:00
executor_ops.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
executor_test.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
export.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
filters.go feat(hooks): clean up retained pre_start containers on compose down 2026-08-20 18:57:02 +02:00
generate.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
hash.go fix(hash): repair the tests after #14093 and #14215 merged in reverse order 2026-09-22 11:03:06 +02:00
hash_test.go fix(hash): repair the tests after #14093 and #14215 merged in reverse order 2026-09-22 11:03:06 +02:00
hook.go feat(hooks): clean up retained pre_start containers on compose down 2026-08-20 18:57:02 +02:00
hook_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
image_pruner.go fix(down): spare dangling images of orphaned services, like their tagged image 2026-09-03 16:00:29 +02:00
image_pruner_test.go fix(down): spare dangling images of orphaned services, like their tagged image 2026-09-03 16:00:29 +02:00
images.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
images_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
kill.go
kill_test.go
loader.go feat(compose): warn on unsupported compose-file attributes 2026-09-09 16:32:04 +02:00
loader_test.go
logs.go docs(logs): why a timestampless exit is dropped, not patched 2026-09-22 14:45:23 +02:00
logs_test.go fix(logs): anchor restart re-attach on the previous run's end, not the new run's start 2026-09-22 14:45:23 +02:00
ls.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
ls_test.go
model.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
monitor.go feat(provider): publish-endpoint deploys a network relay for provider services 2026-09-16 17:03:23 +02:00
monitor_test.go fix: detect externally stopped and removed containers in up monitor 2026-09-16 07:54:38 +02:00
observed_state.go chore(compose): orphan semantics stated where up and down diverge 2026-08-31 17:09:19 +02:00
observed_state_test.go chore(compose): orphan semantics stated where up and down diverge 2026-08-31 17:09:19 +02:00
pause.go
plan.go feat(reconcile): best-effort old-network removal on rename 2026-07-27 14:56:25 +02:00
plan_test.go tests: cover depends_on chaining and OpRunProvider stringer 2026-06-08 20:14:38 +02:00
plugins.go fix(provider): guard pre_start against the relay too, address review nits 2026-09-17 17:51:23 +02:00
plugins_control_test.go feat(provider): get-service-config provider request 2026-09-08 14:53:14 +02:00
plugins_test.go
port.go PRIVATE_PORT optional for docker compose port 2026-09-11 11:35:18 +02:00
port_test.go fix(port): preserve tie order for dual-stack port publishers 2026-09-14 10:48:03 +02:00
pre_start.go pre_start: consume the load-time-resolved hook specification 2026-09-21 16:35:20 +02:00
pre_start_test.go pre_start: consume the load-time-resolved hook specification 2026-09-21 16:35:20 +02:00
printer.go
progress.go
ps.go fix(port): preserve tie order for dual-stack port publishers 2026-09-14 10:48:03 +02:00
ps_test.go
publish.go publish, config --images: jobs are scanned and pinned like services 2026-09-21 16:35:20 +02:00
publish_test.go publish, config --images: jobs are scanned and pinned like services 2026-09-21 16:35:20 +02:00
pull.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
pull_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
push.go registry: encode credentials with moby's authconfig package 2026-08-25 17:27:26 +02:00
rebuild_scheduler.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
rebuild_scheduler_test.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
reconcile.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
reconcile_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
relay.go fix(provider): drop the relay's capabilities to the strict minimum 2026-09-17 17:51:23 +02:00
relay_test.go fix(compose): adapt relay/start tests to the container-spec layering 2026-09-21 16:35:20 +02:00
remove.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
restart.go fix(provider): clean up stale relay and guard start/restart against it 2026-09-17 17:51:23 +02:00
restart_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
run.go fix(display): harden termWriter lifecycle against review findings on #14119 2026-09-09 16:50:05 +02:00
scale.go api: ScaleOptions carries the replica counts it always pretended to 2026-08-20 10:16:06 +02:00
scale_test.go api: ScaleOptions carries the replica counts it always pretended to 2026-08-20 10:16:06 +02:00
secrets.go chore: inline needless single-use helpers 2026-08-14 22:49:53 +02:00
service_containers.go fix(provider): guard pre_start against the relay too, address review nits 2026-09-17 17:51:23 +02:00
service_containers_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
shellout.go
start.go refactor: NewGraph stops mutating the project 2026-09-01 10:19:10 +02:00
start_test.go fix(compose): adapt relay/start tests to the container-spec layering 2026-09-21 16:35:20 +02:00
stop.go fix(provider): stop reaches the relay container like down already does 2026-09-16 17:03:23 +02:00
stop_test.go
top.go
unsupported_attributes.go feat(compose): warn on unsupported compose-file attributes 2026-09-09 16:32:04 +02:00
unsupported_attributes_test.go feat(compose): warn on unsupported compose-file attributes 2026-09-09 16:32:04 +02:00
up.go fix(up): drain in-flight log streams before tearing the session down 2026-09-22 14:45:23 +02:00
up_test.go fix(up): drop benign context.Canceled noise from the final report 2026-09-16 13:54:05 +02:00
viz.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
viz_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
volumes.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
volumes_test.go
wait.go fix(wait): a target that already exited is a satisfied wait, not an error 2026-09-22 14:45:23 +02:00
wait_test.go fix(wait): a target that already exited is a satisfied wait, not an error 2026-09-22 14:45:23 +02:00
watch.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
watch_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00