compose/pkg/compose
Nicolas De Loof c87307b89f fix(reconcile): keep each dependency's wait timeout independent
Reverts 365f0026f, a behavior-parity fix for a Copilot finding that the
plan-based start engine's per-(dependency,condition) wait node could
start its exec.waitTimeout clock earlier than the old imperative
engine's single waitDependencies(X) call -- which only begins once
EVERY direct dependency of X has itself finished starting, so a slow
sibling with no wait node of its own could silently extend another
dependency's effective grace period.

On reflection that old-engine coupling is itself the bug: a service's
declared --wait-timeout for a given dependency should bound how long
THAT dependency takes to satisfy its condition, period -- not be
inflated by how long an unrelated sibling dependency happens to take
to start. Letting db's health-check timeout silently grow because
migrate's own dependency chain is slow means --wait-timeout no longer
means what it says. Restoring the narrower, per-dependency gating is a
deliberate, accepted behavior change from the old engine, not a parity
regression to chase.

This also removes the dependency-cycle risk the sibling-widening
introduced (an ordinary diamond dependency, or a service whose own
chain end collapses onto a shared wait node, could merge a node back
into its own transitive dependents -- see 365f0026f's description) and
the wouldCreateCycle machinery and five regression tests that existed
solely to guard against it, now dead weight with no reachable scenario
to protect against.

Verified: go build, go test ./pkg/compose/..., and golangci-lint all
clean.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-10-15 14:52:20 +02:00
..
testdata
transform chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
api_versions.go
apiSocket.go
attach.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
attach_service.go
build.go feat(provider): providers take part in the image phase of up and pull 2026-10-02 17:35:20 +02:00
build_bake.go fix(build): read bake's stderr to the end before waiting for it 2026-10-13 13:57:32 +02:00
build_bake_test.go fix(build): read bake's stderr to the end before waiting for it 2026-10-13 13:57:32 +02:00
build_classic.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
build_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
commit.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
compose.go refactor(up): inject the navigation menu instead of importing cmd/formatter 2026-10-12 10:50:38 +02:00
compose_test.go refactor(compose): hold per-service state on composeService instead of package globals 2026-10-12 10:21:55 +02:00
container.go
containers.go fix: share --parallel budget across down's ops and up's log-attach 2026-10-01 16:02:14 +02:00
containers_test.go chore(compose): orphan semantics stated where up and down diverge 2026-08-31 17:09:19 +02:00
convert.go
cp.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
cp_test.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
create.go feat: detached up runs on a single plan 2026-10-15 14:52:20 +02:00
create_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
dependencies.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
dependencies_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
desktop.go refactor: drop Desktop beta-settings check; gate hint on LogsTab flag 2026-05-18 17:28:03 +02:00
docker_cli_providers.go
down.go api: DownOptions.Images becomes a typed ImagePruneMode, validated upfront 2026-10-06 11:31:22 +02:00
down_test.go api: DownOptions.Images becomes a typed ImagePruneMode, validated upfront 2026-10-06 11:31:22 +02:00
envresolver.go
envresolver_test.go
exec.go feat(provider): publish-endpoint deploys a network relay for provider services 2026-09-16 17:03:23 +02:00
executor.go fix(executor): tell an optional wait's own timeout from an inherited deadline 2026-10-15 14:52:20 +02:00
executor_events.go fix(executor): a failed pre_start no longer lets start fire its own event 2026-10-06 14:11:22 +02:00
executor_ops.go fix(executor): tell an optional wait's own timeout from an inherited deadline 2026-10-15 14:52:20 +02:00
executor_start_test.go fix(executor): tell an optional wait's own timeout from an inherited deadline 2026-10-15 14:52:20 +02:00
executor_test.go feat: executor runs start-phase operations 2026-10-06 14:11:22 +02:00
executor_wait_slot_test.go test(executor): make the wait-slot regression test deterministic and portable 2026-10-14 15:26:36 +02:00
export.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
filters.go feat(hooks): clean up retained pre_start containers on compose down 2026-08-20 18:57:02 +02:00
hash.go fix(hash): repair the tests after #14093 and #14215 merged in reverse order 2026-09-22 11:03:06 +02:00
hash_test.go fix(hash): repair the tests after #14093 and #14215 merged in reverse order 2026-09-22 11:03:06 +02:00
hook.go feat(hooks): clean up retained pre_start containers on compose down 2026-08-20 18:57:02 +02:00
hook_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
image_pruner.go fix(down): reuse Mode.Valid() instead of re-deriving legal values 2026-10-06 11:31:22 +02:00
image_pruner_test.go test(down): cover ImagesToPrune's own invalid-mode rejection 2026-10-06 11:31:22 +02:00
images.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
images_test.go feat(provider): providers take part in the image phase of up and pull 2026-10-02 17:35:20 +02:00
inspect.go refactor(inspect): move the read-only operations to internal/inspect 2026-10-13 10:03:53 +02:00
kill.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
kill_test.go
logs.go fix(logs): relay each line of a restarted container exactly once 2026-10-09 16:41:51 +02:00
logs_cursor_test.go fix(logs): relay each line of a restarted container exactly once 2026-10-09 16:41:51 +02:00
logs_test.go fix(logs): relay each line of a restarted container exactly once 2026-10-09 16:41:51 +02:00
model.go fix(models): do not pull nor configure models in dry-run mode 2026-10-13 13:44:27 +02:00
model_test.go fix(models): do not pull nor configure models in dry-run mode 2026-10-13 13:44:27 +02:00
monitor.go refactor(relay): move the provider relay management to internal/relay 2026-10-15 09:10:05 +02:00
monitor_test.go fix: detect externally stopped and removed containers in up monitor 2026-09-16 07:54:38 +02:00
navigation_menu.go refactor(up): let the navigation menu own the keyboard 2026-10-12 10:50:38 +02:00
observed_state.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
observed_state_test.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
pause.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
plan.go feat: reconciliation plan creates pre_start hook runners 2026-09-30 12:03:10 +02:00
plan_test.go tests: cover depends_on chaining and OpRunProvider stringer 2026-06-08 20:14:38 +02:00
plugins.go refactor(provider): move the provider plugin execution to internal/provider 2026-10-15 09:10:05 +02:00
plugins_test.go refactor(provider): move the provider plugin execution to internal/provider 2026-10-15 09:10:05 +02:00
port_test.go refactor(inspect): move the read-only operations to internal/inspect 2026-10-13 10:03:53 +02:00
pre_start.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
pre_start_test.go feat: reconciliation plan creates pre_start hook runners 2026-09-30 12:03:10 +02:00
printer.go
progress.go fix: restore stoppingEvent/stoppedEvent helpers for plugin stop hook 2026-05-18 15:12:39 +02:00
projectloader.go refactor(projectloader): move project loading and generation to internal/projectloader 2026-10-13 10:03:53 +02:00
provider_images.go fix(provider): address review findings on image distribution 2026-10-02 17:35:20 +02:00
provider_images_test.go refactor(provider): move the provider plugin execution to internal/provider 2026-10-15 09:10:05 +02:00
ps_test.go
publish.go feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
publish_test.go publish, config --images: jobs are scanned and pinned like services 2026-09-21 16:35:20 +02:00
pull.go docs(registry): trim comments 2026-10-07 14:24:28 +02:00
pull_test.go feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
push.go feat(push): add --ignore-missing to skip images not available locally 2026-10-14 21:34:38 +02:00
push_test.go test(push): pin --ignore-missing behavior under --dry-run 2026-10-14 21:34:38 +02:00
rebuild_scheduler.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
rebuild_scheduler_test.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
reconcile.go fix(reconcile): keep each dependency's wait timeout independent 2026-10-15 14:52:20 +02:00
reconcile_start_test.go fix(reconcile): keep each dependency's wait timeout independent 2026-10-15 14:52:20 +02:00
reconcile_test.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
relay.go refactor(provider): move the provider plugin execution to internal/provider 2026-10-15 09:10:05 +02:00
relay_test.go refactor(provider): move the provider plugin execution to internal/provider 2026-10-15 09:10:05 +02:00
remove.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
restart.go fix: share --parallel budget across down's ops and up's log-attach 2026-10-01 16:02:14 +02:00
restart_test.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
run.go feat(run): --no-recreate reuses existing dependencies as-is 2026-10-14 09:34:19 +02:00
run_test.go fix: keep the image pull of compose run inside the run progress block 2026-10-13 10:02:09 +02:00
scale.go api: ScaleOptions carries the replica counts it always pretended to 2026-08-20 10:16:06 +02:00
scale_test.go api: ScaleOptions carries the replica counts it always pretended to 2026-08-20 10:16:06 +02:00
secrets.go chore: inline needless single-use helpers 2026-08-14 22:49:53 +02:00
service_containers.go fix(executor): tell an optional wait's own timeout from an inherited deadline 2026-10-15 14:52:20 +02:00
service_containers_test.go fix(service_containers): don't swallow an inherited deadline as a wait timeout 2026-10-15 14:52:20 +02:00
shellout.go
start.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
start_test.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
stop.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
stop_test.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
up.go fix(up): preserve the actionable dependency-timeout message without --wait 2026-10-15 14:52:20 +02:00
up_test.go fix(up): give each wait its own fresh --wait-timeout window 2026-10-15 14:52:20 +02:00
viz_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
volumes_test.go
wait.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
wait_test.go fix: wait rejects dry-run with a clear error 2026-09-30 14:47:16 +02:00
watch.go fix(watch): skip sync+exec triggers on bind-mounted paths 2026-10-12 17:02:20 +02:00
watch_test.go fix(watch): skip sync+exec triggers on bind-mounted paths 2026-10-12 17:02:20 +02:00