mirror of
https://github.com/docker/compose.git
synced 2026-11-21 23:50:17 +00:00
Copilot review: planProviderStart used a provider's own depends_on wait nodes as its startChainEnds whenever it had any, entirely dropping its own OpRunProvider (deployment) node from that set. A downstream consumer of the provider -- ordered after startChainEnds -- would then only wait for the provider's dependency to become healthy, not for the provider plugin/relay deployment itself to finish. The old create-then-start two-phase barrier guaranteed that ordering for free; ScopeCreateStart (inert until this PR actually exercised it end to end) didn't reproduce it. ends now always includes the provider's own node alongside its dependency prerequisites when it has any, instead of either/or. TestPlanStart_ProviderConsumerWaitsForDeployment pins it: a provider with both an upstream dependency and a downstream consumer, asserting the consumer's start node depends on the provider's OpRunProvider node directly -- verified by ablation to fail (showing the exact missing edge) without the fix. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||