mirror of
https://github.com/docker/compose.git
synced 2026-11-17 21:57:19 +00:00
|
Some checks failed
ci / validate (lint) (push) Waiting to run
ci / validate (validate-docs) (push) Waiting to run
ci / validate (validate-go-mod) (push) Waiting to run
ci / validate (validate-headers) (push) Waiting to run
ci / validate (validate-mocks) (push) Waiting to run
ci / binary (push) Waiting to run
ci / binary-finalize (push) Blocked by required conditions
ci / bin-image-test (push) Waiting to run
ci / relay-image-test (push) Waiting to run
ci / test (push) Waiting to run
ci / e2e (plugin, oldstable, graphdriver) (push) Waiting to run
ci / e2e (standalone, oldstable, graphdriver) (push) Waiting to run
ci / e2e (plugin, stable, containerd) (push) Waiting to run
ci / e2e (plugin, stable, graphdriver) (push) Waiting to run
ci / e2e (standalone, stable, containerd) (push) Waiting to run
ci / e2e (standalone, stable, graphdriver) (push) Waiting to run
ci / coverage (push) Blocked by required conditions
ci / release (push) Blocked by required conditions
merge / bin-image-prepare (push) Waiting to run
merge / bin-image (push) Blocked by required conditions
merge / relay-image (push) Waiting to run
merge / module-image (push) Waiting to run
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
zizmor / zizmor (push) Waiting to run
docs-upstream / docs-yaml (push) Has been cancelled
docs-upstream / validate (push) Has been cancelled
`compose stop` on a provider service short-circuited straight into runPlugin(..., "stop"), never touching stopContainers -- so the relay container this PR gives a provider service (RestartPolicyUnlessStopped, a real persistent container) was left running and still Up in `compose ps`, contradicting docs/extension.md's claim that stop treats the relay like the service. downService already stops/removes a provider's containers before invoking the plugin; stop.go gets the same treatment: the service's containers are stopped unconditionally, then the plugin's own stop hook (if any) runs for provider services. start/restart needed no change -- neither special-cases providers, so they already operate on whatever containers match the service filter, relay included. Verified locally: reverting just this change makes the new e2e steps below fail on "stop halts the relay container". Extends TestProviderPublishEndpoint with stop/start/restart coverage of the relay container. (glours review on #14193) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| testdata | ||
| assert.go | ||
| bridge_convert_output_test.go | ||
| bridge_test.go | ||
| build_test.go | ||
| cancel_test.go | ||
| cascade_test.go | ||
| checks.go | ||
| commit_test.go | ||
| compose_environment_test.go | ||
| compose_exec_test.go | ||
| compose_run_build_once_test.go | ||
| compose_run_test.go | ||
| compose_test.go | ||
| compose_up_test.go | ||
| config_test.go | ||
| configs_test.go | ||
| container_name_test.go | ||
| cp_test.go | ||
| e2e_config_plugin.go | ||
| e2e_config_standalone.go | ||
| env_file_test.go | ||
| events_test.go | ||
| exec_test.go | ||
| export_test.go | ||
| expose_test.go | ||
| framework.go | ||
| healthcheck_test.go | ||
| hooks_test.go | ||
| image_identity_corner_test.go | ||
| image_identity_test.go | ||
| images_test.go | ||
| ipc_test.go | ||
| logs_test.go | ||
| main_test.go | ||
| model_test.go | ||
| multiplatform_test.go | ||
| networks_test.go | ||
| noDeps_test.go | ||
| orphans_test.go | ||
| pause_test.go | ||
| profiles_test.go | ||
| providers_test.go | ||
| ps_test.go | ||
| publish_test.go | ||
| pull_test.go | ||
| recreate_no_deps_test.go | ||
| remote_git_test.go | ||
| remote_oci_test.go | ||
| restart_test.go | ||
| scale_test.go | ||
| scenario.go | ||
| SCENARIO.md | ||
| secrets_test.go | ||
| start_stop_test.go | ||
| testdata_test.go | ||
| unsupported_attributes_test.go | ||
| up_test.go | ||
| volumes_test.go | ||
| wait_test.go | ||
| watch_test.go | ||