mirror of
https://github.com/docker/compose.git
synced 2026-07-10 10:14:13 +00:00
d9065050fd
The big mechanical change here is to NOT store `t` as a field on the `CLI` object (which has been renamed as well to fix the odd capitalization). The way the tests are structured meant that the "subtests" were using the _parent_ `*testing.T` instance, which causes various oddities including confusing messages on failure about a child test causing a panic in the parent. Additionally, a few tests have been blocked from running in parallel because they are sharing `compose.yaml` fixtures and can fail as a result (e.g. due to a port conflict on the host). I'll fix these in follow-up PRs but want to focus on correctness for the tests before optimizing them. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
78 lines
2.4 KiB
Go
78 lines
2.4 KiB
Go
//go:build !windows
|
|
// +build !windows
|
|
|
|
/*
|
|
Copyright 2020 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"os/exec"
|
|
"strings"
|
|
"syscall"
|
|
"testing"
|
|
"time"
|
|
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/icmd"
|
|
)
|
|
|
|
func TestComposeCancel(t *testing.T) {
|
|
c := NewParallelCLI(t)
|
|
|
|
t.Run("metrics on cancel Compose build", func(t *testing.T) {
|
|
c.RunDockerComposeCmd(t, "ls")
|
|
buildProjectPath := "fixtures/build-infinite/compose.yaml"
|
|
|
|
// require a separate groupID from the process running tests, in order to simulate ctrl+C from a terminal.
|
|
// sending kill signal
|
|
cmd, stdout, stderr, err := StartWithNewGroupID(c.NewDockerCmd("compose", "-f", buildProjectPath, "build", "--progress", "plain"))
|
|
assert.NilError(t, err)
|
|
|
|
c.WaitForCondition(t, func() (bool, string) {
|
|
out := stdout.String()
|
|
errors := stderr.String()
|
|
return strings.Contains(out,
|
|
"RUN sleep infinity"), fmt.Sprintf("'RUN sleep infinity' not found in : \n%s\nStderr: \n%s\n", out,
|
|
errors)
|
|
}, 30*time.Second, 1*time.Second)
|
|
|
|
err = syscall.Kill(-cmd.Process.Pid, syscall.SIGINT) // simulate Ctrl-C : send signal to processGroup, children will have same groupId by default
|
|
|
|
assert.NilError(t, err)
|
|
c.WaitForCondition(t, func() (bool, string) {
|
|
out := stdout.String()
|
|
errors := stderr.String()
|
|
return strings.Contains(out, "CANCELED"), fmt.Sprintf("'CANCELED' not found in : \n%s\nStderr: \n%s\n", out,
|
|
errors)
|
|
}, 10*time.Second, 1*time.Second)
|
|
})
|
|
}
|
|
|
|
func StartWithNewGroupID(command icmd.Cmd) (*exec.Cmd, *bytes.Buffer, *bytes.Buffer, error) {
|
|
cmd := exec.Command(command.Command[0], command.Command[1:]...)
|
|
cmd.Env = command.Env
|
|
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
|
|
|
|
var stdout bytes.Buffer
|
|
var stderr bytes.Buffer
|
|
cmd.Stdout = &stdout
|
|
cmd.Stderr = &stderr
|
|
err := cmd.Start()
|
|
return cmd, &stdout, &stderr, err
|
|
}
|