mirror of
https://github.com/docker/compose.git
synced 2026-11-18 14:13:49 +00:00
Copilot review finding on #14296: planProviderRelayRestart's node was added as a sibling of the provider's own startPhaseDependencies, not their dependent. Under pure ScopeStart there is no Create->Start barrier separating a provider from its siblings the way ScopeCreateStart's OpRunProvider gets one for free (always a create-phase node, run to completion before any start-phase node begins) -- so a stopped relay with a required depends_on condition could start immediately, concurrently with (or before) that condition's own wait resolving. planProviderRelayRestart now takes the provider's own depNodes (startPhaseDependencies' result, already computed by the caller) and passes them through as the restart node's own DependsOn, exactly like an ordinary service's bare-restart-under-ScopeStart already does via its replica chain's `prev := depNodes`. New regression test TestPlanStart_ProviderRelayRestartWaitsOnDependencies, verified by ablation (dropping the deps argument reproduces the missing edge deterministically, 3/3 runs). Verified: go build, go test ./pkg/compose/..., and golangci-lint all clean; full e2e suite re-run clean against a locally built binary (same 3 pre-existing, environment-specific failures as the stack's baseline: TestWatch, TestIPC, TestComposeModel). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||