compose/pkg
Nicolas De Loof 6efb45c866 fix(reconcile): gate the provider relay restart on its own depends_on
Copilot review finding on #14296: planProviderRelayRestart's node was
added as a sibling of the provider's own startPhaseDependencies, not
their dependent. Under pure ScopeStart there is no Create->Start
barrier separating a provider from its siblings the way ScopeCreateStart's
OpRunProvider gets one for free (always a create-phase node, run to
completion before any start-phase node begins) -- so a stopped relay
with a required depends_on condition could start immediately,
concurrently with (or before) that condition's own wait resolving.

planProviderRelayRestart now takes the provider's own depNodes
(startPhaseDependencies' result, already computed by the caller) and
passes them through as the restart node's own DependsOn, exactly like
an ordinary service's bare-restart-under-ScopeStart already does via
its replica chain's `prev := depNodes`.

New regression test TestPlanStart_ProviderRelayRestartWaitsOnDependencies,
verified by ablation (dropping the deps argument reproduces the
missing edge deterministically, 3/3 runs).

Verified: go build, go test ./pkg/compose/..., and golangci-lint all
clean; full e2e suite re-run clean against a locally built binary
(same 3 pre-existing, environment-specific failures as the stack's
baseline: TestWatch, TestIPC, TestComposeModel).

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-10-16 10:52:52 +02:00
..
api feat(push): add --ignore-missing to skip images not available locally 2026-10-14 21:34:38 +02:00
bridge build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
compose fix(reconcile): gate the provider relay restart on its own depends_on 2026-10-16 10:52:52 +02:00
dryrun feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
e2e test(e2e): follow the rebuild failure message in the dotenv rebuild test 2026-10-15 17:04:18 +02:00
mocks refactor(api): regenerate mocks for the split Compose interfaces 2026-10-12 12:03:29 +02:00
remote docs(registry): trim comments 2026-10-07 14:24:28 +02:00
utils fix: make e2e tests pass reliably locally with Docker Desktop 2026-05-18 10:55:41 +02:00
watch golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00