mirror of
https://github.com/docker/compose.git
synced 2026-06-28 12:13:24 +00:00
19fc292eb9
The previous implementation fetched the provider binary path and metadata twice per service during `compose stop`: once in stop.go to gate on the `stop` capability, and again inside runPlugin via setupPluginCommand. setupPluginCommand now signals "skip" by returning (nil, nil) when the requested command is absent from the provider's metadata. stop.go calls runPlugin directly; the skip-when-unadvertised check moves into runPlugin. Addresses PR #13779 review feedback. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
61 lines
1.8 KiB
Go
61 lines
1.8 KiB
Go
/*
|
|
Copyright 2020 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package compose
|
|
|
|
import (
|
|
"context"
|
|
"slices"
|
|
"strings"
|
|
|
|
"github.com/docker/compose/v5/pkg/api"
|
|
)
|
|
|
|
func (s *composeService) Stop(ctx context.Context, projectName string, options api.StopOptions) error {
|
|
return Run(ctx, func(ctx context.Context) error {
|
|
return s.stop(ctx, strings.ToLower(projectName), options, nil)
|
|
}, "stop", s.events)
|
|
}
|
|
|
|
func (s *composeService) stop(ctx context.Context, projectName string, options api.StopOptions, event api.ContainerEventListener) error {
|
|
containers, err := s.getContainers(ctx, projectName, oneOffExclude, true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
project := options.Project
|
|
if project == nil {
|
|
project, err = s.getProjectWithResources(ctx, containers, projectName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if len(options.Services) == 0 {
|
|
options.Services = project.ServiceNames()
|
|
}
|
|
|
|
return InReverseDependencyOrder(ctx, project, func(c context.Context, service string) error {
|
|
if !slices.Contains(options.Services, service) {
|
|
return nil
|
|
}
|
|
serv := project.Services[service]
|
|
if serv.Provider != nil {
|
|
return s.runPlugin(ctx, project, serv, "stop")
|
|
}
|
|
return s.stopContainers(ctx, &serv, containers.filter(isService(service)).filter(isNotOneOff), options.Timeout, event)
|
|
})
|
|
}
|