mirror of
https://github.com/docker/compose.git
synced 2026-11-17 21:57:19 +00:00
|
Some checks are pending
ci / validate (lint) (push) Waiting to run
ci / validate (relay-lint) (push) Waiting to run
ci / validate (relay-test) (push) Waiting to run
ci / validate (validate-docs) (push) Waiting to run
ci / validate (validate-go-mod) (push) Waiting to run
ci / validate (validate-headers) (push) Waiting to run
ci / validate (validate-mocks) (push) Waiting to run
ci / binary (push) Waiting to run
ci / binary-finalize (push) Blocked by required conditions
ci / bin-image-test (push) Waiting to run
ci / relay-image-test (push) Waiting to run
ci / test (push) Waiting to run
ci / e2e (plugin, oldstable, graphdriver) (push) Waiting to run
ci / e2e (standalone, oldstable, graphdriver) (push) Waiting to run
ci / e2e (plugin, stable, containerd) (push) Waiting to run
ci / e2e (plugin, stable, graphdriver) (push) Waiting to run
ci / e2e (standalone, stable, containerd) (push) Waiting to run
ci / e2e (standalone, stable, graphdriver) (push) Waiting to run
ci / coverage (push) Blocked by required conditions
ci / release (push) Blocked by required conditions
merge / bin-image-prepare (push) Waiting to run
merge / bin-image (push) Blocked by required conditions
merge / relay-image (push) Waiting to run
merge / module-image (push) Waiting to run
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
zizmor / zizmor (push) Waiting to run
Two independent reviews (Copilot CLI + a fresh-context agent) of the previous commit converged on the same finding: execStartContainer's, execRunPreStart's, and execRunPostStart's ctx.Err() guards still claimed the TOCTOU window "cannot be closed" and deferred the real fix to #14081 -- stale now that run()'s failedDependency check closes it for a direct dependency before executeNode is ever reached. Reworded to say what's actually still open: defense in depth for ctx canceled by something other than a direct dependency (an unrelated branch of the same plan, or an external cancellation). Also: recordFailure stored the already-wrapped "dependency failed: %w" error, compounding the prefix at every hop of a multi-node chain. Store the original error instead, wrapping only the value returned from this node's own goroutine. And a stale reference to a test name that was never the one actually added (TestExecutePlanFailedPreStartGatesStart, not ...GroupDoesNotRestart). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||