compose/pkg
Nicolas De Loof 4e2526a7af fix(reconcile): include every exceptional-state restart node, not just the last
Copilot review, following up on 374079a32's own fix: serviceNodes keeps
only the LAST node processed during a service's create-phase
convergence -- correct for a single replica, but a scaled service can
have more than one exceptional-state (paused, dead) replica, each with
its own bare-restart OpStartContainer node. Using serviceNodes alone
in planServiceStart's len(replicas) == 0 branch meant a downstream
service_started consumer only ended up depending on the highest-
numbered replica's restart, not every one of them.

exceptionalStateRestartNodes collects every OpStartContainer node from
containerNodes[service] (which tracks all of them, unlike serviceNodes),
in deterministic replica-number order. planServiceStart now merges all
of them into startChainEnds alongside the dependency prerequisites.

TestPlanStart_ScaledExceptionalStateConsumerWaitsForEveryRestart pins
it: two exceptional-state replicas, asserting the consumer depends on
both restart nodes -- verified by ablation to depend on only the last
one without the fix.

Two more small, independent fixes from the same review round:
- execWaitCondition's doc comment (executor_ops.go) described the
  pre-waitTimeout "no deadline, caller wraps ctx" design; updated to
  describe planExecutor.waitTimeout's actual per-node window.
- waitDependency's new optional-dependency-timeout tolerance (the
  previous commit) gains its own direct regression test
  (TestWaitDependencyDeadline/expired deadline on an optional
  dependency is skipped, not an error) -- the existing tests covered a
  required timeout, user cancellation, and an optional dependency's
  definitive (non-timeout) failure, but not this specific path.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-10-15 14:52:20 +02:00
..
api feat(push): add --ignore-missing to skip images not available locally 2026-10-14 21:34:38 +02:00
bridge build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
compose fix(reconcile): include every exceptional-state restart node, not just the last 2026-10-15 14:52:20 +02:00
dryrun feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
e2e feat(run): --no-recreate reuses existing dependencies as-is 2026-10-14 09:34:19 +02:00
mocks refactor(api): regenerate mocks for the split Compose interfaces 2026-10-12 12:03:29 +02:00
remote docs(registry): trim comments 2026-10-07 14:24:28 +02:00
utils fix: make e2e tests pass reliably locally with Docker Desktop 2026-05-18 10:55:41 +02:00
watch golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00