mirror of
https://github.com/docker/compose.git
synced 2026-11-19 22:50:08 +00:00
errgroup.SetLimit(0) means "allow zero goroutines", not "unlimited",
and maxConcurrency's Go zero-value is 0 — only NewComposeService sets
it to -1 explicitly. Any composeService{} literal built without it
(common in tests) silently deadlocked at every call site that called
SetLimit unconditionally.
Separately, --parallel/COMPOSE_PARALLEL_LIMIT was only ever wired
into pull, push, and the dependency-graph traversal, despite the docs
promising a generic bound on "concurrent engine calls". Every other
bulk operation (kill, pause, down, the up/create plan executor, logs,
ps, top, wait, restart, remove, images, model pulls, watch) launched
one goroutine per container/image/DAG-node with no cap at all.
Fix both via a shared newLimitedErrgroup helper applied at every
fan-out site, threading maxConcurrency through forEachContainerConcurrent
and ImagePruner, which had no access to composeService. Add a
regression test for the zero-value case.
service_containers.go's waitDependencies is intentionally left
unguarded: it's a per-dependency ticker poll, not a burst of engine
calls.
Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
116 lines
3.1 KiB
Go
116 lines
3.1 KiB
Go
/*
|
|
Copyright 2020 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package compose
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/moby/moby/client"
|
|
|
|
"github.com/docker/compose/v5/pkg/api"
|
|
)
|
|
|
|
func (s *composeService) Remove(ctx context.Context, projectName string, options api.RemoveOptions) error {
|
|
projectName = strings.ToLower(projectName)
|
|
|
|
if options.Stop {
|
|
// Stop's own "stop" Start/Done cycle runs sequentially, fully
|
|
// closed, before "remove"'s below — ttyWriter supports that.
|
|
err := s.Stop(ctx, projectName, api.StopOptions{
|
|
Services: options.Services,
|
|
Project: options.Project,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
containers, err := s.getContainers(ctx, projectName, oneOffExclude, true, options.Services...)
|
|
if err != nil {
|
|
if api.IsNotFoundError(err) {
|
|
_, _ = fmt.Fprintln(s.stderr(), "No stopped containers")
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
if options.Project != nil {
|
|
containers = containers.filter(isService(options.Project.ServiceNames()...))
|
|
}
|
|
|
|
var stoppedContainers Containers
|
|
for _, ctr := range containers {
|
|
// We have to inspect containers, as State reported by getContainers suffers a race condition
|
|
inspected, err := s.apiClient().ContainerInspect(ctx, ctr.ID, client.ContainerInspectOptions{})
|
|
if api.IsNotFoundError(err) {
|
|
// Already removed. Maybe configured with auto-remove
|
|
continue
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !inspected.Container.State.Running || (options.Stop && s.dryRun) {
|
|
stoppedContainers = append(stoppedContainers, ctr)
|
|
}
|
|
}
|
|
|
|
var names []string
|
|
for _, ctr := range stoppedContainers {
|
|
names = append(names, getCanonicalContainerName(ctr))
|
|
}
|
|
|
|
if len(names) == 0 {
|
|
return api.ErrNoResources
|
|
}
|
|
|
|
msg := "Going to remove " + strings.Join(names, ", ")
|
|
if options.Force {
|
|
_, _ = fmt.Fprintln(s.stdout(), msg)
|
|
} else {
|
|
confirm, err := s.prompt(msg, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !confirm {
|
|
return nil
|
|
}
|
|
}
|
|
return Run(ctx, func(ctx context.Context) error {
|
|
return s.remove(ctx, stoppedContainers, options)
|
|
}, "remove", s.events)
|
|
}
|
|
|
|
func (s *composeService) remove(ctx context.Context, containers Containers, options api.RemoveOptions) error {
|
|
eg, ctx := newLimitedErrgroup(ctx, s.maxConcurrency)
|
|
for _, ctr := range containers {
|
|
eg.Go(func() error {
|
|
eventName := getContainerProgressName(ctr)
|
|
s.events.On(removingEvent(eventName))
|
|
_, err := s.apiClient().ContainerRemove(ctx, ctr.ID, client.ContainerRemoveOptions{
|
|
RemoveVolumes: options.Volumes,
|
|
Force: options.Force,
|
|
})
|
|
if err == nil {
|
|
s.events.On(removedEvent(eventName))
|
|
}
|
|
return err
|
|
})
|
|
}
|
|
return eg.Wait()
|
|
}
|