mirror of
https://github.com/docker/compose.git
synced 2026-11-18 14:13:49 +00:00
Copilot review finding on #14296: start() copied upDetached's emitRunningEvents call without checking whether it fit start()'s own, narrower UX contract. It doesn't -- the imperative engine's startService emitted nothing at all for an already-running container (locked by the now-deleted TestStartService_AlreadyRunningIsSilent), matching compose start's long-standing silence-on-no-op behavior (e2e's TestStartAlreadyRunning asserts empty stdout for exactly this case). emitRunningEvents exists for up/create's full project-status display, which accounts for containers the plan won't touch -- a concern start() has never had. Verified: go build, go test ./pkg/compose/..., and golangci-lint all clean; full e2e suite re-run clean against a locally built binary (same 3 pre-existing, environment-specific failures as the stack's baseline: TestWatch, TestIPC, TestComposeModel), including the existing TestStartAlreadyRunning and the full start/stop e2e suite. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||