compose/pkg
Nicolas De Loof 33f7153d14 fix(start): don't emit synthetic Running events for a no-op start
Copilot review finding on #14296: start() copied upDetached's
emitRunningEvents call without checking whether it fit start()'s own,
narrower UX contract. It doesn't -- the imperative engine's
startService emitted nothing at all for an already-running container
(locked by the now-deleted TestStartService_AlreadyRunningIsSilent),
matching compose start's long-standing silence-on-no-op behavior
(e2e's TestStartAlreadyRunning asserts empty stdout for exactly this
case). emitRunningEvents exists for up/create's full project-status
display, which accounts for containers the plan won't touch -- a
concern start() has never had.

Verified: go build, go test ./pkg/compose/..., and golangci-lint all
clean; full e2e suite re-run clean against a locally built binary
(same 3 pre-existing, environment-specific failures as the stack's
baseline: TestWatch, TestIPC, TestComposeModel), including the
existing TestStartAlreadyRunning and the full start/stop e2e suite.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-10-16 10:52:52 +02:00
..
api feat(push): add --ignore-missing to skip images not available locally 2026-10-14 21:34:38 +02:00
bridge build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
compose fix(start): don't emit synthetic Running events for a no-op start 2026-10-16 10:52:52 +02:00
dryrun feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
e2e test(e2e): follow the rebuild failure message in the dotenv rebuild test 2026-10-15 17:04:18 +02:00
mocks refactor(api): regenerate mocks for the split Compose interfaces 2026-10-12 12:03:29 +02:00
remote docs(registry): trim comments 2026-10-07 14:24:28 +02:00
utils fix: make e2e tests pass reliably locally with Docker Desktop 2026-05-18 10:55:41 +02:00
watch golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00