mirror of
https://github.com/docker/compose.git
synced 2026-07-10 10:14:13 +00:00
When Compose is watching a project/reattaching streams on container start, it will make new API `ContainerAttach()` calls every time a container it's watching is started. However, it only closes the stream when the context used to start the attach is canceled. This means that if a user has a project with multiple containers where containers keep restarting, Compose will attach to the new containers but never close the previous streams, causing fds to pile up and goroutines on the engine to get stuck. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
182 lines
4.8 KiB
Go
182 lines
4.8 KiB
Go
/*
|
|
Copyright 2020 Docker Compose CLI authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package compose
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"github.com/compose-spec/compose-go/v2/types"
|
|
"github.com/docker/cli/cli/streams"
|
|
moby "github.com/docker/docker/api/types"
|
|
containerType "github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/pkg/stdcopy"
|
|
"github.com/moby/term"
|
|
|
|
"github.com/docker/compose/v2/pkg/api"
|
|
"github.com/docker/compose/v2/pkg/utils"
|
|
)
|
|
|
|
func (s *composeService) attach(ctx context.Context, project *types.Project, listener api.ContainerEventListener, selectedServices []string) (Containers, error) {
|
|
containers, err := s.getContainers(ctx, project.Name, oneOffExclude, true, selectedServices...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(containers) == 0 {
|
|
return containers, nil
|
|
}
|
|
|
|
containers.sorted() // This enforce predictable colors assignment
|
|
|
|
var names []string
|
|
for _, c := range containers {
|
|
names = append(names, getContainerNameWithoutProject(c))
|
|
}
|
|
|
|
fmt.Fprintf(s.stdout(), "Attaching to %s\n", strings.Join(names, ", "))
|
|
|
|
for _, container := range containers {
|
|
err := s.attachContainer(ctx, container, listener)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
return containers, err
|
|
}
|
|
|
|
func (s *composeService) attachContainer(ctx context.Context, container moby.Container, listener api.ContainerEventListener) error {
|
|
serviceName := container.Labels[api.ServiceLabel]
|
|
containerName := getContainerNameWithoutProject(container)
|
|
|
|
listener(api.ContainerEvent{
|
|
Type: api.ContainerEventAttach,
|
|
Container: containerName,
|
|
ID: container.ID,
|
|
Service: serviceName,
|
|
})
|
|
|
|
wOut := utils.GetWriter(func(line string) {
|
|
listener(api.ContainerEvent{
|
|
Type: api.ContainerEventLog,
|
|
Container: containerName,
|
|
ID: container.ID,
|
|
Service: serviceName,
|
|
Line: line,
|
|
})
|
|
})
|
|
wErr := utils.GetWriter(func(line string) {
|
|
listener(api.ContainerEvent{
|
|
Type: api.ContainerEventErr,
|
|
Container: containerName,
|
|
ID: container.ID,
|
|
Service: serviceName,
|
|
Line: line,
|
|
})
|
|
})
|
|
|
|
inspect, err := s.apiClient().ContainerInspect(ctx, container.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, _, err = s.attachContainerStreams(ctx, container.ID, inspect.Config.Tty, nil, wOut, wErr)
|
|
return err
|
|
}
|
|
|
|
func (s *composeService) attachContainerStreams(ctx context.Context, container string, tty bool, stdin io.ReadCloser, stdout, stderr io.WriteCloser) (func(), chan bool, error) {
|
|
detached := make(chan bool)
|
|
restore := func() { /* noop */ }
|
|
if stdin != nil {
|
|
in := streams.NewIn(stdin)
|
|
if in.IsTerminal() {
|
|
state, err := term.SetRawTerminal(in.FD())
|
|
if err != nil {
|
|
return restore, detached, err
|
|
}
|
|
restore = func() {
|
|
term.RestoreTerminal(in.FD(), state) //nolint:errcheck
|
|
}
|
|
}
|
|
}
|
|
|
|
streamIn, streamOut, err := s.getContainerStreams(ctx, container)
|
|
if err != nil {
|
|
return restore, detached, err
|
|
}
|
|
|
|
go func() {
|
|
<-ctx.Done()
|
|
if stdin != nil {
|
|
stdin.Close() //nolint:errcheck
|
|
}
|
|
}()
|
|
|
|
if streamIn != nil && stdin != nil {
|
|
go func() {
|
|
_, err := io.Copy(streamIn, stdin)
|
|
var escapeErr term.EscapeError
|
|
if errors.As(err, &escapeErr) {
|
|
close(detached)
|
|
}
|
|
}()
|
|
}
|
|
|
|
if stdout != nil {
|
|
go func() {
|
|
defer stdout.Close() //nolint:errcheck
|
|
defer stderr.Close() //nolint:errcheck
|
|
defer streamOut.Close() //nolint:errcheck
|
|
if tty {
|
|
io.Copy(stdout, streamOut) //nolint:errcheck
|
|
} else {
|
|
stdcopy.StdCopy(stdout, stderr, streamOut) //nolint:errcheck
|
|
}
|
|
}()
|
|
}
|
|
return restore, detached, nil
|
|
}
|
|
|
|
func (s *composeService) getContainerStreams(ctx context.Context, container string) (io.WriteCloser, io.ReadCloser, error) {
|
|
var stdout io.ReadCloser
|
|
var stdin io.WriteCloser
|
|
cnx, err := s.apiClient().ContainerAttach(ctx, container, containerType.AttachOptions{
|
|
Stream: true,
|
|
Stdin: true,
|
|
Stdout: true,
|
|
Stderr: true,
|
|
Logs: false,
|
|
})
|
|
if err == nil {
|
|
stdout = ContainerStdout{HijackedResponse: cnx}
|
|
stdin = ContainerStdin{HijackedResponse: cnx}
|
|
return stdin, stdout, nil
|
|
}
|
|
|
|
// Fallback to logs API
|
|
logs, err := s.apiClient().ContainerLogs(ctx, container, containerType.LogsOptions{
|
|
ShowStdout: true,
|
|
ShowStderr: true,
|
|
Follow: true,
|
|
})
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
return stdin, logs, nil
|
|
}
|