compose/pkg/compose
Guillaume Lours 2c38ead3eb fix(provider): do not execute provider services in dry-run mode
Dry-run only wraps the Docker API client, so provider services, which
are external processes, were still executed: up and create ran the
provider's up command, down and stop ran theirs.

Skip the process in executePlugin when dry-run is set while still
emitting the progress events, and return early from runPlugin so no
relay is deployed or removed for a provider that never ran. The
metadata command is still invoked to keep validating the binary and
its required parameters.

Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
2026-10-13 13:44:27 +02:00
..
testdata
transform chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
api_versions.go
apiSocket.go
attach.go chore: explicit, unique, greppable names for internal identifiers 2026-08-20 11:17:11 +02:00
attach_service.go
build.go feat(provider): providers take part in the image phase of up and pull 2026-10-02 17:35:20 +02:00
build_bake.go fix(bake): grant access to ssh, local caches and OCI contexts 2026-10-12 16:54:47 +02:00
build_bake_test.go fix(bake): grant access to ssh, local caches and OCI contexts 2026-10-12 16:54:47 +02:00
build_classic.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
build_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
commit.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
compose.go refactor(up): inject the navigation menu instead of importing cmd/formatter 2026-10-12 10:50:38 +02:00
compose_test.go refactor(compose): hold per-service state on composeService instead of package globals 2026-10-12 10:21:55 +02:00
container.go
containers.go fix: share --parallel budget across down's ops and up's log-attach 2026-10-01 16:02:14 +02:00
containers_test.go chore(compose): orphan semantics stated where up and down diverge 2026-08-31 17:09:19 +02:00
convert.go
cp.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
cp_test.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
create.go refactor: split create() into preparePlan + executePlan 2026-10-12 17:23:16 +02:00
create_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
dependencies.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
dependencies_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
desktop.go
docker_cli_providers.go
down.go api: DownOptions.Images becomes a typed ImagePruneMode, validated upfront 2026-10-06 11:31:22 +02:00
down_test.go api: DownOptions.Images becomes a typed ImagePruneMode, validated upfront 2026-10-06 11:31:22 +02:00
envresolver.go
envresolver_test.go
exec.go feat(provider): publish-endpoint deploys a network relay for provider services 2026-09-16 17:03:23 +02:00
executor.go fix(executor): keep dependency-failure comments and wrapping accurate 2026-10-06 14:11:22 +02:00
executor_events.go fix(executor): a failed pre_start no longer lets start fire its own event 2026-10-06 14:11:22 +02:00
executor_ops.go fix(executor): keep dependency-failure comments and wrapping accurate 2026-10-06 14:11:22 +02:00
executor_start_test.go fix(executor): a failed pre_start no longer lets start fire its own event 2026-10-06 14:11:22 +02:00
executor_test.go feat: executor runs start-phase operations 2026-10-06 14:11:22 +02:00
export.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
filters.go feat(hooks): clean up retained pre_start containers on compose down 2026-08-20 18:57:02 +02:00
hash.go fix(hash): repair the tests after #14093 and #14215 merged in reverse order 2026-09-22 11:03:06 +02:00
hash_test.go fix(hash): repair the tests after #14093 and #14215 merged in reverse order 2026-09-22 11:03:06 +02:00
hook.go feat(hooks): clean up retained pre_start containers on compose down 2026-08-20 18:57:02 +02:00
hook_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
image_pruner.go fix(down): reuse Mode.Valid() instead of re-deriving legal values 2026-10-06 11:31:22 +02:00
image_pruner_test.go test(down): cover ImagesToPrune's own invalid-mode rejection 2026-10-06 11:31:22 +02:00
images.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
images_test.go feat(provider): providers take part in the image phase of up and pull 2026-10-02 17:35:20 +02:00
inspect.go refactor(inspect): move the read-only operations to internal/inspect 2026-10-13 10:03:53 +02:00
kill.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
kill_test.go
logs.go fix(logs): relay each line of a restarted container exactly once 2026-10-09 16:41:51 +02:00
logs_cursor_test.go fix(logs): relay each line of a restarted container exactly once 2026-10-09 16:41:51 +02:00
logs_test.go fix(logs): relay each line of a restarted container exactly once 2026-10-09 16:41:51 +02:00
model.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
monitor.go feat(provider): publish-endpoint deploys a network relay for provider services 2026-09-16 17:03:23 +02:00
monitor_test.go fix: detect externally stopped and removed containers in up monitor 2026-09-16 07:54:38 +02:00
navigation_menu.go refactor(up): let the navigation menu own the keyboard 2026-10-12 10:50:38 +02:00
observed_state.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
observed_state_test.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
pause.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
plan.go feat: reconciliation plan creates pre_start hook runners 2026-09-30 12:03:10 +02:00
plan_test.go
plugins.go fix(provider): do not execute provider services in dry-run mode 2026-10-13 13:44:27 +02:00
plugins_control_test.go fix(provider): do not execute provider services in dry-run mode 2026-10-13 13:44:27 +02:00
plugins_test.go feat(provider): pull command and get-image protocol for image distribution 2026-10-02 17:35:20 +02:00
port_test.go refactor(inspect): move the read-only operations to internal/inspect 2026-10-13 10:03:53 +02:00
pre_start.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
pre_start_test.go feat: reconciliation plan creates pre_start hook runners 2026-09-30 12:03:10 +02:00
printer.go
progress.go
projectloader.go refactor(projectloader): move project loading and generation to internal/projectloader 2026-10-13 10:03:53 +02:00
provider_images.go fix(provider): address review findings on image distribution 2026-10-02 17:35:20 +02:00
provider_images_test.go fix(provider): close stdin when an announce write itself fails 2026-10-02 17:35:20 +02:00
ps_test.go
publish.go feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
publish_test.go publish, config --images: jobs are scanned and pinned like services 2026-09-21 16:35:20 +02:00
pull.go docs(registry): trim comments 2026-10-07 14:24:28 +02:00
pull_test.go feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
push.go feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
rebuild_scheduler.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
rebuild_scheduler_test.go fix(watch): interrupt stale rebuilds so watch converges 2026-09-14 10:47:07 +02:00
reconcile.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
reconcile_start_test.go feat: reconciliation plan creates pre_start hook runners 2026-09-30 12:03:10 +02:00
reconcile_test.go fix: address the second round of copilot/docker-agent findings 2026-09-30 12:03:10 +02:00
relay.go docs(compose): state that a relay-only endpoint also needs an interface-pinned bind 2026-10-02 12:33:26 +02:00
relay_test.go fix(compose): share relay-link network removal and state its isolation precisely 2026-10-02 12:33:26 +02:00
remove.go fix: honor --parallel across all bulk engine-call fan-outs 2026-10-01 16:02:14 +02:00
restart.go fix: share --parallel budget across down's ops and up's log-attach 2026-10-01 16:02:14 +02:00
restart_test.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
run.go fix: keep the image pull of compose run inside the run progress block 2026-10-13 10:02:09 +02:00
run_test.go fix: keep the image pull of compose run inside the run progress block 2026-10-13 10:02:09 +02:00
scale.go api: ScaleOptions carries the replica counts it always pretended to 2026-08-20 10:16:06 +02:00
scale_test.go api: ScaleOptions carries the replica counts it always pretended to 2026-08-20 10:16:06 +02:00
secrets.go chore: inline needless single-use helpers 2026-08-14 22:49:53 +02:00
service_containers.go refactor(compose): hold per-service state on composeService instead of package globals 2026-10-12 10:21:55 +02:00
service_containers_test.go fix(up): don't skip an optional dependency whose inspection failed because the wait ended 2026-10-09 12:50:20 +02:00
shellout.go
start.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
start_test.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
stop.go fix: bound compose cp's fan-out and panic-safe log slot release 2026-10-01 16:02:14 +02:00
stop_test.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
up.go refactor(up): let the navigation menu own the keyboard 2026-10-12 10:50:38 +02:00
up_test.go refactor(up): let the navigation menu own the keyboard 2026-10-12 10:50:38 +02:00
viz_test.go build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
volumes_test.go
wait.go fix: close remaining --parallel gaps on down/stop/start 2026-10-01 16:02:14 +02:00
wait_test.go fix: wait rejects dry-run with a clear error 2026-09-30 14:47:16 +02:00
watch.go fix(watch): skip sync+exec triggers on bind-mounted paths 2026-10-12 17:02:20 +02:00
watch_test.go fix(watch): skip sync+exec triggers on bind-mounted paths 2026-10-12 17:02:20 +02:00