compose/pkg
Nicolas De Loof 0f668c38f3 fix(up): don't blame --wait-timeout for an external ctx deadline
docker-agent review (moderate confidence): exec.run propagates any
context.DeadlineExceeded up, including one originating from ctx itself
(an outer caller's own deadline -- a test harness, a wrapper tool, a
client-side timeout) rather than from an OpWaitCondition node's own
derived timeout. The WaitTimeout > 0 guard alone doesn't distinguish
the two: a user who did configure --wait-timeout could still see
"application not healthy after Xs" when what actually happened was
the caller's own unrelated deadline firing during plan execution.

ctx at this point is still the caller-supplied, undecorated context
(the per-wait timeout is derived fresh inside executeNode, never
reassigned here) -- so ctx.Err() == nil confirms the DeadlineExceeded
didn't come from ctx's own deadline, leaving only an OpWaitCondition
node's derived timeout as the source.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-10-15 14:52:20 +02:00
..
api feat(push): add --ignore-missing to skip images not available locally 2026-10-14 21:34:38 +02:00
bridge build(deps): adopt compose-go jobs and the container-spec layering 2026-09-21 16:35:20 +02:00
compose fix(up): don't blame --wait-timeout for an external ctx deadline 2026-10-15 14:52:20 +02:00
dryrun feat(registry): use the Docker Desktop Hub session for Docker Hub credentials 2026-10-07 14:24:28 +02:00
e2e feat(run): --no-recreate reuses existing dependencies as-is 2026-10-14 09:34:19 +02:00
mocks refactor(api): regenerate mocks for the split Compose interfaces 2026-10-12 12:03:29 +02:00
remote docs(registry): trim comments 2026-10-07 14:24:28 +02:00
utils fix: make e2e tests pass reliably locally with Docker Desktop 2026-05-18 10:55:41 +02:00
watch golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00