mirror of
https://github.com/docker/compose.git
synced 2026-11-18 14:13:49 +00:00
docker-agent review (moderate confidence): exec.run propagates any context.DeadlineExceeded up, including one originating from ctx itself (an outer caller's own deadline -- a test harness, a wrapper tool, a client-side timeout) rather than from an OpWaitCondition node's own derived timeout. The WaitTimeout > 0 guard alone doesn't distinguish the two: a user who did configure --wait-timeout could still see "application not healthy after Xs" when what actually happened was the caller's own unrelated deadline firing during plan execution. ctx at this point is still the caller-supplied, undecorated context (the per-wait timeout is derived fresh inside executeNode, never reassigned here) -- so ctx.Err() == nil confirms the DeadlineExceeded didn't come from ctx's own deadline, leaving only an OpWaitCondition node's derived timeout as the source. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||