compose/pkg/e2e
Nicolas De Loof 0a64ff09a8 fix: address copilot-pull-request-reviewer's 3 findings on the hook-runner plan
A GitHub Copilot PR review (docker/compose#14221#pullrequestreview-5300897216)
found three real issues in the reconciliation-plan-based hook runners, all
confirmed by direct reproduction against a live daemon before being fixed:

- **Hook runners excluded from discovery, stale runners persist.**
  collectObservedState's single getContainers call requires ConfigHashLabel
  (getDefaultFilters), which hook runners deliberately never carry -- so they
  never reached the classification loop that populates HookContainers, and
  planPreStartHookRunners never saw a stale runner to purge. Reproduced: a
  failed hook run followed by a second `up` failed with "container name ...
  already in use" instead of recovering. Fixed by listing hook containers
  separately, by project+hook label alone (new getHookContainers), and
  merging them in before classification. Locked in by a new e2e scenario,
  TestPreStartHookRetryAfterFailureSucceeds, that reproduces the exact
  failure-then-retry sequence.

- **Prepared hook runners misclassified as service replicas.** start's
  containers.filter(isService(name), isNotOneOff) has no reason to exclude a
  hook runner: it carries the same project/service labels as a real replica
  and no one-off label either. Added isNotHookContainer to the filter chain
  in startService, so a hook runner is never counted as (or started as) a
  surviving replica.

- **Per-replica hooks create runners before unsupported configuration is
  rejected.** per_replica is not yet supported (#14259): runPreStart
  validates every hook up front and rejects the whole service before
  executing any of them, but planPreStartHookRunners had no equivalent
  check, so create/up would plan (and leave behind) runners for a service
  whose hooks could never run. Mirrored the same up-front, all-or-nothing
  validation in planPreStartHookRunners.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-09-30 12:03:10 +02:00
..
fixtures test(e2e): bump compose-bridge images to v0.0.7 2026-09-02 18:21:19 +02:00
testdata fix: address copilot-pull-request-reviewer's 3 findings on the hook-runner plan 2026-09-30 12:03:10 +02:00
assert.go test(e2e): deflake the three state/stream race suspects 2026-09-22 14:45:23 +02:00
bridge_convert_output_test.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
bridge_test.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
build_test.go test(e2e): force --build so a stale image cannot skip the tested path 2026-09-21 18:01:16 +02:00
cancel_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
cascade_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
checks.go fix(e2e): drop the wantAbs alias in BindMountSource 2026-09-23 10:56:23 +02:00
commit_test.go fix(dry-run): commit no longer creates a real image; the interception set becomes declarative 2026-09-16 13:44:21 +02:00
compose_environment_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
compose_exec_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
compose_run_build_once_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
compose_run_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
compose_test.go test(e2e): TestAttachRestart failure dumps the daemon's own log view 2026-09-22 14:45:23 +02:00
compose_up_test.go test(e2e): deflake the three state/stream race suspects 2026-09-22 14:45:23 +02:00
config_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
configs_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
container_name_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
cp_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
e2e_config_plugin.go chore(e2e): fix flaky test & standalone behavior (#11382) 2024-01-30 10:49:53 -05:00
e2e_config_standalone.go
env_file_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
events_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
exec_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
export_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
expose_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
framework.go golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
healthcheck_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
hooks_test.go fix: address copilot-pull-request-reviewer's 3 findings on the hook-runner plan 2026-09-30 12:03:10 +02:00
image_identity_corner_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
image_identity_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
images_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
ipc_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
jobs_test.go fix(compose): move the job-target refusal into projectOrName itself 2026-09-21 16:35:20 +02:00
logs_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
main_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
model_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
multiplatform_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
networks_test.go PRIVATE_PORT optional for docker compose port 2026-09-11 11:35:18 +02:00
noDeps_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
orphans_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
pause_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
profiles_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
providers_test.go fix: provider migration condemns the service's stale replicas 2026-09-25 15:58:18 +02:00
ps_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
publish_test.go publish, config --images: jobs are scanned and pinned like services 2026-09-21 16:35:20 +02:00
pull_test.go test(e2e): fix TestPullFailure's daemon-specific error assertion 2026-09-23 16:12:52 +02:00
recreate_no_deps_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
remote_git_test.go e2e: version-proof git fixture init, Branch cuts from main 2026-09-16 16:53:33 +02:00
remote_oci_test.go test(e2e): reproduce --project-directory ignored on an oci:// project 2026-09-23 10:56:23 +02:00
restart_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
scale_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
scenario.go fix: provider migration condemns the service's stale replicas 2026-09-25 15:58:18 +02:00
SCENARIO.md e2e: scenario DSL learns remote compose sources 2026-09-16 16:53:33 +02:00
secrets_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
start_stop_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
testdata_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
unsupported_attributes_test.go feat(compose): warn on unsupported compose-file attributes 2026-09-09 16:32:04 +02:00
up_test.go test(e2e): wait on state, not on an unsynchronized log line 2026-09-16 14:31:15 +02:00
volumes_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
wait_test.go test(e2e): gate the e2e suite behind the build tag the docs already promise 2026-08-27 11:02:07 +02:00
watch_test.go test(watch): budget the watcher's cold start beyond the default poll timeout 2026-09-22 14:45:23 +02:00