mirror of
https://github.com/docker/compose.git
synced 2026-11-17 05:36:08 +00:00
The new TestUpAttachedTerminatesOnExternalStop (#13990) occasionally observed `up` exit 1 instead of 0 after an external stop/down cancels a service's restart backoff. The cause: once the monitor detects termination and cancels globalCtx, a log-streaming goroutine still blocked on logs?follow=1 for the backoff container gets a context.Canceled error, which appendErr collected unfiltered into the final errors.Join. That race could only surface once #13990 made the monitor loop actually return in this scenario -- before that fix, up hung forever and never reached this code path. appendErr now drops an error that is nothing more than fallout from our own shutdown (errors.Is(err, context.Canceled) once u.globalCtx.Err() is set), the same way a SIGINT-triggered teardown's residual goroutine errors are already expected to be harmless. A genuine error is still reported regardless of shutdown state. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> |
||
|---|---|---|
| .. | ||
| api | ||
| bridge | ||
| compose | ||
| dryrun | ||
| e2e | ||
| mocks | ||
| remote | ||
| utils | ||
| watch | ||