compose/pkg
Nicolas De Loof 01a60a5e99 fix(up): drop benign context.Canceled noise from the final report
The new TestUpAttachedTerminatesOnExternalStop (#13990) occasionally
observed `up` exit 1 instead of 0 after an external stop/down cancels
a service's restart backoff. The cause: once the monitor detects
termination and cancels globalCtx, a log-streaming goroutine still
blocked on logs?follow=1 for the backoff container gets a
context.Canceled error, which appendErr collected unfiltered into the
final errors.Join.

That race could only surface once #13990 made the monitor loop
actually return in this scenario -- before that fix, up hung forever
and never reached this code path.

appendErr now drops an error that is nothing more than fallout from
our own shutdown (errors.Is(err, context.Canceled) once
u.globalCtx.Err() is set), the same way a SIGINT-triggered teardown's
residual goroutine errors are already expected to be harmless. A
genuine error is still reported regardless of shutdown state.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2026-09-16 13:54:05 +02:00
..
api fix(port): preserve tie order for dual-stack port publishers 2026-09-14 10:48:03 +02:00
bridge fix(bridge): confirm before wiping non-empty convert output dir 2026-09-03 14:38:41 +02:00
compose fix(up): drop benign context.Canceled noise from the final report 2026-09-16 13:54:05 +02:00
dryrun fix(dry-run): commit no longer creates a real image; the interception set becomes declarative 2026-09-16 13:44:21 +02:00
e2e fix(dry-run): commit no longer creates a real image; the interception set becomes declarative 2026-09-16 13:44:21 +02:00
mocks PRIVATE_PORT optional for docker compose port 2026-09-11 11:35:18 +02:00
remote golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00
utils fix: make e2e tests pass reliably locally with Docker Desktop 2026-05-18 10:55:41 +02:00
watch golangci-lint: enable perfsprint linter 2026-09-10 10:25:34 +02:00