Commit graph

112 commits

Author SHA1 Message Date
Guillaume Tardif
3c83e01e9c
Merge pull request #327 from docker/compose-go
Use compose-go's Project and ProjectOptions
2020-07-02 16:43:34 +02:00
Guillaume Tardif
a9ef20eefd In ACI e2e tests, do not wait for full resource group deletion at the end, let ACI clean things UP (timeframe ~45 sec). This is costing GH Action minutes for nothing, and slows test results. 2020-07-02 16:13:38 +02:00
Nicolas De Loof
622402709a
Use compose-go's Project and ProjectOptions
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-07-02 16:05:45 +02:00
Djordje Lukic
d3f1209bab Add test for the backtracking of lines 2020-07-02 11:11:09 +02:00
Djordje Lukic
e852e8f96a Count the lines from the terminal, not from ACI
Count the number of lines output on the terminal wrt the terminal width
so that we can go up the right amount.
2020-07-02 10:38:03 +02:00
Djordje Lukic
e22b0ba676 Return an error if unable to open the browser
Also use github.com/pkg/browser instead of our own code
2020-07-01 16:47:49 +02:00
Guillaume Tardif
514aa50ebc
Merge pull request #313 from docker/azure_multi_tenants
Allow users to specify tenanted when logging into azure (if several tenants for azure account)
2020-07-01 15:46:00 +02:00
Guillaume Tardif
29f8c81afc Hide sidecar container from compose progress 2020-07-01 15:08:18 +02:00
Guillaume Tardif
bba9e055af Allow users to specify tenanted when logging into azure (if several tenants for azure account) 2020-07-01 12:27:18 +02:00
Guillaume Tardif
664c48ba1e
Merge pull request #306 from docker/fix-credential-check
Fix credential checking on ACR image (for linux)
2020-06-30 22:16:40 +02:00
Guillaume Tardif
94877b18ab
Merge pull request #304 from docker/aci_inspect_memory_cpu
In ACI inspect, display memory limit in bytes, like Moby `docker inspect`.
2020-06-30 22:16:01 +02:00
Djordje Lukic
fdc2bd34d7 Add test for logs --follow on ACI 2020-06-30 17:13:51 +02:00
Djordje Lukic
06596dcd90 Follow logs on ACI.
This is not ideal, the ACI API doesn't give us a stream of logs, so we
need to fake it by moving the cursor up and rewriting the logs to
stdout. This means that, on gRPC side, we will stream the whole logs
each time. This is ok for now but we need to push Azure to give us a
real streaming API for logs
2020-06-30 16:34:32 +02:00
Ulysses Souza
a72ffee4ff Fix credential checking on ACR image (for linux)
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-30 16:11:54 +02:00
Guillaume Tardif
96075236ee In ACI inspect, display memory limit in bytes, like Moby docker inspect.
Displaying in Gb also was rounding memory to zero if set to 0.xGb
2020-06-30 12:10:18 +02:00
Guillaume Tardif
f0ab42e109
Merge pull request #300 from docker/aci_ci
Run ACI e2e tests in the CI with basic support for service principal login
2020-06-30 10:29:13 +02:00
Guillaume Tardif
2268f0c598 Renamed Login method specific to tests, to make things more explicit 2020-06-30 10:11:06 +02:00
Guillaume Tardif
82ff8dcd7d Fix resource limit defaults and make aci e2e tests pass 2020-06-30 10:10:23 +02:00
Guillaume Tardif
eda438aaed Added basic support for service principal login, run ACI e2e tests with it 2020-06-29 20:35:23 +02:00
Djordje Lukic
6a5973597d Send the tail parameter to ACI if present 2020-06-29 15:40:58 +02:00
Ulysses Souza
1deb2b8b09 Integrate limits on inspect
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-29 10:32:28 +02:00
Ulysses Souza
0a57fd7d5c Add cpu and memory limits
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-29 10:28:43 +02:00
Guillaume Tardif
70f9613dab Trying to fix defensively a panic @nebuk89 encountered on ACI, but could not reproduce it. 2020-06-23 17:52:14 +02:00
Guillaume Tardif
7306821804 Allow ACI compose to expose several ports 2020-06-23 16:00:52 +02:00
Guillaume Tardif
aeb6d2c7c6 List pages of resource groups if entire list is not fetch in first page 2020-06-22 15:34:13 +02:00
Guillaume Tardif
309069f545 Use location flag in aci context creation only for group creation (default eastus). Once group has been created/selected, use group location. 2020-06-22 10:09:17 +02:00
Guillaume Tardif
daf7061e30
Merge pull request #244 from docker/aci_dns_sidecar
Aci dns sidecar
2020-06-19 11:49:04 +02:00
Guillaume Tardif
82171eec19 Explicit message telling the user they are not logged in and need docker login azure first 2020-06-19 11:21:55 +02:00
Djordje Lukic
34d76bd561
Merge pull request #243 from docker/chore-license
Add license headers
2020-06-19 01:16:21 -07:00
Guillaume Tardif
e99e3aefc5 Nicer subscription display. Cf https://github.com/docker/desktop-microsoft/issues/21 2020-06-18 21:21:24 +02:00
Guillaume Tardif
8bfe0c5ebc use busy box instead of alpine (much smaller) 2020-06-18 18:02:46 +02:00
Guillaume Tardif
e4db0d2b9e Lower CPU/ memory of sidecar container to minimum (reached limits and commented with error message) 2020-06-18 17:56:19 +02:00
Djordje Lukic
ad72c866cc Add license headers 2020-06-18 16:48:03 +02:00
Guillaume Tardif
25d912c1ed Tests on compose conversion 2020-06-18 16:45:21 +02:00
Guillaume Tardif
4398560a40 Remove unused code 2020-06-18 16:13:14 +02:00
Guillaume Tardif
3f544f0e01 Don’t show ACI sidecar in docker ps 2020-06-18 16:13:04 +02:00
Guillaume Tardif
3187120d94 Initial sidecar container for Aci DNS 2020-06-18 15:50:49 +02:00
Djordje Lukic
b55267739a Azure backend reports progress 2020-06-18 11:01:33 +02:00
Guillaume Tardif
f403307edf Allow compose updates without having to delete the stack every time.
Update will “typically” keep the same IP, but this isn’t guaranteed by azure
(ACI has limitations on what can be updated, but this does not apply to us for the moment : https://docs.microsoft.com/en-us/azure/container-instances/container-instances-update#properties-that-require-container-delete)
For the moment I check in the test that the IP is keep the same
2020-06-18 10:03:28 +02:00
Ulysses Souza
5b1522095b Fix linter
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-16 10:59:40 +02:00
Guillaume Tardif
2b4e2cb322
Merge pull request #220 from docker/aci_user_agent
set Aci user agent to allow metrics on usage from docker cli
2020-06-16 09:44:41 +02:00
Guillaume Tardif
885e0d0aa4 common authoriser & user agent setup for all clients 2020-06-15 21:17:10 +02:00
Guillaume Tardif
425f9acb88 Set aci user agent for MS metrics 2020-06-15 20:39:09 +02:00
Ulysses Souza
1039c5ed94 Add tests on inspect
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-15 17:20:37 +02:00
Ulysses Souza
96bc1ca6f1 Add inspect command
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-06-15 15:08:04 +02:00
guillaume.tardif
df6fc2f18f Fix volume path setting for linux containers from windows host 2020-06-11 10:44:30 +02:00
Guillaume Tardif
819a7389f7 Fix login error when login to an azure account having no associated tenant.
This was encountered by @lorenrh with stack : 
```
docker login azure
panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
github.com/docker/api/azure/login.AzureLoginService.Login(0xc0004cc2a0, 0x2d, 0xe8b8a0, 0x1476830, 0xe8e4e0, 0xc000498ff0, 0x0, 0x0)
        github.com/docker/api/azure/login/login.go:130 +0x1057
github.com/docker/api/azure.(*aciCloudService).Login(0xc0004888c0, 0xe8e4e0, 0xc000498ff0, 0x0, 0xe82720, 0xc0004888c0)
        github.com/docker/api/azure/backend.go:283 +0x64
github.com/docker/api/cli/cmd/login.cloudLogin(0xc0004eb600, 0xd422a4, 0x3, 0x1, 0xffffffffffffffff)
        github.com/docker/api/cli/cmd/login/login.go:53 +0xae
github.com/docker/api/cli/cmd/login.runLogin(0xc0004eb600, 0xc00049c5f0, 0x1, 0x1, 0x0, 0x0)
        github.com/docker/api/cli/cmd/login/login.go:39 +0x15e
github.com/spf13/cobra.(*Command).execute(0xc0004eb600, 0xc00049c5d0, 0x1, 0x1, 0xc0004eb600, 0xc00049c5d0)
        github.com/spf13/cobra@v1.0.0/command.go:842 +0x45a
github.com/spf13/cobra.(*Command).ExecuteC(0xc0004a8580, 0xc000498fc0, 0xc41160, 0x1476830)
        github.com/spf13/cobra@v1.0.0/command.go:950 +0x350
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.0.0/command.go:887
github.com/spf13/cobra.(*Command).ExecuteContext(...)
        github.com/spf13/cobra@v1.0.0/command.go:880
main.main()
        github.com/docker/api/cli/main.go:167 +0x68f
```
2020-06-10 10:15:03 +02:00
Guillaume Tardif
e77513c1c8
Merge pull request #165 from docker/azure_private_images
Allow pulling private images from hub or other registries
2020-06-04 15:43:42 +02:00
Guillaume Tardif
427527d197
Merge pull request #146 from docker/chore-refactor-azure-login
Refactor Azure login local server
2020-06-04 10:39:30 +02:00
Christopher Crone
e5335adedd Azure: Refactor login errors
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-06-04 10:20:39 +02:00