Commit graph

162 commits

Author SHA1 Message Date
Guillaume Tardif
3d758b7f26 Implement docker ps —all filter on ACI 2020-08-12 11:59:36 +02:00
Guillaume Tardif
ee062e8333 ACI Stop implementation 2020-08-12 10:32:35 +02:00
Djordje Lukic
f44d29f4df Fix the rm test without force
mutlierror didn't append an `Error:` if there is only one error...
2020-08-11 17:06:45 +02:00
Djordje Lukic
80c1b2246b
Merge pull request #457 from docker/feat-aci-force-rm
Add --force to rm on ACI
2020-08-11 16:42:49 +02:00
Djordje Lukic
093a69136f Add --force to rm on ACI
If a container is running the user must force the removal of the
container.
2020-08-11 16:30:42 +02:00
Guillaume Tardif
ec5f4e9202 Add options to docker login azure to support Service Principal login. Use it in E2E tests 2020-08-11 12:11:51 +02:00
Chris Crone
fc64f2923b aci-e2e: Windows fixes
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 17:23:50 +02:00
Chris Crone
65fb6020a0 tests.e2e: Check Windows specific error
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 15:06:20 +02:00
Chris Crone
6e99119a4b tests.e2e: Fix Windows tests
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:26:47 +02:00
Chris Crone
017053e19a tests.e2e: Refactor
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 14:12:46 +02:00
Guillaume Tardif
4dd1918ac2 Improve test that was sometimes passing too quickly where it should fail 2020-08-05 15:05:32 +02:00
Guillaume Tardif
f442eafe0b Validate run restart option value. Default value is “none”, instead of “no”, this is more in line with compose values, and changes only the default so should not have too much impact on legacy usage. 2020-08-04 17:11:21 +02:00
Ulysses Souza
a2c2d6aa5d Add Restart Policy support when running single container 2020-08-04 16:57:58 +02:00
Chris Crone
f8ce7a4780 cli: Move to gotest.tools
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-04 14:03:24 +02:00
aiordache
87245ef727 rename packages ( amazon to ecs and azure to aci )
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-30 11:34:34 +02:00
aiordache
648f0139df add e2e test for compose up on default context
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-07-29 17:33:23 +02:00
Christopher Crone
eac315c6ec tests: Fix logout test on Windows
The macOS/Linux output when logging out from a registry that you're not
logged into is different to that of Windows. As the login test doesn't
really test if the registry login works, the test now just checks that
the command is properly parsed.

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:55:12 +02:00
Christopher Crone
d1a929eb7f cli: Fix logout when specifying a registry
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-17 16:29:12 +02:00
Djordje Lukic
4480d27595 Don't set the container name in the test
This will help us catch errors such as
https://github.com/docker/desktop-microsoft/issues/42
2020-07-16 10:39:41 +02:00
Guillaume Tardif
1fbdbbbbe3
Merge pull request #381 from docker/fix-logs-windows
Get the real width of the terminal
2020-07-10 13:06:07 +02:00
Guillaume Tardif
d21fd7b8cf Do not fail (divide by zero) if terminal width is not set. Improved a bit the ACI e2e test, happy that it catches this error (this was going to break the log gRPC API) 2020-07-10 13:00:41 +02:00
Guillaume Tardif
52c2d09eae
Merge pull request #376 from docker/logout
Implement azure logout
2020-07-10 09:48:39 +02:00
Djordje Lukic
26b4ece77d
Merge pull request #373 from docker/chore-guava
Update guava version to remove security warning
2020-07-09 15:02:39 +02:00
Djordje Lukic
ef2d304762 Allow non-interactive exec on ACI
If the request is for a non-interactive exec we don't attach the stdin
when executing.
2020-07-09 11:47:22 +02:00
Guillaume Tardif
492ce96dd4 Implement azure logout 2020-07-08 17:48:10 +02:00
Guillaume Tardif
7cd0b3c159 Separate ACI e2e tests, allowing to run a single one 2020-07-08 16:54:45 +02:00
Guillaume Tardif
a2ea2347ba Remove It() in e2e tests, simplified step declaration. Nicer test output for all tests 2020-07-08 16:54:45 +02:00
Djordje Lukic
f5f01a8729 Update guava version to remove security warning 2020-07-08 15:07:12 +02:00
Guillaume Tardif
c5cd0f44f8 Fix ACI e2e tests : do not use console if no tty option set in exec 2020-07-07 14:05:25 +02:00
Guillaume Tardif
16acc36033
Merge pull request #356 from docker/fix-non-interactive
Add check on exec looking for arguments
2020-07-07 12:41:44 +02:00
Guillaume Tardif
f7daa70c87 Add ACI e2e test starting mysql with typical env vars 2020-07-07 12:22:56 +02:00
Guillaume Tardif
d7f8724dba
Merge pull request #354 from docker/aci_fix_compose_working_dir
Fix `docker compose up` with default project name being derived from current working dir
2020-07-07 11:27:49 +02:00
Ulysses Souza
35cbb621fb Add check on exec looking for arguments
In the case where the command has arguments
it fails because ACI implementation does not
support commands with arguments

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-07-07 09:32:52 +02:00
Guillaume Tardif
e4c1a1f945 Fix docker compose up with default project name being derived from current working dir. has been fixed upstream in compose-go (see https://github.com/compose-spec/compose-go/pull/56) 2020-07-06 16:56:30 +02:00
Guillaume Tardif
7296290408 Add ”Platform” in docker inspect result, showing container OS (this field is used by VSCode) 2020-07-06 12:16:02 +02:00
Guillaume Tardif
76cb73c5c2 ACI : allow docker compose down —project-name xxx without requiring the compose file 2020-07-03 10:24:06 +02:00
Guillaume Tardif
ae76e0cf27
Merge pull request #325 from docker/error_status_context_needs_login
Specific exit code when command fails because azure login is required
2020-07-02 17:02:57 +02:00
Guillaume Tardif
4a1b50a9cd
Merge pull request #326 from docker/run_follow_logs
Run containers and attach to logs by default, detach with -d option
2020-07-02 17:02:33 +02:00
Guillaume Tardif
5eea111ecf Run containers and attach to logs by default, detach with -d option 2020-07-02 16:45:04 +02:00
Guillaume Tardif
a9ef20eefd In ACI e2e tests, do not wait for full resource group deletion at the end, let ACI clean things UP (timeframe ~45 sec). This is costing GH Action minutes for nothing, and slows test results. 2020-07-02 16:13:38 +02:00
Guillaume Tardif
964e331a10 Specific exit code when command fails because azure login is required. Will be used by VSCode Docker integration 2020-07-02 13:52:57 +02:00
Guillaume Tardif
8bdb4dee77 Remove debug stuff from web images, that is causing apt-get install issues 2020-07-01 15:47:41 +02:00
Guillaume Tardif
7cde96e8b6 Update guava to fix CVE 2020-07-01 14:59:23 +02:00
Djordje Lukic
94a530b05f Make log stream test more readable 2020-06-30 18:26:38 +02:00
Guillaume Tardif
a48c4fb41c
Merge pull request #307 from docker/aci_e2e_group
Random ACI group name for tests, otherwise we are conflicting with each other + the CI
2020-06-30 18:18:16 +02:00
Guillaume Tardif
f850dc557d Random ACI group name for tests, otherwise we are conflicting with each other + the CI.
Same for storage account name (outside of the scope of resource group)
2020-06-30 18:13:07 +02:00
Djordje Lukic
fdc2bd34d7 Add test for logs --follow on ACI 2020-06-30 17:13:51 +02:00
Guillaume Tardif
2268f0c598 Renamed Login method specific to tests, to make things more explicit 2020-06-30 10:11:06 +02:00
Guillaume Tardif
eda438aaed Added basic support for service principal login, run ACI e2e tests with it 2020-06-29 20:35:23 +02:00
Guillaume Tardif
2b5e6f0038
Merge pull request #278 from docker/limits
Limits for CPU and Memory
2020-06-29 13:32:25 +02:00