mirror of
https://github.com/docker/compose.git
synced 2026-11-20 23:22:29 +00:00
feat: executor runs start-phase operations
Wire the plan executor to the start-phase vocabulary the reconciler already produces (#14200): OpWaitCondition, OpRunPreStart, the enriched OpStartContainer, and OpRunPostStart all had no case in executeNode and hit "unknown operation type". Every operation reuses the exact imperative primitive it mirrors — waitDependency, runPreStart, runHook, injectSecrets/injectConfigs — so behavior and events cannot drift between the two engines: execWaitCondition resolves the dependency's live containers and hands off to the same polling/condition-check functions waitDependencies uses; the enriched OpStartContainer resolves its target either from the observed container or, for a replica the plan itself creates, from the CreateContainer node's result (the mechanism OpRenameContainer already relies on), then injects secrets/configs before ContainerStart; OpRunPreStart re-checks the daemon first so a replica that started in the observe-to-execute window skips a redundant hook run. A replica's pre_start/start/post_start chain shares one event group, reporting a single Starting→Started progression exactly like startServiceContainer does today — Starting fires specifically at StartContainer, not at the (silent) pre_start hooks preceding it. pkg/api/event.go documents this per-resource progression contract. Still inert in production: create() (executePlan's only caller never builds a plan with start-phase scope, so none of this runs outside tests until a later brick in epic #14081 wires a real caller. EOF ) Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
parent
aab5848391
commit
fc7c1efa4b
6 changed files with 726 additions and 29 deletions
|
|
@ -97,6 +97,28 @@ func (e *Resource) StatusText() string {
|
|||
}
|
||||
|
||||
// EventProcessor is notified about Compose operations and tasks
|
||||
//
|
||||
// # Event contract
|
||||
//
|
||||
// The event stream is ordered per resource, not globally: operations run
|
||||
// concurrently and events of distinct resources interleave freely, but a
|
||||
// given resource's events follow a fixed progression. Consumers must key on
|
||||
// Resource.ID and must not rely on global ordering.
|
||||
//
|
||||
// Typical per-resource progressions (statuses from the Status* constants):
|
||||
//
|
||||
// container being created: Creating → Created
|
||||
// container being started: Starting → Started (pre_start/post_start
|
||||
// hooks, when declared, run silently within it)
|
||||
// container being replaced: Recreate → Recreated
|
||||
// container stop/removal: Stopping → Stopped, Removing → Removed
|
||||
// dependency being waited: Waiting → Healthy | Exited
|
||||
// networks and volumes: Creating → Created, Removing → Removed
|
||||
//
|
||||
// Any progression can end early with an Error status, or — for optional
|
||||
// outcomes such as a dependency declared with required: false — with a
|
||||
// Skipped status carrying the reason. Status texts are stable identifiers:
|
||||
// tools may match on them.
|
||||
type EventProcessor interface {
|
||||
// Start is triggered as a Compose operation is starting with context
|
||||
Start(ctx context.Context, operation string)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue