Remzona54/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2026-10-21 03:12:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(tracing): batch span exports to prevent blocking

Browse source 
This was a bad configuration (my fault) that meant each span was
exported synchronously, as it ended. That can cause weird behavior
such as stuttering/blocking.

There's really no reason to NOT use the batch processor, it's the
recommended way to configure it. In the future, it might make sense
to tune the intervals based on the fact that Compose is a CLI vs
a long-running server app, but we handle flushing out on exit
already, so it's not a huge deal.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
This commit is contained in:
Milas Bowman 2024-01-17 14:35:08 -05:00 • committed by Nicolas De loof
parent f414bf7892
commit d688d3bf22
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/tracing/tracing.go
View file

@ -115,11 +115,9 @@ func InitProvider(dockerCli command.Cli) (ShutdownFunc, error) {
}
muxExporter := MuxExporter{exporters: exporters}
sp := sdktrace.NewSimpleSpanProcessor(muxExporter)
tracerProvider := sdktrace.NewTracerProvider(
sdktrace.WithSampler(sdktrace.AlwaysSample()),
sdktrace.WithResource(res),
sdktrace.WithSpanProcessor(sp),
sdktrace.WithBatcher(muxExporter),
)
otel.SetTracerProvider(tracerProvider)