Remzona54/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2026-08-31 23:03:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

ACI Volumes : create takes one required arg, instead of required flag --fileshare (we still have required flag --storage-account specifically for ACI)

Browse source 
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
This commit is contained in:
Guillaume Tardif 2020-09-24 14:58:19 +02:00
parent 79d671f1eb
commit ca35ccfb0e
5 changed files with 19 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cli/cmd/volume/acivolume.go
View file

@ -47,9 +47,9 @@ func ACICommand() *cobra.Command {
func createVolume() *cobra.Command {
aciOpts := aci.VolumeCreateOptions{}
cmd := &cobra.Command{
Use: "create --storage-account ACCOUNT --fileshare FILESHARE",
Use: "create --storage-account ACCOUNT VOLUME",
Short: "Creates an Azure file share to use as ACI volume.",
Args: cobra.ExactArgs(0),
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
ctx := cmd.Context()
c, err := client.New(ctx)
@ -57,7 +57,7 @@ func createVolume() *cobra.Command {
return err
}
result, err := progress.Run(ctx, func(ctx context.Context) (string, error) {
volume, err := c.VolumeService().Create(ctx, aciOpts)
volume, err := c.VolumeService().Create(ctx, args[0], aciOpts)
if err != nil {
return "", err
}
@ -72,8 +72,6 @@ func createVolume() *cobra.Command {
}
cmd.Flags().StringVar(&aciOpts.Account, "storage-account", "", "Storage account name")
cmd.Flags().StringVar(&aciOpts.Fileshare, "fileshare", "", "Fileshare name")
_ = cmd.MarkFlagRequired("fileshare")
_ = cmd.MarkFlagRequired("storage-account")
return cmd
}