From af91bc46a9ea25017442d30e9ba3c35012bbda23 Mon Sep 17 00:00:00 2001 From: Nicolas De Loof Date: Tue, 27 Oct 2026 11:35:18 +0100 Subject: [PATCH] docs(compose): describe dependency_wait.go and fix the header of service_containers.go The header of service_containers.go still listed the dependency waits among what it covers. Comments only. Part of #14081 Signed-off-by: Nicolas De Loof --- pkg/compose/dependency_wait.go | 6 ++++++ pkg/compose/service_containers.go | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/pkg/compose/dependency_wait.go b/pkg/compose/dependency_wait.go index 7d168ae54..8506ab3a1 100644 --- a/pkg/compose/dependency_wait.go +++ b/pkg/compose/dependency_wait.go @@ -31,6 +31,12 @@ import ( "github.com/docker/compose/v5/pkg/api" ) +// This file gathers the waits on depends_on conditions: the polling of a +// dependency's containers (waitDependency and the per-condition checks), shared +// by the plan's OpWaitCondition nodes and by the commands that wait outside a +// plan (waitDependencies: restart, run and the --wait verification of up and +// start), and the gate deciding which dependencies need a wait at all. + // ServiceConditionRunningOrHealthy is a service condition on status running or healthy const ServiceConditionRunningOrHealthy = "running_or_healthy" diff --git a/pkg/compose/service_containers.go b/pkg/compose/service_containers.go index 60fb896a5..b9aea13a3 100644 --- a/pkg/compose/service_containers.go +++ b/pkg/compose/service_containers.go @@ -40,8 +40,8 @@ import ( // create/up/start) and by the commands that still walk the dependency order // themselves (dependencies.go: restart, stop, down and the classic build). It // covers container naming, resolution of service references (volumes_from, -// network_mode/ipc/pid, links), dependency waiting and container creation -// through the Docker API. +// network_mode/ipc/pid, links) and container creation through the Docker API; +// the waits on depends_on conditions are in dependency_wait.go. const ( doubledContainerNameWarning = "WARNING: The %q service is using the custom container name %q. " +