build: bump golangci-lint to v2.13.2
Some checks are pending
ci / validate (lint) (push) Waiting to run
ci / validate (validate-docs) (push) Waiting to run
ci / validate (validate-go-mod) (push) Waiting to run
ci / validate (validate-headers) (push) Waiting to run
ci / validate (validate-mocks) (push) Waiting to run
ci / binary (push) Waiting to run
ci / binary-finalize (push) Blocked by required conditions
ci / bin-image-test (push) Waiting to run
ci / test (push) Waiting to run
ci / e2e (plugin, oldstable, graphdriver) (push) Waiting to run
ci / e2e (standalone, oldstable, graphdriver) (push) Waiting to run
ci / e2e (plugin, stable, containerd) (push) Waiting to run
ci / e2e (plugin, stable, graphdriver) (push) Waiting to run
ci / e2e (standalone, stable, containerd) (push) Waiting to run
ci / e2e (standalone, stable, graphdriver) (push) Waiting to run
ci / coverage (push) Blocked by required conditions
ci / release (push) Blocked by required conditions
merge / bin-image-prepare (push) Waiting to run
merge / bin-image (push) Blocked by required conditions
merge / module-image (push) Waiting to run
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
zizmor / zizmor (push) Waiting to run

- migrate gomodguard to gomodguard_v2 (gomodguard is deprecated since
  v2.13 and warns on every run); same blocked modules, flat-list schema
- silence SA4023 in watcher_naive.go: tilt-dev/fsnotify SetRecursive
  only succeeds on Windows, so on any single GOOS the newer staticcheck
  proves the err == nil comparison constant — the cross-platform code
  is correct, the finding is per-GOOS

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
Nicolas De Loof 2026-09-02 08:50:07 +02:00 • committed by Guillaume Lours
parent 2be4e2d656
commit 70e17bfc66
3 changed files with 17 additions and 16 deletions

View file

@ -18,7 +18,7 @@ linters:
- forbidigo
- gocognit
- gocritic
- gomodguard
- gomodguard_v2
- govet
- ineffassign
- lll
@ -72,19 +72,17 @@ linters:
- style
gocognit:
min-complexity: 30
gomodguard:
gomodguard_v2:
blocked:
modules:
- github.com/pkg/errors:
recommendations:
- errors
- fmt
versions:
- github.com/distribution/distribution:
reason: use distribution/reference
- gotest.tools:
version: < 3.0.0
reason: deprecated, pre-modules version
- module: github.com/pkg/errors
recommendations:
- errors
- fmt
- module: github.com/distribution/distribution
reason: use distribution/reference
- module: gotest.tools
version: < 3.0.0
reason: deprecated, pre-modules version
lll:
line-length: 200
revive:

View file

@ -17,7 +17,7 @@
ARG GO_VERSION=1.26.6
ARG XX_VERSION=1.9.0
ARG GOLANGCI_LINT_VERSION=v2.11.3
ARG GOLANGCI_LINT_VERSION=v2.13.2
ARG ADDLICENSE_VERSION=v1.0.0
ARG BUILD_TAGS="e2e"

View file

@ -309,8 +309,11 @@ func newWatcher(paths []string) (Notify, error) {
}
MaybeIncreaseBufferSize(fsw)
err = fsw.SetRecursive()
isWatcherRecursive := err == nil
// SetRecursive only succeeds on Windows; every other platform returns
// "Not supported" and the non-recursive fallback below is taken. On a
// single GOOS staticcheck proves the comparison constant (SA4023).
err = fsw.SetRecursive() //nolint:staticcheck
isWatcherRecursive := err == nil //nolint:staticcheck
wrappedEvents := make(chan FileEvent)
notifyList := make(map[string]bool, len(paths))