mirror of
https://github.com/docker/compose.git
synced 2026-11-20 15:09:50 +00:00
docs(projectloader): point the comments to the new home of the dependency wait
Some checks are pending
ci / validate (lint) (push) Waiting to run
ci / validate (relay-lint) (push) Waiting to run
ci / validate (relay-test) (push) Waiting to run
ci / validate (validate-docs) (push) Waiting to run
ci / validate (validate-go-mod) (push) Waiting to run
ci / validate (validate-headers) (push) Waiting to run
ci / validate (validate-mocks) (push) Waiting to run
ci / binary (push) Waiting to run
ci / binary-finalize (push) Blocked by required conditions
ci / bin-image-test (push) Waiting to run
ci / relay-image-test (push) Waiting to run
ci / test (push) Waiting to run
ci / e2e (plugin, oldstable, graphdriver) (push) Waiting to run
ci / e2e (standalone, oldstable, graphdriver) (push) Waiting to run
ci / e2e (plugin, stable, containerd) (push) Waiting to run
ci / e2e (plugin, stable, graphdriver) (push) Waiting to run
ci / e2e (standalone, stable, containerd) (push) Waiting to run
ci / e2e (standalone, stable, graphdriver) (push) Waiting to run
ci / coverage (push) Blocked by required conditions
ci / ci-ok (push) Blocked by required conditions
ci / release (push) Blocked by required conditions
merge / bin-image-prepare (push) Waiting to run
merge / bin-image (push) Blocked by required conditions
merge / relay-image (push) Waiting to run
merge / module-image (push) Waiting to run
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
zizmor / zizmor (push) Waiting to run
Some checks are pending
ci / validate (lint) (push) Waiting to run
ci / validate (relay-lint) (push) Waiting to run
ci / validate (relay-test) (push) Waiting to run
ci / validate (validate-docs) (push) Waiting to run
ci / validate (validate-go-mod) (push) Waiting to run
ci / validate (validate-headers) (push) Waiting to run
ci / validate (validate-mocks) (push) Waiting to run
ci / binary (push) Waiting to run
ci / binary-finalize (push) Blocked by required conditions
ci / bin-image-test (push) Waiting to run
ci / relay-image-test (push) Waiting to run
ci / test (push) Waiting to run
ci / e2e (plugin, oldstable, graphdriver) (push) Waiting to run
ci / e2e (standalone, oldstable, graphdriver) (push) Waiting to run
ci / e2e (plugin, stable, containerd) (push) Waiting to run
ci / e2e (plugin, stable, graphdriver) (push) Waiting to run
ci / e2e (standalone, stable, containerd) (push) Waiting to run
ci / e2e (standalone, stable, graphdriver) (push) Waiting to run
ci / coverage (push) Blocked by required conditions
ci / ci-ok (push) Blocked by required conditions
ci / release (push) Blocked by required conditions
merge / bin-image-prepare (push) Waiting to run
merge / bin-image (push) Blocked by required conditions
merge / relay-image (push) Waiting to run
merge / module-image (push) Waiting to run
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
zizmor / zizmor (push) Waiting to run
Two comments still located waitDependency's runtime fallback in service_containers.go. Comments only. Part of #14081 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
parent
af91bc46a9
commit
4d6f2dbff7
2 changed files with 2 additions and 2 deletions
|
|
@ -138,7 +138,7 @@ func isUnderAnyOf(path tree.Path, removed map[tree.Path]string) bool {
|
|||
// load — already rejects anything else. There is no unsupported value left
|
||||
// for a real compose file to reach this check with (see
|
||||
// TestDependsOnUnknownConditionIsRejectedBySchema). waitDependency's own
|
||||
// runtime fallback (service_containers.go) still needs to warn about an
|
||||
// runtime fallback (dependency_wait.go) still needs to warn about an
|
||||
// unrecognized condition, for the two situations that never go through
|
||||
// schema validation at all: a project rebuilt from container labels, or an
|
||||
// older/newer Compose version's output.
|
||||
|
|
|
|||
|
|
@ -656,7 +656,7 @@ func TestPresenceUnsupportedAttributes_AreKnownSchemaPaths(t *testing.T) {
|
|||
// the compose-spec schema declares it as a closed enum of the 3 values this
|
||||
// runtime understands, so an unrecognized value never reaches
|
||||
// valueConditionalAttributes — it fails to load at all. waitDependency's
|
||||
// own runtime fallback in service_containers.go covers the cases that
|
||||
// own runtime fallback in dependency_wait.go covers the cases that
|
||||
// bypass schema validation entirely (a project rebuilt from container
|
||||
// labels, or one written by a different Compose version).
|
||||
func TestDependsOnUnknownConditionIsRejectedBySchema(t *testing.T) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue