Murzaby/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-09-01 01:12:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

add warning logs to authorization failure paths

Browse source
This commit is contained in:
dkanada 2026-05-04 12:23:47 +09:00
parent 968ea5cd98
commit ea9da7ec00
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Jellyfin.Api/Auth/ConditionalAuthorizationHandler/ConditionalAuthorizationHandler.cs
View file

@ -4,6 +4,7 @@ using MediaBrowser.Common.Api;
using MediaBrowser.Controller.Configuration; using MediaBrowser.Controller.Configuration;
using MediaBrowser.Model.Configuration; using MediaBrowser.Model.Configuration;
using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Authorization;
using Microsoft.Extensions.Logging;
namespace Jellyfin.Api.Auth.ConditionalAuthorizationHandler; namespace Jellyfin.Api.Auth.ConditionalAuthorizationHandler;
@ -13,14 +14,17 @@ namespace Jellyfin.Api.Auth.ConditionalAuthorizationHandler;
public class ConditionalAuthorizationHandler : AuthorizationHandler<ConditionalAuthorizationRequirement> public class ConditionalAuthorizationHandler : AuthorizationHandler<ConditionalAuthorizationRequirement>
{ {
private readonly IServerConfigurationManager _configurationManager; private readonly IServerConfigurationManager _configurationManager;
private readonly ILogger<ConditionalAuthorizationHandler> _logger;
/// <summary> /// <summary>
/// Initializes a new instance of the <see cref="ConditionalAuthorizationHandler"/> class. /// Initializes a new instance of the <see cref="ConditionalAuthorizationHandler"/> class.
/// </summary> /// </summary>
/// <param name="configurationManager">Instance of the <see cref="IServerConfigurationManager"/> interface.</param> /// <param name="configurationManager">Instance of the <see cref="IServerConfigurationManager"/> interface.</param>
public ConditionalAuthorizationHandler(IServerConfigurationManager configurationManager) /// <param name="logger">Instance of the <see cref="ILogger{TCategoryName}"/> interface.</param>
public ConditionalAuthorizationHandler(IServerConfigurationManager configurationManager, ILogger<ConditionalAuthorizationHandler> logger)
{ {
_configurationManager = configurationManager; _configurationManager = configurationManager;
_logger = logger;
} }
/// <inheritdoc /> /// <inheritdoc />
@ -39,10 +43,12 @@ public class ConditionalAuthorizationHandler : AuthorizationHandler<ConditionalA
if (conditionalAuthorization && requiresElevation && !context.User.IsInRole(UserRoles.Administrator)) if (conditionalAuthorization && requiresElevation && !context.User.IsInRole(UserRoles.Administrator))
{ {
_logger.LogWarning("administrator access currently required for this route due to {PolicyName} setting", requirement.PolicyName);
context.Fail(); context.Fail();
} }
else if (conditionalAuthorization && !requiresElevation && !context.User.Identity!.IsAuthenticated) else if (conditionalAuthorization && !requiresElevation && !context.User.Identity!.IsAuthenticated)
{ {
_logger.LogWarning("authentication currently required for this route due to {PolicyName} setting", requirement.PolicyName);
context.Fail(); context.Fail();
} }
else else