From 59e8c8385d1bb8239b83e5a514b524cdbcd1555e Mon Sep 17 00:00:00 2001 From: Arseny Lisin Date: Fri, 28 Nov 2025 12:47:29 +0300 Subject: [PATCH] Pull request 2536: AGDNS-3462 Fix submit button disabled state for dns upstream settings Squashed commit of the following: commit 222e41ad3e397f7e97e6ad4ca3929b97ed164e59 Author: Arseny Lisin Date: Fri Nov 28 11:14:17 2025 +0300 Fix commit 512aa2e69f3e21ebb62fc19d8d6b98b5c70d1ce9 Author: Arseny Lisin Date: Thu Nov 27 15:41:41 2025 +0300 Review fix commit a58bafe281de1b716e28aa1130991fa16754211d Author: Arseny Lisin Date: Thu Nov 27 15:28:24 2025 +0300 Fix submit button disabled state for dns upstream settings --- client/src/components/Settings/Dns/Access/Form.tsx | 4 ++-- client/src/components/Settings/Dns/Config/Form.tsx | 4 ++-- client/src/components/Settings/Dns/Upstream/Form.tsx | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/src/components/Settings/Dns/Access/Form.tsx b/client/src/components/Settings/Dns/Access/Form.tsx index 6b2cc7a12..46fce78d5 100644 --- a/client/src/components/Settings/Dns/Access/Form.tsx +++ b/client/src/components/Settings/Dns/Access/Form.tsx @@ -70,7 +70,7 @@ const Form = ({ initialValues, onSubmit, processingSet }: FormProps) => { control, handleSubmit, watch, - formState: { isSubmitting, isDirty }, + formState: { isSubmitting }, } = useForm({ mode: 'onBlur', defaultValues: { @@ -133,7 +133,7 @@ const Form = ({ initialValues, onSubmit, processingSet }: FormProps) => { type="submit" data-testid="access_save" className="btn btn-success btn-standard" - disabled={isSubmitting || !isDirty || processingSet}> + disabled={isSubmitting || processingSet}> {t('save_config')} diff --git a/client/src/components/Settings/Dns/Config/Form.tsx b/client/src/components/Settings/Dns/Config/Form.tsx index 18aaf1d51..b0c422169 100644 --- a/client/src/components/Settings/Dns/Config/Form.tsx +++ b/client/src/components/Settings/Dns/Config/Form.tsx @@ -109,7 +109,7 @@ const Form = ({ processing, initialValues, onSubmit }: Props) => { handleSubmit, watch, control, - formState: { isSubmitting, isDirty }, + formState: { isSubmitting }, } = useForm({ mode: 'onBlur', defaultValues: initialValues, @@ -383,7 +383,7 @@ const Form = ({ processing, initialValues, onSubmit }: Props) => { type="submit" data-testid="dns_config_save" className="btn btn-success btn-standard btn-large" - disabled={isSubmitting || !isDirty || processing}> + disabled={isSubmitting || processing}> {t('save_btn')} diff --git a/client/src/components/Settings/Dns/Upstream/Form.tsx b/client/src/components/Settings/Dns/Upstream/Form.tsx index a3c625e75..2356724f9 100644 --- a/client/src/components/Settings/Dns/Upstream/Form.tsx +++ b/client/src/components/Settings/Dns/Upstream/Form.tsx @@ -64,7 +64,7 @@ const Form = ({ initialValues, onSubmit }: FormProps) => { control, handleSubmit, watch, - formState: { isSubmitting, isDirty }, + formState: { isSubmitting }, } = useForm({ mode: 'onBlur', defaultValues: { @@ -345,7 +345,7 @@ const Form = ({ initialValues, onSubmit }: FormProps) => { type="submit" data-testid="dns_upstream_save" className="btn btn-success btn-standard" - disabled={isSubmitting || !isDirty || processingSetConfig || processingTestUpstream}> + disabled={isSubmitting || processingSetConfig || processingTestUpstream}> {t('apply_btn')}