Close leaked sqlite3 connections (ResourceWarning on Python 3.13+) (#6181)

Python 3.13+ reports sqlite3 connections that are garbage collected
without being closed. The unit tests print a run of
"ResourceWarning: unclosed database" lines on Linux/CPython 3.14:

- SQLAlchemy.close() only returned its connection to the engine's
  pool, so the underlying DBAPI connection (e.g. sqlite3 for
  '-d sqlite://...') stayed open. Dispose the engine on close.
- vulnTest() used "with sqlite3.connect(...)", which commits but does
  not close the connection. Use contextlib.closing().
- test_multibit and test_sqlalchemy never closed what they opened.

Co-authored-by: PiyushSatyarthi <244159432+PiyushSatyarthi@users.noreply.github.com>
This commit is contained in:
Piyush satyarthi 2026-11-12 14:16:10 +05:30 • committed by GitHub
parent eca9ff2e13
commit cb5216564a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 31 additions and 6 deletions

View file

@ -5,6 +5,7 @@ Copyright (c) 2006-2026 sqlmap developers (https://sqlmap.org)
See the file 'LICENSE' for copying permission
"""
import contextlib
import doctest
import json
import logging
@ -206,9 +207,11 @@ def vulnTest(tests=None, label="vuln"):
os.close(handle)
cleanups.append(database)
with sqlite3.connect(database) as conn:
# Note: sqlite3's own context manager only commits (it does not close the connection)
with contextlib.closing(sqlite3.connect(database)) as conn:
c = conn.cursor()
c.executescript(vulnserver.SCHEMA)
conn.commit()
handle, request = tempfile.mkstemp(suffix=".req")
os.close(handle)