CERBERUS/speedtest
1
0
Fork 0
mirror of https://github.com/librespeed/speedtest.git synced 2026-06-28 04:42:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

perf: avoid O(n²) indexOf lookup in classic UI server loop
Some checks failed
Docker / e2e (push) Has been cancelled
Details
Docker / build (./Dockerfile, , ghcr.io/${{ github.repository }}) (push) Has been cancelled
Details
Docker / build (./Dockerfile.alpine, -alpine, ghcr.io/${{ github.repository }}) (push) Has been cancelled
Details

Browse source 
Build an array of {idx, server} pairs before sorting so the original
SPEEDTEST_SERVERS index is carried through, eliminating the per-option
indexOf call.
This commit is contained in:
valer23 2026-04-17 10:42:37 +02:00 • committed by sstidl
parent 69fa7a4edb
commit 5cd7ce2efa
1 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
index-classic.html
View file

@ -69,18 +69,22 @@
country = country.replace(/\s*\([^)]*\)\s*/g, "").trim();
return { country: country, city: city };
}
var sortedServers = SPEEDTEST_SERVERS.slice().sort(function (a, b) {
var pa = parseServerName(a.name);
var pb = parseServerName(b.name);
var indexed = [];
for (var j = 0; j < SPEEDTEST_SERVERS.length; j++) {
indexed.push({ idx: j, server: SPEEDTEST_SERVERS[j] });
}
indexed.sort(function (a, b) {
var pa = parseServerName(a.server.name);
var pb = parseServerName(b.server.name);
return pa.country.localeCompare(pb.country) || pa.city.localeCompare(pb.city);
});
//populate server list for manual selection
for (var i = 0; i < sortedServers.length; i++) {
if (sortedServers[i].pingT == -1) continue;
for (var i = 0; i < indexed.length; i++) {
if (indexed[i].server.pingT == -1) continue;
var option = document.createElement("option");
option.value = SPEEDTEST_SERVERS.indexOf(sortedServers[i]);
option.textContent = sortedServers[i].name;
if (sortedServers[i] === server) option.selected = true;
option.value = indexed[i].idx;
option.textContent = indexed[i].server.name;
if (indexed[i].server === server) option.selected = true;
I("server").appendChild(option);
}
//show test UI