From 97cabe60a9782e956538444964098bbb9ce7f736 Mon Sep 17 00:00:00 2001 From: Daniel LaCosse Date: Fri, 1 Jul 2022 16:51:27 -0500 Subject: [PATCH] fix: remove outdated RELEASES_REPOSITORY (#1119) * remove releases repository * make github explicit * remove ci docs * generic = raw url download --- src/server_manager/README.md | 8 -------- .../scripts/get_electron_build_flags.mjs | 11 +++++------ 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/src/server_manager/README.md b/src/server_manager/README.md index 87a41355..3e12ea6d 100644 --- a/src/server_manager/README.md +++ b/src/server_manager/README.md @@ -63,11 +63,3 @@ To enable error reporting through [Sentry](https://sentry.io/) for local builds, export SENTRY_DSN=[Sentry development API key] npm run action server_manager/electron_app/start ``` - -## CI Environment Variables - -For your CI to run smoothly, you'll need the following in your ENV: - -- `SENTRY_DSN` - [url required](https://docs.sentry.io/product/sentry-basics/dsn-explainer/) to enable sentry integration. Same across all platforms. -- `RELEASES_REPOSITORY` - the username and repository name of the repository you're pushing releases to. In our case, `Jigsaw-Code/outline-releases` -- `RELEASES_DEPLOY_KEY` - an ssh secret key for the matching releases repository public deploy key - [how to set this up](https://docs.github.com/en/developers/overview/managing-deploy-keys#setup-2) diff --git a/src/server_manager/scripts/get_electron_build_flags.mjs b/src/server_manager/scripts/get_electron_build_flags.mjs index a61224e3..001e4f6c 100644 --- a/src/server_manager/scripts/get_electron_build_flags.mjs +++ b/src/server_manager/scripts/get_electron_build_flags.mjs @@ -33,24 +33,23 @@ export async function getElectronBuildFlags(platform, buildMode) { break; case 'windows': buildFlags = [ - '--win', '--ia32', + '--win', + '--ia32', '--config.win.icon=icons/win/icon.ico', '--config.win.sign=src/server_manager/electron_app/windows/electron_builder_signing_plugin.cjs', - ...buildFlags]; + ...buildFlags, + ]; break; case 'macos': buildFlags = ['--mac', '--config.mac.icon=icons/mac/icon.icns', ...buildFlags]; } if (buildMode === 'release') { - // Publishing is disabled, updates are pulled from AWS. We use the generic provider instead of the S3 - // provider since the S3 provider uses "virtual-hosted style" URLs (my-bucket.s3.amazonaws.com) - // which can be blocked by DNS or SNI without taking down other buckets. buildFlags = [ ...buildFlags, '--config.generateUpdatesFilesForAllChannels=true', '--config.publish.provider=generic', - `--config.publish.url=${process.env.RELEASES_REPOSITORY}`, + '--config.publish.url=https://raw.githubusercontent.com/Jigsaw-Code/outline-releases/master/manager/', ]; }