ollama/x/create/client/quantize.go
Daniel Hiltgen 9db4bdbad6
runner: Remove CGO engines, use llama-server exclusively for GGML models (#16031)
* broad lint fixes to sidestep CI scope glitch

* runner: Remove CGO engines, use llama-server exclusively for GGML models

Remove the vendored GGML and llama.cpp backend, CGO runner, Go model
implementations, and sample.  llama-server (built from upstream llama.cpp via
FetchContent) is now the sole inference engine for GGUF-based models.
(Safetensor based models continue to run on the new MLX engine.)  This allows
us to more rapidly pick up new capabilities and fixes from llama.cpp as they
come out.

On windows this now requires recent AMD driver versions to support ROCm v7 as
llama.cpp currently does not support building against v6.

* llama/compat: load Ollama-format GGUFs in llama-server

Squashed from upstream/jmorganca/llama-compat on 2026-04-29.
Source tip: 0c33775d37.

Original source commits:
- 25223160d llama/compat: add in-memory shim so llama-server can load Ollama-format GGUFs
- 7449b539a llm,server: route Ollama-format gemma3 blobs through llama/compat
- 436f2e2b1 llama/compat: make patch-apply idempotent
- 8c2c9d4c8 llama/compat: extend gemma3 handler to cover 1B and 270M blobs
- 021389f7b llama/compat: shrink clip.cpp injection from 18 lines to 1
- 61b367ec2 llama/compat: shrink patch to pure call-site hooks (34 -> 20 lines)
- 36049361c llama/compat: simplify shim (gemma3-tested)
- 8fa664865 llama/compat: add qwen35moe text handler
- db0c74530 llama/compat: add qwen35moe vision (clip) support
- 2a388da77 llama/compat: split shared infra into a util TU
- 9a69a17dc llama/compat: document non-public API dependencies
- d0f38a915 llama/compat: add gpt-oss and lfm2 handlers
- 086071822 llama/compat: add mistral3 text handler (vision TODO)
- 63bde9ff7 llama/compat: add mistral3 vision (clip) support
- 3a57b89d5 llama/compat: apply LLaMA RoPE permute to mistral3 vision Q/K
- 99cb87439 llama/compat: add qwen35, gemma4, deepseek-ocr handlers
- 2c7850dba llama/compat: add nemotron_h_moe handler (latent FFN + MTP skip)
- 9e3b54225 llama/compat: add llama4 text + clip handlers
- 034fee349 llama/compat: add gemma4 clip handler (gemma4v projector)
- 9945c5a93 server: remove dhiltgen/* compat redirect table
- 5d4539101 llama/compat: rewrite gemma4 tokenizer model to BPE
- 7e0765327 llama/compat: add glm-ocr text handler + text-loader load-op hook
- f1bd1a25a llama/compat: add glm-ocr clip handler (glm4v projector)
- 4b5cf3420 llama/compat: collapse text-loader hook back to one new patch line
- eb4ecf4fc llama/compat: extend gemma4 clip handler to gemma4a (audio)
- a23a5e76f llama/compat: fix gemma4a per-block norm tensor mapping
- cd2dcaff4 llama/compat: add embeddinggemma handler
- 1ce8a6b26 llama/compat: add qwen3-vl + qwen2.5-vl handlers
- fd98ffa1e llama/compat: add gemma3n + glm4moelite handlers
- cc7bdf0bc llama/compat: handle null buft in maybe_load_tensor
- 0c33775d3 llama/compat: disable mmap when load_op transforms text-side tensors

* refine implementation

* ci: fix windows MLX build

* ci: fix windows llama-server build

* ci: fix windows rocm build

* ci: windows mlx tuning

Shorten long-tail on build, and get OllamaSetup.exe back under 2g limit

* ci: fix windows dependencies

* win: fix dependency gathering

* disable openmp

* win: arm64 cross-compile build

also DRY out CI steps

* scheduler improvements

* ci: improvements from #15982

* win: favor ninja for faster developer builds

* win: fix build

* win: fix arm64 cross-compile

* win: avoid spaces in compiler path

* misc discovery fixes, and bos handling

* lint fixes

* win: fix arm cross-compile build/CI bugs

* llama.cpp update

* win: handle multiple CRT dirs

* vulkan: add windows iGPU detection

* fix creation bugs for patched models, other refactoring work

* tune batch size for better performance

* ci and lint fixes

* fix repeat_last_n bug

* build: revamp build for better developer UX

* amd, sampler, qwen3next fixes

* version bump

* fix mlx build

* revamp GPU discovery

Scanning the output of llama-server is turning out to be too error prone across
llama.cpp updates, so this switches to a thin dynamic library load against the
bundled GGML libraries so more details can be gathered from the API.

* version bump

* missing file

* ci: fix cache miss on rocm build

* refine vulkan dep handling

* fix ps reporting bug on full GPU load

* improve cmake wiring for customized local builds

* version bump

* docker build arg cleanup

* improve windows exit error logs

* fix community gemma4 support and ci flakes

* fix mlx unit test

* tighten up ps logic to avoid double counting fit log lines

* version bump

* fix ps view for full gpu layer offload

* add MTP wiring for llama-server and create with GGUFs

* pick best template by capabilities

* version bump

* ci: harden apt repos

* remove unused cpu core discovery

* adjust batch default logic to reduce OOMs

* support larger tool calls

* fix audio support, template show

* qwen35 mtp patch support

* flesh out dtypes

* rocm deps

* version bump

* lint fix

* block broken gfx1150 on windows

* fix qwen3.5 moe mtp tensors in patch

* mmproj oom fallback and vulkan on by default

* qwen MTP compat fix

* version bump

* ci: fix WoA cross-compile

* ci: workaround ui tool in cross-compile

* version bump

* win: enable OpenMP for CPU builds

* build: improve developer UX

* ci: windows path workaround for CPU build

* win: fix WoA dependencies

* win: fix large offset reads for mmproj patched loads

* version bump

* fix vulkan dup detection

* add OLLAMA_IGPU_ENABLE and largely disable iGPUs by default

* opt-in MTP, win large offset, integraton fixes

* fix unit test scheduler interaction hang

* fix multi-gpu filtering

* version bump

* review comments

* fix thinking level

* fix linux rocm ordering and granite 3.3 template

* version bump

* ci fix - non-shallow MLX checkout

* bypass linux sysfs unit test on windows

---------

Co-authored-by: jmorganca <jmorganca@gmail.com>
2026-05-29 13:35:47 -07:00

610 lines
18 KiB
Go

package client
import (
"encoding/binary"
"encoding/json"
"fmt"
"io"
"os"
"path/filepath"
"regexp"
"sort"
"strconv"
"strings"
"github.com/ollama/ollama/x/create"
"github.com/ollama/ollama/x/mlxrunner/mlx"
"github.com/ollama/ollama/x/mlxrunner/model"
)
// loadAndQuantizeArray writes a safetensors reader to a temp file, loads it with MLX,
// quantizes the tensor, and appends the resulting arrays (weight, scale, optional bias)
// to the provided maps. If quantize is empty, the tensor is kept as-is.
// Returns any temp file paths created (caller must clean up) and arrays needing eval.
func loadAndQuantizeArray(r io.Reader, name, quantize string, arrays map[string]*mlx.Array) (tmpPath string, toEval []*mlx.Array, nativeHandle *mlx.SafetensorsFile, err error) {
if quantize != "" {
if gs, _, _ := model.QuantizationParams(quantize); gs == 0 {
return "", nil, nil, fmt.Errorf("unsupported quantization type: %s", quantize)
}
}
tmpDir := ensureTempDir()
tmpFile, err := os.CreateTemp(tmpDir, "quant-*.safetensors")
if err != nil {
return "", nil, nil, fmt.Errorf("failed to create temp file: %w", err)
}
tmpPath = tmpFile.Name()
if _, err := io.Copy(tmpFile, r); err != nil {
tmpFile.Close()
return tmpPath, nil, nil, fmt.Errorf("failed to write temp file for %s: %w", name, err)
}
tmpFile.Close()
st, err := mlx.LoadSafetensorsNative(tmpPath)
if err != nil {
return tmpPath, nil, nil, fmt.Errorf("failed to load safetensors for %s: %w", name, err)
}
// Find the tensor key (may differ from name for single-tensor blobs)
header, err := readSafetensorsHeader(tmpPath)
if err != nil {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("failed to read blob header for %s: %w", name, err)
}
inputKey, err := safetensorsKey(name, header)
if err != nil {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("failed to resolve tensor key for %s: %w", name, err)
}
arr := st.Get(inputKey)
if arr == nil {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("tensor %q not found in safetensors", inputKey)
}
// Decode FP8 source encoding before checking quantize, so that callers
// requesting decode-only (quantize="") receive usable float data.
if info, ok := header[inputKey]; ok && info.Dtype == "F8_E4M3" {
scaleKey := inputKey + ".scale_inv"
scaleInv := st.Get(scaleKey)
if scaleInv == nil {
scaleKey = inputKey + ".scale"
scaleInv = st.Get(scaleKey)
}
if scaleInv == nil {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("missing companion tensor %q or %q for fp8 source tensor %q", inputKey+".scale_inv", inputKey+".scale", inputKey)
}
arr, err = decodeSourceFP8Tensor(arr, scaleInv)
if err != nil {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("failed to decode fp8 tensor %s: %w", inputKey, err)
}
mlx.Eval(arr)
}
if quantize == "" {
arr = mlx.Contiguous(arr, false)
arrays[name] = arr
return tmpPath, []*mlx.Array{arr}, st, nil
}
if arr.DType() != mlx.DTypeBFloat16 && arr.DType() != mlx.DTypeFloat32 && arr.DType() != mlx.DTypeFloat16 {
// Convert to float type if needed (quantize expects float)
arr = arr.AsType(mlx.DTypeBFloat16)
mlx.Eval(arr)
}
groupSize, bits, mode := model.QuantizationParams(quantize)
qweight, scales, qbiases := mlx.Quantize(arr, groupSize, bits, mode)
// Validate quantization produced non-empty output. MLX quantize may return
// empty arrays for unsupported mode/bits combinations without raising an error.
mlx.Eval(qweight, scales)
if len(qweight.Dims()) == 0 || qweight.Dims()[0] == 0 {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("mlx.Quantize produced empty weight for %s (quantize=%s, groupSize=%d, bits=%d, mode=%s)",
name, quantize, groupSize, bits, mode)
}
if len(scales.Dims()) == 0 || scales.Dims()[0] == 0 {
st.Free()
return tmpPath, nil, nil, fmt.Errorf("mlx.Quantize produced empty scales for %s (quantize=%s, groupSize=%d, bits=%d, mode=%s)",
name, quantize, groupSize, bits, mode)
}
qweight = mlx.Contiguous(qweight, false)
scales = mlx.Contiguous(scales, false)
arrays[name] = qweight
arrays[name+".scale"] = scales
toEval = append(toEval, qweight, scales)
if qbiases != nil {
qbiases = mlx.Contiguous(qbiases, false)
arrays[name+".bias"] = qbiases
toEval = append(toEval, qbiases)
}
return tmpPath, toEval, st, nil
}
// quantizeTensor loads a tensor from safetensors format, quantizes it,
// and returns a single combined safetensors blob with the quantized weight, scale, and optional bias.
// Tensor keys use the original tensor name: name, name.scale, name.bias.
// The blob includes __metadata__ with quant_type and group_size.
// Supported quantization types: "int4", "nvfp4", "mxfp4", "int8", "mxfp8".
func quantizeTensor(r io.Reader, tensorName, dtype string, shape []int32, quantize string) (blobData []byte, err error) {
arrays := make(map[string]*mlx.Array)
tmpPath, toEval, st, err := loadAndQuantizeArray(r, tensorName, quantize, arrays)
if tmpPath != "" {
defer os.Remove(tmpPath)
}
if err != nil {
return nil, err
}
finalArrays := make([]*mlx.Array, 0, len(arrays))
for _, arr := range arrays {
if arr != nil {
finalArrays = append(finalArrays, arr)
}
}
mlx.Pin(finalArrays...)
defer func() {
if st != nil {
st.Free()
}
mlx.Unpin(finalArrays...)
mlx.Sweep()
}()
mlx.Eval(toEval...)
mlx.Sweep()
// Free early to release mmap; defer guard handles error paths
if st != nil {
st.Free()
st = nil
}
// Build metadata for single-tensor blobs
groupSize, _, _ := model.QuantizationParams(quantize)
metadata := map[string]string{
"quant_type": quantize,
"group_size": strconv.Itoa(groupSize),
}
tmpDir := ensureTempDir()
outPath := filepath.Join(tmpDir, "combined.safetensors")
defer os.Remove(outPath)
if err := mlx.SaveSafetensorsWithMetadata(outPath, arrays, metadata); err != nil {
return nil, fmt.Errorf("failed to save combined blob: %w", err)
}
return os.ReadFile(outPath)
}
// quantizePackedGroup quantizes multiple tensors and saves them all into a single
// combined safetensors blob. Used for packing expert groups.
// When the inputs are per-expert 2D tensors (e.g., experts.0.gate_proj.weight),
// they are stacked into 3D switch_mlp tensors before quantization.
// Each tensor may have a different quantization type (mixed-precision).
// Returns the blob bytes.
func quantizePackedGroup(groupName string, inputs []create.PackedTensorInput) ([]byte, error) {
// Check if inputs are per-expert tensors that should be stacked into 3D
if projGroups, projQuantize := parsePerExpertInputs(groupName, inputs); projGroups != nil {
return stackAndQuantizeExpertGroup(groupName, projGroups, projQuantize)
}
allArrays := make(map[string]*mlx.Array)
var pinned []*mlx.Array
var metadata map[string]string
uniformQuantize := ""
hasQuantized := false
mixedQuantize := false
for _, input := range inputs {
if input.Quantize == "" {
if hasQuantized {
mixedQuantize = true
}
continue
}
if !hasQuantized {
hasQuantized = true
uniformQuantize = input.Quantize
continue
}
if input.Quantize != uniformQuantize {
mixedQuantize = true
}
}
if hasQuantized && !mixedQuantize {
if groupSize, _, _ := model.QuantizationParams(uniformQuantize); groupSize > 0 {
metadata = map[string]string{
"quant_type": uniformQuantize,
"group_size": strconv.Itoa(groupSize),
}
}
}
for _, input := range inputs {
tmpPath, toEval, st, err := loadAndQuantizeArray(input.Reader, input.Name, input.Quantize, allArrays)
if err != nil {
mlx.Unpin(pinned...)
mlx.Sweep()
return nil, err
}
mlx.Eval(toEval...)
finalArrays := arraysForPackedInput(allArrays, input)
mlx.Pin(finalArrays...)
pinned = append(pinned, finalArrays...)
// Record per-tensor quant type so the model can resolve params at load time.
if input.Quantize != "" {
if groupSize, _, _ := model.QuantizationParams(input.Quantize); groupSize > 0 {
if metadata == nil {
metadata = make(map[string]string)
}
metadata[input.Name+".quant_type"] = input.Quantize
metadata[input.Name+".group_size"] = strconv.Itoa(groupSize)
}
}
if st != nil {
st.Free()
}
if tmpPath != "" {
os.Remove(tmpPath)
}
mlx.Sweep()
}
defer func() {
mlx.Unpin(pinned...)
mlx.Sweep()
}()
// Save combined blob. Add global metadata only when every packed tensor uses
// the same quantization mode and group size.
tmpDir := ensureTempDir()
outPath := filepath.Join(tmpDir, "packed-combined.safetensors")
defer os.Remove(outPath)
if err := mlx.SaveSafetensorsWithMetadata(outPath, allArrays, metadata); err != nil {
return nil, fmt.Errorf("failed to save packed blob: %w", err)
}
blobData, err := os.ReadFile(outPath)
if err != nil {
return nil, fmt.Errorf("failed to read packed blob: %w", err)
}
return blobData, nil
}
func arraysForPackedInput(allArrays map[string]*mlx.Array, input create.PackedTensorInput) []*mlx.Array {
keys := []string{input.Name}
if input.Quantize != "" {
keys = append(keys, input.Name+".scale", input.Name+".bias")
}
out := make([]*mlx.Array, 0, len(keys))
for _, key := range keys {
if arr := allArrays[key]; arr != nil {
out = append(out, arr)
}
}
return out
}
// perExpertSuffix matches ".{index}.{proj_and_suffix}" after the group prefix.
var perExpertSuffix = regexp.MustCompile(`^\.(\d+)\.(.+)$`)
type expertTensorInfo struct {
index int
proj string // e.g., "gate_proj.weight"
input create.PackedTensorInput
}
// parsePerExpertInputs groups per-expert 2D tensor inputs by projection type
// and returns per-projection quantization types. Different projections may use
// different quant types (e.g., gate_up=int4, down=int8) but all experts within
// a projection must share the same type.
// Returns nil if the inputs are not per-expert tensors (e.g., already stacked 3D).
// Only handles ".experts" groups; ".shared_experts" groups are left unpacked.
func parsePerExpertInputs(groupName string, inputs []create.PackedTensorInput) (map[string][]expertTensorInfo, map[string]string) {
if !strings.HasSuffix(groupName, ".experts") {
return nil, nil
}
groups := make(map[string][]expertTensorInfo)
projQuantize := make(map[string]string) // projection -> quant type
for _, input := range inputs {
suffix := strings.TrimPrefix(input.Name, groupName)
m := perExpertSuffix.FindStringSubmatch(suffix)
if m == nil {
return nil, nil // not a per-expert pattern
}
index, err := strconv.Atoi(m[1])
if err != nil {
return nil, nil
}
proj := m[2]
if existing, ok := projQuantize[proj]; ok {
if input.Quantize != existing {
return nil, nil // mixed quant within same projection
}
} else {
projQuantize[proj] = input.Quantize
}
groups[proj] = append(groups[proj], expertTensorInfo{
index: index,
proj: proj,
input: input,
})
}
if len(groups) == 0 {
return nil, nil
}
return groups, projQuantize
}
// stackAndQuantizeExpertGroup decodes per-expert tensors, stacks them into 3D
// switch_mlp tensors, quantizes, and returns the combined safetensors blob.
// projQuantize maps projection name to its quantization type (may differ per projection).
func stackAndQuantizeExpertGroup(groupName string, projGroups map[string][]expertTensorInfo, projQuantize map[string]string) ([]byte, error) {
groupBase := strings.TrimSuffix(groupName, ".experts")
allArrays := make(map[string]*mlx.Array)
var pinned []*mlx.Array
// Build metadata: if all projections use the same quant type, set global metadata.
// Otherwise record per-tensor quant info.
metadata := make(map[string]string)
// Sort projection names for deterministic output
projNames := make([]string, 0, len(projGroups))
for proj := range projGroups {
projNames = append(projNames, proj)
}
sort.Strings(projNames)
cleanup := func() {
for _, p := range pinned {
if p != nil {
mlx.Unpin(p)
}
}
mlx.Sweep()
}
for _, proj := range projNames {
experts := projGroups[proj]
// Sort by expert index
sort.Slice(experts, func(i, j int) bool {
return experts[i].index < experts[j].index
})
// Load and decode each expert tensor
var decoded []*mlx.Array
for _, expert := range experts {
dummyArrays := make(map[string]*mlx.Array)
tmpPath, toEval, st, err := loadAndQuantizeArray(expert.input.Reader, expert.input.Name, "", dummyArrays)
if err != nil {
cleanup()
return nil, fmt.Errorf("failed to decode expert tensor %s: %w", expert.input.Name, err)
}
mlx.Eval(toEval...)
arr := dummyArrays[expert.input.Name]
mlx.Pin(arr)
pinned = append(pinned, arr)
decoded = append(decoded, arr)
if st != nil {
st.Free()
}
if tmpPath != "" {
os.Remove(tmpPath)
}
mlx.Sweep()
}
// Stack into 3D along axis 0: [numExperts, rows, cols]
stacked := mlx.Stack(decoded, 0)
mlx.Eval(stacked)
mlx.Pin(stacked)
pinned = append(pinned, stacked)
// Free individual decoded arrays (remove from pinned to avoid double-unpin in cleanup)
for i, p := range pinned {
for _, d := range decoded {
if p == d {
pinned[i] = nil
}
}
}
mlx.Unpin(decoded...)
mlx.Sweep()
stackedName := groupBase + ".switch_mlp." + proj
quantize := projQuantize[proj]
// Record per-tensor quant metadata so the model can resolve params at load time.
if quantize != "" {
if groupSize, _, _ := model.QuantizationParams(quantize); groupSize > 0 {
metadata[stackedName+".quant_type"] = quantize
metadata[stackedName+".group_size"] = strconv.Itoa(groupSize)
}
}
// Quantize the stacked tensor
if quantize != "" {
groupSize, bits, mode := model.QuantizationParams(quantize)
qweight, scales, qbiases := mlx.Quantize(stacked, groupSize, bits, mode)
// Validate quantization produced non-empty output.
mlx.Eval(qweight, scales)
if len(qweight.Dims()) == 0 || qweight.Dims()[0] == 0 {
cleanup()
return nil, fmt.Errorf("mlx.Quantize produced empty weight for %s (quantize=%s, groupSize=%d, bits=%d, mode=%s)",
stackedName, quantize, groupSize, bits, mode)
}
qweight = mlx.Contiguous(qweight, false)
scales = mlx.Contiguous(scales, false)
allArrays[stackedName] = qweight
allArrays[stackedName+".scale"] = scales
toEval := []*mlx.Array{qweight, scales}
if qbiases != nil {
qbiases = mlx.Contiguous(qbiases, false)
allArrays[stackedName+".bias"] = qbiases
toEval = append(toEval, qbiases)
}
mlx.Eval(toEval...)
mlx.Pin(toEval...)
pinned = append(pinned, toEval...)
// Free stacked source array (remove from pinned to avoid double-unpin in cleanup)
for i, p := range pinned {
if p == stacked {
pinned[i] = nil
}
}
mlx.Unpin(stacked)
mlx.Sweep()
} else {
stacked = mlx.Contiguous(stacked, false)
mlx.Eval(stacked)
mlx.Pin(stacked)
pinned = append(pinned, stacked)
allArrays[stackedName] = stacked
}
}
defer cleanup()
tmpDir := ensureTempDir()
outPath := filepath.Join(tmpDir, "stacked-combined.safetensors")
defer os.Remove(outPath)
if err := mlx.SaveSafetensorsWithMetadata(outPath, allArrays, metadata); err != nil {
return nil, fmt.Errorf("failed to save stacked blob: %w", err)
}
blobData, err := os.ReadFile(outPath)
if err != nil {
return nil, fmt.Errorf("failed to read stacked blob: %w", err)
}
return blobData, nil
}
// QuantizeSupported returns true if quantization is supported (MLX library available)
func QuantizeSupported() bool {
return mlx.CheckInit() == nil
}
// ensureTempDir creates the temp directory for quantization if it doesn't exist
func ensureTempDir() string {
tmpDir := filepath.Join(os.TempDir(), "ollama-quantize")
os.MkdirAll(tmpDir, 0o755)
return tmpDir
}
type safetensorsHeaderEntry struct {
Dtype string `json:"dtype"`
Shape []int32 `json:"shape"`
}
func readSafetensorsHeader(path string) (map[string]safetensorsHeaderEntry, error) {
f, err := os.Open(path)
if err != nil {
return nil, err
}
defer f.Close()
var headerSize uint64
if err := binary.Read(f, binary.LittleEndian, &headerSize); err != nil {
return nil, err
}
headerBytes := make([]byte, headerSize)
if _, err := io.ReadFull(f, headerBytes); err != nil {
return nil, err
}
var header map[string]safetensorsHeaderEntry
if err := json.Unmarshal(headerBytes, &header); err != nil {
return nil, err
}
return header, nil
}
// safetensorsKey resolves the primary tensor key from a header.
func safetensorsKey(preferred string, header map[string]safetensorsHeaderEntry) (string, error) {
if preferred != "" {
if _, ok := header[preferred]; ok {
return preferred, nil
}
}
keys := make([]string, 0, len(header))
for k := range header {
if k == "__metadata__" || strings.HasSuffix(k, ".scale_inv") {
continue
}
keys = append(keys, k)
}
sort.Strings(keys)
if len(keys) == 0 {
return "", fmt.Errorf("no tensor found in safetensors header")
}
return keys[0], nil
}
func decodeSourceFP8Tensor(weight, scale *mlx.Array) (*mlx.Array, error) {
if weight == nil || scale == nil {
return nil, fmt.Errorf("fp8 weight and scale tensors are required")
}
weightShape := weight.Dims()
scaleShape := scale.Dims()
if len(weightShape) != 2 || len(scaleShape) != 2 {
return nil, fmt.Errorf("expected 2D fp8 weight and scale tensors, got %v and %v", weightShape, scaleShape)
}
// These must match the block size validated by resolveEffectiveQuantization
// in create.go, which rejects any source model with a different block size.
const blockRows = 128
const blockCols = 128
rows, cols := weightShape[0], weightShape[1]
expectedScaleRows := (rows + blockRows - 1) / blockRows
expectedScaleCols := (cols + blockCols - 1) / blockCols
if scaleShape[0] != expectedScaleRows || scaleShape[1] != expectedScaleCols {
return nil, fmt.Errorf(
"unexpected fp8 scale shape %v for weight shape %v; want [%d %d]",
scaleShape,
weightShape,
expectedScaleRows,
expectedScaleCols,
)
}
decoded := mlx.FromFP8(weight, mlx.DTypeBFloat16)
padBottom := blockRows*scaleShape[0] - rows
padSide := blockCols*scaleShape[1] - cols
if padBottom > 0 || padSide > 0 {
decoded = mlx.PadConstant(decoded, []int{0, 1}, []int{0, 0}, []int{padBottom, padSide})
}
decoded = mlx.Reshape(decoded, int32(scaleShape[0]), int32(blockRows), int32(scaleShape[1]), int32(blockCols))
decoded = mlx.Mul(decoded, mlx.ExpandDims(mlx.ExpandDims(scale, 1), 3))
decoded = mlx.Reshape(decoded, int32(rows+padBottom), int32(cols+padSide))
if padBottom > 0 || padSide > 0 {
decoded = mlx.SliceStartStop(decoded, []int32{0, 0}, []int32{int32(rows), int32(cols)})
}
return decoded, nil
}