ollama/cmd/launch/pi_test.go

package launch

import (
	"encoding/json"
	"fmt"
	"net/http"
	"net/http/httptest"
	"os"
	"path/filepath"
	"runtime"
	"slices"
	"strings"
	"testing"

	"github.com/ollama/ollama/cmd/internal/fileutil"
	"github.com/ollama/ollama/types/model"
)

func TestPiIntegration(t *testing.T) {
	pi := &Pi{}

	t.Run("String", func(t *testing.T) {
		if got := pi.String(); got != "Pi" {
			t.Errorf("String() = %q, want %q", got, "Pi")
		}
	})

	t.Run("implements Runner", func(t *testing.T) {
		var _ Runner = pi
	})

	t.Run("implements Editor", func(t *testing.T) {
		var _ Editor = pi
	})
}

func TestPiInstallSpec_UsesOfficialPackage(t *testing.T) {
	spec, err := LookupIntegrationSpec("pi")
	if err != nil {
		t.Fatalf("LookupIntegrationSpec(pi) error = %v", err)
	}

	want := []string{"npm", "install", "-g", piNpmPackage + "@latest"}
	if got := spec.Install.Command; !slices.Equal(got, want) {
		t.Fatalf("pi install command = %v, want %v", got, want)
	}
}

func TestPiNpmPrefixForPackageRoot(t *testing.T) {
	prefix := filepath.Join(t.TempDir(), "npm-global")
	t.Run("unix npm global layout", func(t *testing.T) {
		packageRoot := filepath.Join(prefix, "lib", "node_modules", "@mariozechner", "pi-coding-agent")
		if got := npmPrefixForPackageRoot(packageRoot); got != prefix {
			t.Fatalf("npmPrefixForPackageRoot() = %q, want %q", got, prefix)
		}
	})
	tests := []struct {
		name        string
		goos        string
		separator   string
		packageRoot string
		want        string
	}{
		{
			name:        "macos npm global layout",
			goos:        "darwin",
			separator:   "/",
			packageRoot: "/Users/parth/.npm-global/lib/node_modules/@mariozechner/pi-coding-agent",
			want:        "/Users/parth/.npm-global",
		},
		{
			name:        "linux npm global layout",
			goos:        "linux",
			separator:   "/",
			packageRoot: "/home/parth/.npm-global/lib/node_modules/@mariozechner/pi-coding-agent",
			want:        "/home/parth/.npm-global",
		},
		{
			name:        "windows npm global layout",
			goos:        "windows",
			separator:   `\`,
			packageRoot: `C:\Users\parth\AppData\Roaming\npm\node_modules\@mariozechner\pi-coding-agent`,
			want:        `C:\Users\parth\AppData\Roaming\npm`,
		},
		{
			name:        "windows lib npm global layout",
			goos:        "windows",
			separator:   `\`,
			packageRoot: `C:\Users\parth\.npm-global\lib\node_modules\@mariozechner\pi-coding-agent`,
			want:        `C:\Users\parth\.npm-global`,
		},
		{
			name:        "non-windows direct node_modules layout",
			goos:        "linux",
			separator:   "/",
			packageRoot: "/home/parth/.npm-global/node_modules/@mariozechner/pi-coding-agent",
			want:        "",
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got := npmPrefixForPackageRootForGOOS(tt.packageRoot, tt.goos, tt.separator)
			if got != tt.want {
				t.Fatalf("npmPrefixForPackageRootForGOOS() = %q, want %q", got, tt.want)
			}
		})
	}
	t.Run("host windows npm global layout", func(t *testing.T) {
		packageRoot := filepath.Join(prefix, "node_modules", "@mariozechner", "pi-coding-agent")
		want := ""
		if runtime.GOOS == "windows" {
			want = prefix
		}
		if got := npmPrefixForPackageRoot(packageRoot); got != want {
			t.Fatalf("npmPrefixForPackageRoot() = %q, want %q", got, want)
		}
	})
}

func TestPiRun_InstallAndWebSearchLifecycle(t *testing.T) {
	if runtime.GOOS == "windows" {
		t.Skip("uses POSIX shell test binaries")
	}

	writeScript := func(t *testing.T, path, content string) {
		t.Helper()
		if err := os.WriteFile(path, []byte(content), 0o755); err != nil {
			t.Fatal(err)
		}
	}

	seedPiScript := func(t *testing.T, dir string) {
		t.Helper()
		piPath := filepath.Join(dir, "pi")
		listPath := filepath.Join(dir, "pi-list.txt")
		piScript := fmt.Sprintf(`#!/bin/sh
echo "$@" >> %q
if [ "$1" = "list" ]; then
  if [ -f %q ]; then
    /bin/cat %q
  fi
  exit 0
fi
if [ "$1" = "update" ] && [ "$PI_FAIL_UPDATE" = "1" ]; then
  echo "update failed" >&2
  exit 1
fi
if [ "$1" = "install" ] && [ "$PI_FAIL_INSTALL" = "1" ]; then
  echo "install failed" >&2
  exit 1
fi
exit 0
`, filepath.Join(dir, "pi.log"), listPath, listPath)
		writeScript(t, piPath, piScript)
	}

	seedNpmNoop := func(t *testing.T, dir string) {
		t.Helper()
		writeScript(t, filepath.Join(dir, "npm"), "#!/bin/sh\nexit 0\n")
	}

	seedLegacyPiNpm := func(t *testing.T, dir string) {
		t.Helper()
		npmPath := filepath.Join(dir, "npm")
		npmScript := fmt.Sprintf(`#!/bin/sh
echo "$@" >> %q
if [ "$1" = "install" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  if [ "$PI_FAIL_OFFICIAL_INSTALL" = "1" ]; then
    echo "install failed" >&2
    exit 1
  fi
  : > %q
  exit 0
fi
if [ "$1" = "uninstall" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  : > %q
  exit 0
fi
if [ "$1" = "ls" ] && [ "$2" = "-g" ] && [ "$4" = "--depth=0" ] && [ "$5" = "--json" ]; then
  if [ "$3" = %q ]; then
    if [ -f %q ]; then
      printf '{"name":"lib","dependencies":{"%s":{"version":"0.58.0","overridden":false}}}\n'
      exit 0
    fi
    printf '{"name":"lib"}\n'
    exit 1
  fi
  if [ "$3" = %q ]; then
    if [ ! -f %q ]; then
      printf '{"name":"lib","dependencies":{"%s":{"version":"0.57.1","overridden":false}}}\n'
      exit 0
    fi
    printf '{"name":"lib"}\n'
    exit 1
  fi
fi
exit 0
`, filepath.Join(dir, "npm.log"), piNpmPackage+"@latest", filepath.Join(dir, "official-installed"), piLegacyNpmPackage, filepath.Join(dir, "legacy-removed"), piNpmPackage, filepath.Join(dir, "official-installed"), piNpmPackage, piLegacyNpmPackage, filepath.Join(dir, "legacy-removed"), piLegacyNpmPackage)
		writeScript(t, npmPath, npmScript)
	}

	seedBothPiPackagesNpm := func(t *testing.T, dir string) {
		t.Helper()
		if err := os.WriteFile(filepath.Join(dir, "official-installed"), nil, 0o644); err != nil {
			t.Fatal(err)
		}
		npmPath := filepath.Join(dir, "npm")
		npmScript := fmt.Sprintf(`#!/bin/sh
echo "$@" >> %q
if [ "$1" = "install" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  : > %q
  exit 0
fi
if [ "$1" = "uninstall" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  : > %q
  exit 0
fi
if [ "$1" = "ls" ] && [ "$2" = "-g" ] && [ "$4" = "--depth=0" ] && [ "$5" = "--json" ]; then
  if [ "$3" = %q ]; then
    if [ ! -f %q ]; then
      printf '{"name":"lib","dependencies":{"%s":{"version":"0.57.1","overridden":false}}}\n'
      exit 0
    fi
    printf '{"name":"lib"}\n'
    exit 1
  fi
  if [ "$3" = %q ]; then
    if [ -f %q ]; then
      printf '{"name":"lib","dependencies":{"%s":{"version":"0.58.0","overridden":false}}}\n'
      exit 0
    fi
    printf '{"name":"lib"}\n'
    exit 1
  fi
fi
exit 0
`, filepath.Join(dir, "npm.log"), piNpmPackage+"@latest", filepath.Join(dir, "official-installed"), piLegacyNpmPackage, filepath.Join(dir, "legacy-removed"), piLegacyNpmPackage, filepath.Join(dir, "legacy-removed"), piLegacyNpmPackage, piNpmPackage, filepath.Join(dir, "official-installed"), piNpmPackage)
		writeScript(t, npmPath, npmScript)
	}

	seedBrokenPiProbeNpm := func(t *testing.T, dir string) {
		t.Helper()
		npmPath := filepath.Join(dir, "npm")
		npmScript := fmt.Sprintf(`#!/bin/sh
echo "$@" >> %q
if [ "$1" = "ls" ] && [ "$2" = "-g" ] && [ "$4" = "--depth=0" ] && [ "$5" = "--json" ]; then
  echo "npm probe failed" >&2
  exit 1
fi
exit 0
`, filepath.Join(dir, "npm.log"))
		writeScript(t, npmPath, npmScript)
	}

	withConfirm := func(t *testing.T, fn func(prompt string) (bool, error)) {
		t.Helper()
		oldConfirm := DefaultConfirmPrompt
		DefaultConfirmPrompt = func(prompt string, options ConfirmOptions) (bool, error) {
			return fn(prompt)
		}
		t.Cleanup(func() { DefaultConfirmPrompt = oldConfirm })
	}

	setCloudStatus := func(t *testing.T, disabled bool) {
		t.Helper()
		srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			if r.URL.Path == "/api/status" {
				fmt.Fprintf(w, `{"cloud":{"disabled":%t,"source":"config"}}`, disabled)
				return
			}
			http.NotFound(w, r)
		}))
		t.Cleanup(srv.Close)
		t.Setenv("OLLAMA_HOST", srv.URL)
	}

	setNpmRegistryVersion := func(t *testing.T, version string) {
		t.Helper()
		srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			if strings.HasSuffix(r.URL.Path, "/latest") {
				fmt.Fprintf(w, `{"version":%q}`, version)
				return
			}
			http.NotFound(w, r)
		}))
		oldRegistry := npmRegistryBaseURL
		npmRegistryBaseURL = srv.URL
		t.Cleanup(func() {
			npmRegistryBaseURL = oldRegistry
			srv.Close()
		})
	}

	seedPiWebSearchPackage := func(t *testing.T, dir, version string) {
		t.Helper()
		packagePath := filepath.Join(dir, ".npm-global", "lib", "node_modules", "@ollama", "pi-web-search")
		if err := os.MkdirAll(packagePath, 0o755); err != nil {
			t.Fatal(err)
		}
		packageJSON := fmt.Sprintf(`{"name":%q,"version":%q}`, piWebSearchPkg, version)
		if err := os.WriteFile(filepath.Join(packagePath, "package.json"), []byte(packageJSON), 0o644); err != nil {
			t.Fatal(err)
		}
		list := fmt.Sprintf("User packages:\n  %s\n    %s\n", piWebSearchSource, packagePath)
		if err := os.WriteFile(filepath.Join(dir, "pi-list.txt"), []byte(list), 0o644); err != nil {
			t.Fatal(err)
		}
	}

	t.Run("pi missing + user accepts install", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)

		if err := os.WriteFile(filepath.Join(tmpDir, "pi-list.txt"), []byte("User packages:\n"), 0o644); err != nil {
			t.Fatal(err)
		}

		npmScript := fmt.Sprintf(`#!/bin/sh
echo "$@" >> %q
if [ "$1" = "install" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  /bin/cat > %q <<'EOS'
#!/bin/sh
echo "$@" >> %q
if [ "$1" = "list" ]; then
  if [ -f %q ]; then
    /bin/cat %q
  fi
  exit 0
fi
exit 0
EOS
  /bin/chmod +x %q
fi
exit 0
`, filepath.Join(tmpDir, "npm.log"), piNpmPackage+"@latest", filepath.Join(tmpDir, "pi"), filepath.Join(tmpDir, "pi.log"), filepath.Join(tmpDir, "pi-list.txt"), filepath.Join(tmpDir, "pi-list.txt"), filepath.Join(tmpDir, "pi"))
		writeScript(t, filepath.Join(tmpDir, "npm"), npmScript)

		withConfirm(t, func(prompt string) (bool, error) {
			if strings.Contains(prompt, "Install Pi with npm?") {
				return true, nil
			}
			return true, nil
		})

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"--version"}); err != nil {
			npmCalls, _ := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
			t.Fatalf("Run() error = %v\nnpm calls:\n%s", err, npmCalls)
		}

		npmCalls, err := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
		if err != nil {
			t.Fatal(err)
		}
		if !strings.Contains(string(npmCalls), "install -g "+piNpmPackage+"@latest") {
			t.Fatalf("expected npm install call, got:\n%s", npmCalls)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		got := string(piCalls)
		if !strings.Contains(got, "list\n") {
			t.Fatalf("expected pi list call, got:\n%s", got)
		}
		if !strings.Contains(got, "install "+piWebSearchSource+"\n") {
			t.Fatalf("expected pi web search install call, got:\n%s", got)
		}
		if !strings.Contains(got, "--version\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", got)
		}
	})

	t.Run("pi missing + user declines install", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		writeScript(t, filepath.Join(tmpDir, "npm"), "#!/bin/sh\nexit 0\n")

		withConfirm(t, func(prompt string) (bool, error) {
			if strings.Contains(prompt, "Install Pi with npm?") {
				return false, nil
			}
			return true, nil
		})

		p := &Pi{}
		err := p.Run("ignored", nil, nil)
		if err == nil || !strings.Contains(err.Error(), "pi installation cancelled") {
			t.Fatalf("expected install cancellation error, got %v", err)
		}
	})

	t.Run("legacy pi package migrates automatically to official package", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		seedPiWebSearchPackage(t, tmpDir, "1.0.0")
		setNpmRegistryVersion(t, "1.0.0")
		seedPiScript(t, tmpDir)
		seedLegacyPiNpm(t, tmpDir)

		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"--version"}); err != nil {
			npmCalls, _ := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
			t.Fatalf("Run() error = %v\nnpm calls:\n%s", err, npmCalls)
		}

		npmCalls, err := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
		if err != nil {
			t.Fatal(err)
		}
		gotNPM := string(npmCalls)
		if !strings.Contains(gotNPM, "ls -g "+piLegacyNpmPackage+" --depth=0 --json\n") {
			t.Fatalf("expected legacy npm probe, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "install -g "+piNpmPackage+"@latest --force\n") {
			t.Fatalf("expected forced official npm install call, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "ls -g "+piNpmPackage+" --depth=0 --json\n") {
			t.Fatalf("expected official npm verification probe, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "uninstall -g "+piLegacyNpmPackage+"\n") {
			t.Fatalf("expected legacy npm uninstall call, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "install -g "+piNpmPackage+"@latest\n") {
			t.Fatalf("expected official npm install call, got:\n%s", gotNPM)
		}
		if strings.Index(gotNPM, "install -g "+piNpmPackage+"@latest --force\n") > strings.Index(gotNPM, "uninstall -g "+piLegacyNpmPackage+"\n") {
			t.Fatalf("expected official install before legacy uninstall, got:\n%s", gotNPM)
		}
		if strings.Index(gotNPM, "uninstall -g "+piLegacyNpmPackage+"\n") > strings.LastIndex(gotNPM, "install -g "+piNpmPackage+"@latest\n") {
			t.Fatalf("expected official repair install after legacy uninstall, got:\n%s", gotNPM)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		gotPi := string(piCalls)
		if strings.Contains(gotPi, "update "+piWebSearchSource+"\n") {
			t.Fatalf("did not expect pi update call when web search is current, got:\n%s", gotPi)
		}
		if !strings.Contains(gotPi, "--version\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", gotPi)
		}
	})

	t.Run("legacy pi package migrates even when official package is also installed", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		seedPiWebSearchPackage(t, tmpDir, "1.0.0")
		setNpmRegistryVersion(t, "1.0.0")
		seedPiScript(t, tmpDir)
		seedBothPiPackagesNpm(t, tmpDir)

		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"--version"}); err != nil {
			npmCalls, _ := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
			t.Fatalf("Run() error = %v\nnpm calls:\n%s", err, npmCalls)
		}

		npmCalls, err := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
		if err != nil {
			t.Fatal(err)
		}
		gotNPM := string(npmCalls)
		if !strings.Contains(gotNPM, "ls -g "+piLegacyNpmPackage+" --depth=0 --json\n") {
			t.Fatalf("expected legacy npm probe, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "install -g "+piNpmPackage+"@latest --force\n") {
			t.Fatalf("expected forced official npm install call, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "ls -g "+piNpmPackage+" --depth=0 --json\n") {
			t.Fatalf("expected official npm verification probe, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "uninstall -g "+piLegacyNpmPackage+"\n") {
			t.Fatalf("expected legacy npm uninstall call, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "install -g "+piNpmPackage+"@latest\n") {
			t.Fatalf("expected official npm install call, got:\n%s", gotNPM)
		}
	})

	t.Run("legacy pi package outside current npm prefix migrates with binary prefix", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		setCloudStatus(t, false)

		commandDir := filepath.Join(tmpDir, "commands")
		prefix := filepath.Join(tmpDir, "npm-global")
		legacyRoot := filepath.Join(prefix, "lib", "node_modules", "@mariozechner", "pi-coding-agent")
		legacyDist := filepath.Join(legacyRoot, "dist")
		if err := os.MkdirAll(filepath.Join(prefix, "bin"), 0o755); err != nil {
			t.Fatal(err)
		}
		if err := os.MkdirAll(legacyDist, 0o755); err != nil {
			t.Fatal(err)
		}
		if err := os.WriteFile(filepath.Join(legacyRoot, "package.json"), []byte(`{"name":"`+piLegacyNpmPackage+`","version":"0.67.1"}`), 0o644); err != nil {
			t.Fatal(err)
		}
		writeScript(t, filepath.Join(legacyDist, "cli.js"), fmt.Sprintf("#!/bin/sh\necho \"$@\" >> %q\nexit 0\n", filepath.Join(tmpDir, "pi.log")))
		if err := os.Symlink(filepath.Join(legacyDist, "cli.js"), filepath.Join(prefix, "bin", "pi")); err != nil {
			t.Fatal(err)
		}

		npmScript := fmt.Sprintf(`#!/bin/sh
echo "$@" >> %q
prefix=""
if [ "$1" = "--prefix" ]; then
  prefix="$2"
  shift 2
fi
if [ "$1" = "install" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  : > %q
  mkdir -p "$prefix/lib/node_modules/@earendil-works/pi-coding-agent/dist" "$prefix/bin"
  printf '{"name":"%s","version":"0.75.3"}\n' > "$prefix/lib/node_modules/@earendil-works/pi-coding-agent/package.json"
  printf '#!/bin/sh\necho "$@" >> %s\nexit 0\n' > "$prefix/lib/node_modules/@earendil-works/pi-coding-agent/dist/cli.js"
  chmod +x "$prefix/lib/node_modules/@earendil-works/pi-coding-agent/dist/cli.js"
  ln -sf "$prefix/lib/node_modules/@earendil-works/pi-coding-agent/dist/cli.js" "$prefix/bin/pi"
  exit 0
fi
if [ "$1" = "uninstall" ] && [ "$2" = "-g" ] && [ "$3" = %q ]; then
  : > %q
  exit 0
fi
if [ "$1" = "ls" ] && [ "$2" = "-g" ] && [ "$4" = "--depth=0" ] && [ "$5" = "--json" ]; then
  if [ "$3" = %q ] && [ -f %q ]; then
    printf '{"name":"lib","dependencies":{"%s":{"version":"0.75.3","overridden":false}}}\n'
    exit 0
  fi
  if [ "$3" = %q ] && [ ! -f %q ]; then
    printf '{"name":"lib","dependencies":{"%s":{"version":"0.67.1","overridden":false}}}\n'
    exit 0
  fi
  printf '{"name":"lib"}\n'
  exit 1
fi
exit 0
`, filepath.Join(tmpDir, "npm.log"), piNpmPackage+"@latest", filepath.Join(tmpDir, "official-installed"), piNpmPackage, filepath.Join(tmpDir, "pi.log"), piLegacyNpmPackage, filepath.Join(tmpDir, "legacy-removed"), piNpmPackage, filepath.Join(tmpDir, "official-installed"), piNpmPackage, piLegacyNpmPackage, filepath.Join(tmpDir, "legacy-removed"), piLegacyNpmPackage)
		if err := os.MkdirAll(commandDir, 0o755); err != nil {
			t.Fatal(err)
		}
		writeScript(t, filepath.Join(commandDir, "npm"), npmScript)
		t.Setenv("PATH", commandDir+string(os.PathListSeparator)+filepath.Join(prefix, "bin"))

		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"--version"}); err != nil {
			npmCalls, _ := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
			t.Fatalf("Run() error = %v\nnpm calls:\n%s", err, npmCalls)
		}

		npmCalls, err := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
		if err != nil {
			t.Fatal(err)
		}
		gotNPM := string(npmCalls)
		resolvedPrefix, err := filepath.EvalSymlinks(prefix)
		if err != nil {
			t.Fatal(err)
		}
		if !strings.Contains(gotNPM, "--prefix "+resolvedPrefix+" install -g "+piNpmPackage+"@latest --force\n") {
			t.Fatalf("expected forced official install in pi binary prefix, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "--prefix "+resolvedPrefix+" uninstall -g "+piLegacyNpmPackage+"\n") {
			t.Fatalf("expected legacy uninstall in pi binary prefix, got:\n%s", gotNPM)
		}
		if !strings.Contains(gotNPM, "--prefix "+resolvedPrefix+" install -g "+piNpmPackage+"@latest\n") {
			t.Fatalf("expected official repair install in pi binary prefix, got:\n%s", gotNPM)
		}
	})

	t.Run("legacy pi migration install failure does not remove legacy package", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		t.Setenv("PI_FAIL_OFFICIAL_INSTALL", "1")
		seedPiScript(t, tmpDir)
		seedLegacyPiNpm(t, tmpDir)

		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		err := p.Run("ignored", nil, nil)
		if err == nil || !strings.Contains(err.Error(), "failed to install pi") {
			t.Fatalf("expected install failure error, got %v", err)
		}

		npmCalls, readErr := os.ReadFile(filepath.Join(tmpDir, "npm.log"))
		if readErr != nil {
			t.Fatal(readErr)
		}
		gotNPM := string(npmCalls)
		if !strings.Contains(gotNPM, "install -g "+piNpmPackage+"@latest --force\n") {
			t.Fatalf("expected forced official npm install call, got:\n%s", gotNPM)
		}
		if strings.Contains(gotNPM, "uninstall -g "+piLegacyNpmPackage+"\n") {
			t.Fatalf("did not expect legacy uninstall after official install failure, got:\n%s", gotNPM)
		}
	})

	t.Run("pi installed + package probe failure warns and still launches", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		seedPiWebSearchPackage(t, tmpDir, "1.0.0")
		setNpmRegistryVersion(t, "1.0.0")
		seedPiScript(t, tmpDir)
		seedBrokenPiProbeNpm(t, tmpDir)
		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		stderr := captureStderr(t, func() {
			if err := p.Run("ignored", nil, []string{"--version"}); err != nil {
				t.Fatalf("Run() error = %v", err)
			}
		})
		if !strings.Contains(stderr, "Could not verify which Pi package is installed") {
			t.Fatalf("expected package probe warning, got:\n%s", stderr)
		}
		if !strings.Contains(stderr, "npm uninstall -g "+piLegacyNpmPackage) {
			t.Fatalf("expected manual migration steps in warning, got:\n%s", stderr)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		gotPi := string(piCalls)
		if strings.Contains(gotPi, "update "+piWebSearchSource+"\n") {
			t.Fatalf("did not expect pi update call when web search is current, got:\n%s", gotPi)
		}
		if !strings.Contains(gotPi, "--version\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", gotPi)
		}
	})

	t.Run("pi installed + web search missing auto-installs", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		if err := os.WriteFile(filepath.Join(tmpDir, "pi-list.txt"), []byte("User packages:\n"), 0o644); err != nil {
			t.Fatal(err)
		}
		seedPiScript(t, tmpDir)
		seedNpmNoop(t, tmpDir)
		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"session"}); err != nil {
			t.Fatalf("Run() error = %v", err)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		got := string(piCalls)
		if !strings.Contains(got, "list\n") {
			t.Fatalf("expected pi list call, got:\n%s", got)
		}
		if !strings.Contains(got, "install "+piWebSearchSource+"\n") {
			t.Fatalf("expected pi install call, got:\n%s", got)
		}
		if strings.Contains(got, "update "+piWebSearchSource+"\n") {
			t.Fatalf("did not expect pi update call when package missing, got:\n%s", got)
		}
		if !strings.Contains(got, "session\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", got)
		}
	})

	t.Run("pi installed + web search present skips update when current", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		seedPiWebSearchPackage(t, tmpDir, "1.0.0")
		setNpmRegistryVersion(t, "1.0.0")
		seedPiScript(t, tmpDir)
		seedNpmNoop(t, tmpDir)

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"doctor"}); err != nil {
			t.Fatalf("Run() error = %v", err)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		got := string(piCalls)
		if strings.Contains(got, "update "+piWebSearchSource+"\n") {
			t.Fatalf("did not expect pi update call, got:\n%s", got)
		}
		if !strings.Contains(got, "doctor\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", got)
		}
	})

	t.Run("pi installed + web search present updates when newer package exists", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		seedPiWebSearchPackage(t, tmpDir, "1.0.0")
		setNpmRegistryVersion(t, "1.0.1")
		seedPiScript(t, tmpDir)
		seedNpmNoop(t, tmpDir)

		p := &Pi{}
		if err := p.Run("ignored", nil, []string{"doctor"}); err != nil {
			t.Fatalf("Run() error = %v", err)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		got := string(piCalls)
		if !strings.Contains(got, "update "+piWebSearchSource+"\n") {
			t.Fatalf("expected pi update call, got:\n%s", got)
		}
		if !strings.Contains(got, "doctor\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", got)
		}
	})

	t.Run("web search update failure warns and continues", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		t.Setenv("PI_FAIL_UPDATE", "1")
		seedPiWebSearchPackage(t, tmpDir, "1.0.0")
		setNpmRegistryVersion(t, "1.0.1")
		seedPiScript(t, tmpDir)
		seedNpmNoop(t, tmpDir)

		p := &Pi{}
		stderr := captureStderr(t, func() {
			if err := p.Run("ignored", nil, []string{"session"}); err != nil {
				t.Fatalf("Run() should continue after web search update failure, got %v", err)
			}
		})
		if !strings.Contains(stderr, "Warning: could not update "+piWebSearchPkg) {
			t.Fatalf("expected update warning, got:\n%s", stderr)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		if !strings.Contains(string(piCalls), "session\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", piCalls)
		}
	})

	t.Run("web search install failure warns and continues", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		t.Setenv("PI_FAIL_INSTALL", "1")
		if err := os.WriteFile(filepath.Join(tmpDir, "pi-list.txt"), []byte("User packages:\n"), 0o644); err != nil {
			t.Fatal(err)
		}
		seedPiScript(t, tmpDir)
		seedNpmNoop(t, tmpDir)
		withConfirm(t, func(prompt string) (bool, error) {
			t.Fatalf("did not expect confirmation prompt, got %q", prompt)
			return false, nil
		})

		p := &Pi{}
		stderr := captureStderr(t, func() {
			if err := p.Run("ignored", nil, []string{"session"}); err != nil {
				t.Fatalf("Run() should continue after web search install failure, got %v", err)
			}
		})
		if !strings.Contains(stderr, "Warning: could not install "+piWebSearchPkg) {
			t.Fatalf("expected install warning, got:\n%s", stderr)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		if !strings.Contains(string(piCalls), "session\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", piCalls)
		}
	})

	t.Run("cloud disabled skips web search package management", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, true)
		if err := os.WriteFile(filepath.Join(tmpDir, "pi-list.txt"), []byte("User packages:\n"), 0o644); err != nil {
			t.Fatal(err)
		}
		seedPiScript(t, tmpDir)
		seedNpmNoop(t, tmpDir)

		p := &Pi{}
		stderr := captureStderr(t, func() {
			if err := p.Run("ignored", nil, []string{"session"}); err != nil {
				t.Fatalf("Run() error = %v", err)
			}
		})
		if !strings.Contains(stderr, "Cloud is disabled; skipping "+piWebSearchPkg+" setup.") {
			t.Fatalf("expected cloud-disabled skip message, got:\n%s", stderr)
		}

		piCalls, err := os.ReadFile(filepath.Join(tmpDir, "pi.log"))
		if err != nil {
			t.Fatal(err)
		}
		got := string(piCalls)
		if strings.Contains(got, "list\n") || strings.Contains(got, "install "+piWebSearchSource+"\n") || strings.Contains(got, "update "+piWebSearchSource+"\n") {
			t.Fatalf("did not expect web search package management calls, got:\n%s", got)
		}
		if !strings.Contains(got, "session\n") {
			t.Fatalf("expected final pi launch call, got:\n%s", got)
		}
	})

	t.Run("missing npm returns error before pi flow", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)
		t.Setenv("PATH", tmpDir)
		setCloudStatus(t, false)
		seedPiScript(t, tmpDir)

		p := &Pi{}
		err := p.Run("ignored", nil, []string{"session"})
		if err == nil || !strings.Contains(err.Error(), "npm (Node.js) is required to launch pi") {
			t.Fatalf("expected missing npm error, got %v", err)
		}

		if _, statErr := os.Stat(filepath.Join(tmpDir, "pi.log")); !os.IsNotExist(statErr) {
			t.Fatalf("expected pi not to run when npm is missing, stat err = %v", statErr)
		}
	})
}

func TestPiPaths(t *testing.T) {
	pi := &Pi{}

	t.Run("returns empty when no config exists", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		paths := pi.Paths()
		if len(paths) != 0 {
			t.Errorf("Paths() = %v, want empty", paths)
		}
	})

	t.Run("returns path when config exists", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		configDir := filepath.Join(tmpDir, ".pi", "agent")
		if err := os.MkdirAll(configDir, 0o755); err != nil {
			t.Fatal(err)
		}
		configPath := filepath.Join(configDir, "models.json")
		if err := os.WriteFile(configPath, []byte("{}"), 0o644); err != nil {
			t.Fatal(err)
		}

		paths := pi.Paths()
		if len(paths) != 1 || paths[0] != configPath {
			t.Errorf("Paths() = %v, want [%s]", paths, configPath)
		}
	})
}

func TestPiEdit(t *testing.T) {
	// Mock Ollama server for createConfig calls during Edit
	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if r.URL.Path == "/api/show" {
			fmt.Fprintf(w, `{"capabilities":[],"model_info":{}}`)
			return
		}
		w.WriteHeader(http.StatusNotFound)
	}))
	defer srv.Close()
	t.Setenv("OLLAMA_HOST", srv.URL)

	pi := &Pi{}
	tmpDir := t.TempDir()
	setTestHome(t, tmpDir)

	configDir := filepath.Join(tmpDir, ".pi", "agent")
	configPath := filepath.Join(configDir, "models.json")

	cleanup := func() {
		os.RemoveAll(configDir)
	}

	readConfig := func() map[string]any {
		data, _ := os.ReadFile(configPath)
		var cfg map[string]any
		json.Unmarshal(data, &cfg)
		return cfg
	}

	t.Run("returns nil for empty models", func(t *testing.T) {
		if err := pi.Edit(testLaunchModels()); err != nil {
			t.Errorf("Edit([]) error = %v, want nil", err)
		}
	})

	t.Run("creates config with models", func(t *testing.T) {
		cleanup()

		models := []string{"llama3.2", "qwen3:8b"}
		if err := pi.Edit(launchModelsFromNames(models)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		cfg := readConfig()

		providers, ok := cfg["providers"].(map[string]any)
		if !ok {
			t.Error("Config missing providers")
		}

		ollama, ok := providers["ollama"].(map[string]any)
		if !ok {
			t.Error("Providers missing ollama")
		}

		modelsArray, ok := ollama["models"].([]any)
		if !ok || len(modelsArray) != 2 {
			t.Errorf("Expected 2 models, got %v", modelsArray)
		}

		if ollama["baseUrl"] == nil {
			t.Error("Missing baseUrl")
		}
		if ollama["api"] != "openai-completions" {
			t.Errorf("Expected api=openai-completions, got %v", ollama["api"])
		}
		if ollama["apiKey"] != "ollama" {
			t.Errorf("Expected apiKey=ollama, got %v", ollama["apiKey"])
		}
	})

	t.Run("updates existing config preserving ollama provider settings", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		existingConfig := `{
			"providers": {
				"ollama": {
					"baseUrl": "http://custom:8080/v1",
					"api": "custom-api",
					"apiKey": "custom-key",
					"models": [
						{"id": "old-model", "_launch": true}
					]
				}
			}
		}`
		if err := os.WriteFile(configPath, []byte(existingConfig), 0o644); err != nil {
			t.Fatal(err)
		}

		models := []string{"new-model"}
		if err := pi.Edit(launchModelsFromNames(models)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		cfg := readConfig()
		providers := cfg["providers"].(map[string]any)
		ollama := providers["ollama"].(map[string]any)

		if ollama["baseUrl"] != "http://custom:8080/v1" {
			t.Errorf("Custom baseUrl not preserved, got %v", ollama["baseUrl"])
		}
		if ollama["api"] != "custom-api" {
			t.Errorf("Custom api not preserved, got %v", ollama["api"])
		}
		if ollama["apiKey"] != "custom-key" {
			t.Errorf("Custom apiKey not preserved, got %v", ollama["apiKey"])
		}

		modelsArray := ollama["models"].([]any)
		if len(modelsArray) != 1 {
			t.Errorf("Expected 1 model after update, got %d", len(modelsArray))
		} else {
			modelEntry := modelsArray[0].(map[string]any)
			if modelEntry["id"] != "new-model" {
				t.Errorf("Expected new-model, got %v", modelEntry["id"])
			}
			// Verify _launch marker is present
			if modelEntry["_launch"] != true {
				t.Errorf("Expected _launch marker to be true")
			}
		}
	})

	t.Run("rebuilds stale existing managed cloud model", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		existingConfig := `{
			"providers": {
				"ollama": {
					"baseUrl": "http://localhost:11434/v1",
					"api": "openai-completions",
					"apiKey": "ollama",
					"models": [
						{"id": "glm-5:cloud", "_launch": true, "legacyField": "stale"}
					]
				}
			}
		}`
		if err := os.WriteFile(configPath, []byte(existingConfig), 0o644); err != nil {
			t.Fatal(err)
		}

		if err := pi.Edit(testLaunchModels("glm-5:cloud")); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		cfg := readConfig()
		providers := cfg["providers"].(map[string]any)
		ollama := providers["ollama"].(map[string]any)
		modelsArray := ollama["models"].([]any)
		modelEntry := modelsArray[0].(map[string]any)

		if modelEntry["contextWindow"] != float64(202_752) {
			t.Errorf("contextWindow = %v, want 202752", modelEntry["contextWindow"])
		}
		input, ok := modelEntry["input"].([]any)
		if !ok || len(input) != 1 || input[0] != "text" {
			t.Errorf("input = %v, want [text]", modelEntry["input"])
		}
		if _, ok := modelEntry["legacyField"]; ok {
			t.Error("legacyField should be removed when stale managed cloud entry is rebuilt")
		}
	})

	t.Run("replaces old models with new ones", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		// Old models must have _launch marker to be managed by us
		existingConfig := `{
			"providers": {
				"ollama": {
					"baseUrl": "http://localhost:11434/v1",
					"api": "openai-completions",
					"apiKey": "ollama",
					"models": [
						{"id": "old-model-1", "_launch": true},
						{"id": "old-model-2", "_launch": true}
					]
				}
			}
		}`
		if err := os.WriteFile(configPath, []byte(existingConfig), 0o644); err != nil {
			t.Fatal(err)
		}

		newModels := []string{"new-model-1", "new-model-2"}
		if err := pi.Edit(launchModelsFromNames(newModels)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		cfg := readConfig()
		providers := cfg["providers"].(map[string]any)
		ollama := providers["ollama"].(map[string]any)
		modelsArray := ollama["models"].([]any)

		if len(modelsArray) != 2 {
			t.Errorf("Expected 2 models, got %d", len(modelsArray))
		}

		modelIDs := make(map[string]bool)
		for _, m := range modelsArray {
			modelObj := m.(map[string]any)
			id := modelObj["id"].(string)
			modelIDs[id] = true
		}

		if !modelIDs["new-model-1"] || !modelIDs["new-model-2"] {
			t.Errorf("Expected new models, got %v", modelIDs)
		}
		if modelIDs["old-model-1"] || modelIDs["old-model-2"] {
			t.Errorf("Old models should have been removed, got %v", modelIDs)
		}
	})

	t.Run("handles partial overlap in model list", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		// Models must have _launch marker to be managed
		existingConfig := `{
			"providers": {
				"ollama": {
					"baseUrl": "http://localhost:11434/v1",
					"api": "openai-completions",
					"apiKey": "ollama",
					"models": [
						{"id": "keep-model", "_launch": true},
						{"id": "remove-model", "_launch": true}
					]
				}
			}
		}`
		if err := os.WriteFile(configPath, []byte(existingConfig), 0o644); err != nil {
			t.Fatal(err)
		}

		newModels := []string{"keep-model", "add-model"}
		if err := pi.Edit(launchModelsFromNames(newModels)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		cfg := readConfig()
		providers := cfg["providers"].(map[string]any)
		ollama := providers["ollama"].(map[string]any)
		modelsArray := ollama["models"].([]any)

		if len(modelsArray) != 2 {
			t.Errorf("Expected 2 models, got %d", len(modelsArray))
		}

		modelIDs := make(map[string]bool)
		for _, m := range modelsArray {
			modelObj := m.(map[string]any)
			id := modelObj["id"].(string)
			modelIDs[id] = true
		}

		if !modelIDs["keep-model"] || !modelIDs["add-model"] {
			t.Errorf("Expected keep-model and add-model, got %v", modelIDs)
		}
		if modelIDs["remove-model"] {
			t.Errorf("remove-model should have been removed")
		}
	})

	t.Run("handles corrupt config gracefully", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		if err := os.WriteFile(configPath, []byte("{invalid json}"), 0o644); err != nil {
			t.Fatal(err)
		}

		models := []string{"test-model"}
		if err := pi.Edit(launchModelsFromNames(models)); err != nil {
			t.Fatalf("Edit() should not fail with corrupt config, got %v", err)
		}

		data, err := os.ReadFile(configPath)
		if err != nil {
			t.Fatalf("Failed to read config: %v", err)
		}

		var cfg map[string]any
		if err := json.Unmarshal(data, &cfg); err != nil {
			t.Fatalf("Config should be valid after Edit, got parse error: %v", err)
		}

		providers := cfg["providers"].(map[string]any)
		ollama := providers["ollama"].(map[string]any)
		modelsArray := ollama["models"].([]any)

		if len(modelsArray) != 1 {
			t.Errorf("Expected 1 model, got %d", len(modelsArray))
		}
	})

	// CRITICAL SAFETY TEST: verifies we don't stomp on user configs
	t.Run("preserves user-managed models without _launch marker", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		// User has manually configured models in ollama provider (no _launch marker)
		existingConfig := `{
			"providers": {
				"ollama": {
					"baseUrl": "http://localhost:11434/v1",
					"api": "openai-completions",
					"apiKey": "ollama",
					"models": [
						{"id": "user-model-1"},
						{"id": "user-model-2", "customField": "preserved"},
						{"id": "ollama-managed", "_launch": true}
					]
				}
			}
		}`
		if err := os.WriteFile(configPath, []byte(existingConfig), 0o644); err != nil {
			t.Fatal(err)
		}

		// Add a new ollama-managed model
		newModels := []string{"new-ollama-model"}
		if err := pi.Edit(launchModelsFromNames(newModels)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		cfg := readConfig()
		providers := cfg["providers"].(map[string]any)
		ollama := providers["ollama"].(map[string]any)
		modelsArray := ollama["models"].([]any)

		// Should have: new-ollama-model (managed) + 2 user models (preserved)
		if len(modelsArray) != 3 {
			t.Errorf("Expected 3 models (1 new managed + 2 preserved user models), got %d", len(modelsArray))
		}

		modelIDs := make(map[string]map[string]any)
		for _, m := range modelsArray {
			modelObj := m.(map[string]any)
			id := modelObj["id"].(string)
			modelIDs[id] = modelObj
		}

		// Verify new model has _launch marker
		if m, ok := modelIDs["new-ollama-model"]; !ok {
			t.Errorf("new-ollama-model should be present")
		} else if m["_launch"] != true {
			t.Errorf("new-ollama-model should have _launch marker")
		}

		// Verify user models are preserved
		if _, ok := modelIDs["user-model-1"]; !ok {
			t.Errorf("user-model-1 should be preserved")
		}
		if _, ok := modelIDs["user-model-2"]; !ok {
			t.Errorf("user-model-2 should be preserved")
		} else if modelIDs["user-model-2"]["customField"] != "preserved" {
			t.Errorf("user-model-2 customField should be preserved")
		}

		// Verify old ollama-managed model is removed (not in new list)
		if _, ok := modelIDs["ollama-managed"]; ok {
			t.Errorf("ollama-managed should be removed (old ollama model not in new selection)")
		}
	})

	t.Run("updates settings.json with default provider and model", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		// Create existing settings with other fields
		settingsPath := filepath.Join(configDir, "settings.json")
		existingSettings := `{
			"theme": "dark",
			"customSetting": "value",
			"defaultProvider": "anthropic",
			"defaultModel": "claude-3"
		}`
		if err := os.WriteFile(settingsPath, []byte(existingSettings), 0o644); err != nil {
			t.Fatal(err)
		}

		models := []string{"llama3.2"}
		if err := pi.Edit(launchModelsFromNames(models)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		data, err := os.ReadFile(settingsPath)
		if err != nil {
			t.Fatalf("Failed to read settings: %v", err)
		}

		var settings map[string]any
		if err := json.Unmarshal(data, &settings); err != nil {
			t.Fatalf("Failed to parse settings: %v", err)
		}

		// Verify defaultProvider is set to ollama
		if settings["defaultProvider"] != "ollama" {
			t.Errorf("defaultProvider = %v, want ollama", settings["defaultProvider"])
		}

		// Verify defaultModel is set to first model
		if settings["defaultModel"] != "llama3.2" {
			t.Errorf("defaultModel = %v, want llama3.2", settings["defaultModel"])
		}

		// Verify other fields are preserved
		if settings["theme"] != "dark" {
			t.Errorf("theme = %v, want dark (preserved)", settings["theme"])
		}
		if settings["customSetting"] != "value" {
			t.Errorf("customSetting = %v, want value (preserved)", settings["customSetting"])
		}
	})

	t.Run("creates settings.json if it does not exist", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		models := []string{"qwen3:8b"}
		if err := pi.Edit(launchModelsFromNames(models)); err != nil {
			t.Fatalf("Edit() error = %v", err)
		}

		settingsPath := filepath.Join(configDir, "settings.json")
		data, err := os.ReadFile(settingsPath)
		if err != nil {
			t.Fatalf("settings.json should be created: %v", err)
		}

		var settings map[string]any
		if err := json.Unmarshal(data, &settings); err != nil {
			t.Fatalf("Failed to parse settings: %v", err)
		}

		if settings["defaultProvider"] != "ollama" {
			t.Errorf("defaultProvider = %v, want ollama", settings["defaultProvider"])
		}
		if settings["defaultModel"] != "qwen3:8b" {
			t.Errorf("defaultModel = %v, want qwen3:8b", settings["defaultModel"])
		}
	})

	t.Run("handles corrupt settings.json gracefully", func(t *testing.T) {
		cleanup()
		os.MkdirAll(configDir, 0o755)

		// Create corrupt settings
		settingsPath := filepath.Join(configDir, "settings.json")
		if err := os.WriteFile(settingsPath, []byte("{invalid"), 0o644); err != nil {
			t.Fatal(err)
		}

		models := []string{"test-model"}
		if err := pi.Edit(launchModelsFromNames(models)); err != nil {
			t.Fatalf("Edit() should not fail with corrupt settings, got %v", err)
		}

		data, err := os.ReadFile(settingsPath)
		if err != nil {
			t.Fatalf("Failed to read settings: %v", err)
		}

		var settings map[string]any
		if err := json.Unmarshal(data, &settings); err != nil {
			t.Fatalf("settings.json should be valid after Edit, got parse error: %v", err)
		}

		if settings["defaultProvider"] != "ollama" {
			t.Errorf("defaultProvider = %v, want ollama", settings["defaultProvider"])
		}
		if settings["defaultModel"] != "test-model" {
			t.Errorf("defaultModel = %v, want test-model", settings["defaultModel"])
		}
	})
}

func TestPiEdit_CreatesDistinctBackupsForEachManagedFile(t *testing.T) {
	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if r.URL.Path == "/api/show" {
			fmt.Fprint(w, `{"capabilities":[],"model_info":{}}`)
			return
		}
		w.WriteHeader(http.StatusNotFound)
	}))
	defer srv.Close()
	t.Setenv("OLLAMA_HOST", srv.URL)

	pi := &Pi{}
	tmpDir := t.TempDir()
	setTestHome(t, tmpDir)

	configDir := filepath.Join(tmpDir, ".pi", "agent")
	modelsPath := filepath.Join(configDir, "models.json")
	settingsPath := filepath.Join(configDir, "settings.json")
	backupDir := fileutil.BackupDir()

	if err := os.MkdirAll(configDir, 0o755); err != nil {
		t.Fatal(err)
	}

	modelsOriginal := fmt.Sprintf(`{"marker":"models-%d","providers":{"ollama":{"models":[]}}}`, os.Getpid())
	settingsOriginal := fmt.Sprintf(`{"marker":"settings-%d","defaultProvider":"other","defaultModel":"old"}`, os.Getpid())
	if err := os.WriteFile(modelsPath, []byte(modelsOriginal), 0o644); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(settingsPath, []byte(settingsOriginal), 0o644); err != nil {
		t.Fatal(err)
	}

	if err := pi.Edit(testLaunchModels("llama3.2")); err != nil {
		t.Fatalf("Edit() error = %v", err)
	}

	assertBackupMatches := func(pattern, want string) {
		t.Helper()
		backups, err := filepath.Glob(filepath.Join(backupDir, pattern))
		if err != nil {
			t.Fatalf("glob %q failed: %v", pattern, err)
		}
		for _, backup := range backups {
			data, err := os.ReadFile(backup)
			if err == nil && string(data) == want {
				return
			}
		}
		t.Fatalf("backup matching %q with expected content not found", pattern)
	}

	assertBackupMatches(filepath.Join("pi", "models.json.*"), modelsOriginal)
	assertBackupMatches(filepath.Join("pi", "settings.json.*"), settingsOriginal)
}

func TestPiModels(t *testing.T) {
	pi := &Pi{}

	t.Run("returns nil when no config exists", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		models := pi.Models()
		if models != nil {
			t.Errorf("Models() = %v, want nil", models)
		}
	})

	t.Run("returns models from config", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		configDir := filepath.Join(tmpDir, ".pi", "agent")
		if err := os.MkdirAll(configDir, 0o755); err != nil {
			t.Fatal(err)
		}
		config := `{
			"providers": {
				"ollama": {
					"models": [
						{"id": "llama3.2"},
						{"id": "qwen3:8b"}
					]
				}
			}
		}`
		configPath := filepath.Join(configDir, "models.json")
		if err := os.WriteFile(configPath, []byte(config), 0o644); err != nil {
			t.Fatal(err)
		}

		models := pi.Models()
		if len(models) != 2 {
			t.Errorf("Models() returned %d models, want 2", len(models))
		}
		if models[0] != "llama3.2" || models[1] != "qwen3:8b" {
			t.Errorf("Models() = %v, want [llama3.2 qwen3:8b] (sorted)", models)
		}
	})

	t.Run("returns sorted models", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		configDir := filepath.Join(tmpDir, ".pi", "agent")
		if err := os.MkdirAll(configDir, 0o755); err != nil {
			t.Fatal(err)
		}
		config := `{
			"providers": {
				"ollama": {
					"models": [
						{"id": "z-model"},
						{"id": "a-model"},
						{"id": "m-model"}
					]
				}
			}
		}`
		configPath := filepath.Join(configDir, "models.json")
		if err := os.WriteFile(configPath, []byte(config), 0o644); err != nil {
			t.Fatal(err)
		}

		models := pi.Models()
		if models[0] != "a-model" || models[1] != "m-model" || models[2] != "z-model" {
			t.Errorf("Models() = %v, want [a-model m-model z-model] (sorted)", models)
		}
	})

	t.Run("returns nil when models array is missing", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		configDir := filepath.Join(tmpDir, ".pi", "agent")
		if err := os.MkdirAll(configDir, 0o755); err != nil {
			t.Fatal(err)
		}
		config := `{
			"providers": {
				"ollama": {}
			}
		}`
		configPath := filepath.Join(configDir, "models.json")
		if err := os.WriteFile(configPath, []byte(config), 0o644); err != nil {
			t.Fatal(err)
		}

		models := pi.Models()
		if models != nil {
			t.Errorf("Models() = %v, want nil when models array is missing", models)
		}
	})

	t.Run("handles corrupt config gracefully", func(t *testing.T) {
		tmpDir := t.TempDir()
		setTestHome(t, tmpDir)

		configDir := filepath.Join(tmpDir, ".pi", "agent")
		if err := os.MkdirAll(configDir, 0o755); err != nil {
			t.Fatal(err)
		}
		configPath := filepath.Join(configDir, "models.json")
		if err := os.WriteFile(configPath, []byte("{invalid json}"), 0o644); err != nil {
			t.Fatal(err)
		}

		models := pi.Models()
		if models != nil {
			t.Errorf("Models() = %v, want nil for corrupt config", models)
		}
	})
}

func TestIsPiOllamaModel(t *testing.T) {
	tests := []struct {
		name string
		cfg  map[string]any
		want bool
	}{
		{"with _launch true", map[string]any{"id": "m", "_launch": true}, true},
		{"with _launch false", map[string]any{"id": "m", "_launch": false}, false},
		{"without _launch", map[string]any{"id": "m"}, false},
		{"with _launch non-bool", map[string]any{"id": "m", "_launch": "yes"}, false},
		{"empty map", map[string]any{}, false},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if got := isPiOllamaModel(tt.cfg); got != tt.want {
				t.Errorf("isPiOllamaModel(%v) = %v, want %v", tt.cfg, got, tt.want)
			}
		})
	}
}

func TestCreateConfig(t *testing.T) {
	t.Run("sets vision input when model has vision capability", func(t *testing.T) {
		cfg := createConfig(LaunchModel{Name: "llava:7b", Capabilities: []model.Capability{model.CapabilityVision}})

		if cfg["id"] != "llava:7b" {
			t.Errorf("id = %v, want llava:7b", cfg["id"])
		}
		if cfg["_launch"] != true {
			t.Error("expected _launch = true")
		}
		input, ok := cfg["input"].([]string)
		if !ok || len(input) != 2 || input[0] != "text" || input[1] != "image" {
			t.Errorf("input = %v, want [text image]", cfg["input"])
		}
	})

	t.Run("sets text-only input when model lacks vision", func(t *testing.T) {
		cfg := createConfig(LaunchModel{Name: "llama3.2", Capabilities: []model.Capability{model.CapabilityCompletion}})

		input, ok := cfg["input"].([]string)
		if !ok || len(input) != 1 || input[0] != "text" {
			t.Errorf("input = %v, want [text]", cfg["input"])
		}
		if _, ok := cfg["reasoning"]; ok {
			t.Error("reasoning should not be set for non-thinking model")
		}
	})

	t.Run("sets reasoning when model has thinking capability", func(t *testing.T) {
		cfg := createConfig(LaunchModel{Name: "qwq", Capabilities: []model.Capability{model.CapabilityThinking}})

		if cfg["reasoning"] != true {
			t.Error("expected reasoning = true for thinking model")
		}
	})

	t.Run("sets context window from metadata", func(t *testing.T) {
		cfg := createConfig(LaunchModel{Name: "llama3.2", ContextLength: 131072})

		if cfg["contextWindow"] != 131072 {
			t.Errorf("contextWindow = %v, want 131072", cfg["contextWindow"])
		}
	})

	t.Run("handles all capabilities together", func(t *testing.T) {
		cfg := createConfig(LaunchModel{
			Name:          "qwen3-vision",
			Capabilities:  []model.Capability{model.CapabilityVision, model.CapabilityThinking},
			ContextLength: 32768,
		})

		input := cfg["input"].([]string)
		if len(input) != 2 || input[0] != "text" || input[1] != "image" {
			t.Errorf("input = %v, want [text image]", input)
		}
		if cfg["reasoning"] != true {
			t.Error("expected reasoning = true")
		}
		if cfg["contextWindow"] != 32768 {
			t.Errorf("contextWindow = %v, want 32768", cfg["contextWindow"])
		}
	})

	t.Run("returns minimal config when metadata is unavailable", func(t *testing.T) {
		cfg := createConfig(LaunchModel{Name: "missing-model"})

		if cfg["id"] != "missing-model" {
			t.Errorf("id = %v, want missing-model", cfg["id"])
		}
		if cfg["_launch"] != true {
			t.Error("expected _launch = true")
		}
		// Input defaults to text even when capabilities are unavailable.
		input, ok := cfg["input"].([]string)
		if !ok || len(input) != 1 || input[0] != "text" {
			t.Errorf("input = %v, want [text]", cfg["input"])
		}
		if _, ok := cfg["reasoning"]; ok {
			t.Error("reasoning should not be set when metadata is unavailable")
		}
		if _, ok := cfg["contextWindow"]; ok {
			t.Error("contextWindow should not be set when metadata is unavailable")
		}
	})

	t.Run("cloud model falls back to hardcoded context", func(t *testing.T) {
		cfg := createConfig(fallbackLaunchModel("kimi-k2.5:cloud"))

		if cfg["contextWindow"] != 262_144 {
			t.Errorf("contextWindow = %v, want 262144", cfg["contextWindow"])
		}
	})

	t.Run("cloud model uses hardcoded context when tags omit context", func(t *testing.T) {
		cfg := createConfig(fallbackLaunchModel("glm-5:cloud"))

		if cfg["contextWindow"] != 202_752 {
			t.Errorf("contextWindow = %v, want 202752", cfg["contextWindow"])
		}
	})

	t.Run("cloud model with dash suffix falls back to hardcoded context", func(t *testing.T) {
		cfg := createConfig(fallbackLaunchModel("gpt-oss:120b-cloud"))

		if cfg["contextWindow"] != 131_072 {
			t.Errorf("contextWindow = %v, want 131072", cfg["contextWindow"])
		}
	})
	t.Run("skips zero context length", func(t *testing.T) {
		cfg := createConfig(LaunchModel{Name: "test-model", ContextLength: 0})

		if _, ok := cfg["contextWindow"]; ok {
			t.Error("contextWindow should not be set for zero value")
		}
	})
}

// Ensure Capability constants used in createConfig match expected values
func TestPiCapabilityConstants(t *testing.T) {
	if model.CapabilityVision != "vision" {
		t.Errorf("CapabilityVision = %q, want %q", model.CapabilityVision, "vision")
	}
	if model.CapabilityThinking != "thinking" {
		t.Errorf("CapabilityThinking = %q, want %q", model.CapabilityThinking, "thinking")
	}
}