From f2782f3e4e31550959d98543161af34514c0bd24 Mon Sep 17 00:00:00 2001 From: david Date: Fri, 19 Sep 2008 00:41:51 +0000 Subject: [PATCH] Don't elide port state changes when a state changes to "unknown." I originally did this with the idea of making diffing like scan aggregation, with known characteristics carrying forward through unknown. But it can be confusing. I think when you diff nmap scanme.nmap.org and nmap -F scanme.nmap.org you want to see that the gopher port changes from closed to unknown, because it's not scanned by fast scan. --- ndiff/ndiff | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ndiff/ndiff b/ndiff/ndiff index 86fe40675..cf1385394 100755 --- a/ndiff/ndiff +++ b/ndiff/ndiff @@ -429,8 +429,7 @@ def host_diff(a, b): all_specs = list(set(a.ports.keys()).union(set(b.ports.keys()))) all_specs.sort() for spec in all_specs: - if b.ports[spec].state != Port.UNKNOWN: - diff.extend(port_diff(a.ports[spec], b.ports[spec])) + diff.extend(port_diff(a.ports[spec], b.ports[spec])) return diff def scan_diff(a, b):