CERBERUS/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-08-04 14:49:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix a memory leak in nse_pcrelib.cc. A string was being copied with

Browse source 
strdup before being handed to lua_pushstring. That was excessive because
lua_pushstring already makes its own internal copy of the string. This
was found by Coverity.
This commit is contained in:
david 2009-07-23 02:59:57 +00:00
parent f673eff211
commit e801b1b341
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nse_pcrelib.cc
View file

@ -183,7 +183,7 @@ static void Lpcre_push_substrings (lua_State *L, const char *text, pcre2 *ud)
unsigned int n = (tabptr[0] << 8) | tabptr[1]; /* number of the capturing parenthesis */
if (n > 0 && n <= (unsigned) ud->ncapt) { /* check range */
unsigned int j = n * 2;
lua_pushstring(L, strdup((char*)tabptr + 2)); /* name of the capture, zero terminated */
lua_pushstring(L, (char*)tabptr + 2); /* name of the capture, zero terminated */
if (match[j] >= 0)
lua_pushlstring(L, text + match[j], match[j + 1] - match[j]);
else