From d29f59626aa215124714066f84032652458872f9 Mon Sep 17 00:00:00 2001
From: dmiller <dmiller@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Mon, 15 May 2023 17:31:37 +0000
Subject: [PATCH] Avoid copying fingerprint for no reason (both const)

---
 osscan.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/osscan.cc b/osscan.cc
index 24305ef72..4ab75a1e4 100644
--- a/osscan.cc
+++ b/osscan.cc
@@ -423,7 +423,6 @@ void match_fingerprint(const FingerPrint *FP, FingerPrintResultsIPv4 *FPR,
                                                            to be added to the
                                                            list */
   std::vector<FingerPrint *>::const_iterator current_os;
-  FingerPrint FP_copy;
   double acc;
   int state;
   int skipfp;
@@ -436,14 +435,12 @@ void match_fingerprint(const FingerPrint *FP, FingerPrintResultsIPv4 *FPR,
   assert(FPR);
   assert(accuracy_threshold >= 0 && accuracy_threshold <= 1);
 
-  FP_copy = *FP;
-
   FPR->overall_results = OSSCAN_SUCCESS;
 
   for (current_os = DB->prints.begin(); current_os != DB->prints.end(); current_os++) {
     skipfp = 0;
 
-    acc = compare_fingerprints(*current_os, &FP_copy, DB->MatchPoints, 0, FPR_entrance_requirement);
+    acc = compare_fingerprints(*current_os, FP, DB->MatchPoints, 0, FPR_entrance_requirement);
 
     if (acc >= FPR_entrance_requirement || acc == 1.0) {