CERBERUS/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-10-21 03:11:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused socket connect/close from ipp.Helper. Close #3245

Browse source
This commit is contained in:
nnposter 2026-01-01 22:34:15 +00:00
parent fd94457aeb
commit ce0c08997e
3 changed files with 6 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

14
nselib/ipp.lua
View file

@ -290,19 +290,13 @@ HTTP = {
Helper = {
new = function(self, host, port, options)
local o = { host = host, port = port, options = options or {} }
new = function(self, host, port)
local o = { host = host, port = port }
setmetatable(o, self)
self.__index = self
return o
end,
connect = function(self)
self.socket = nmap.new_socket()
self.socket:set_timeout(self.options.timeout or 10000)
return self.socket:connect(self.host, self.port)
end,
getPrinters = function(self)
local attribs = {
@ -412,10 +406,6 @@ Helper = {
return output
end,
close = function(self)
return self.socket:close()
end,
}
return _ENV;

10
scripts/cups-info.nse
View file

@ -1,7 +1,6 @@
local ipp = require "ipp"
local shortport = require "shortport"
local stdnse = require "stdnse"
local string = require "string"
local table = require "table"
description = [[
@ -51,13 +50,8 @@ local verbose_states = {
action = function(host, port)
local helper = ipp.Helper:new(host, port)
if ( not(helper:connect()) ) then
return stdnse.format_output(false, "Failed to connect to server")
end
local status, printers = helper:getPrinters()
if ( not(status) ) then
local status, printers = ipp.Helper:new(host, port):getPrinters()
if not status then
return
end

9
scripts/cups-queue-info.nse
View file

@ -35,13 +35,8 @@ categories = {"safe", "discovery"}
portrule = shortport.port_or_service(631, "ipp", "tcp", "open")
action = function(host, port)
local helper = ipp.Helper:new(host, port)
if ( not(helper:connect()) ) then
return stdnse.format_output(false, "Failed to connect to server")
end
local output = helper:getQueueInfo()
if ( output ) then
local output = ipp.Helper:new(host, port):getQueueInfo()
if output then
return stdnse.format_output(true, output)
end
end