From ab973f548a1dcd2c0b5b917ad5af98446daabd0d Mon Sep 17 00:00:00 2001
From: dmiller <dmiller@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Mon, 20 Apr 2026 15:21:54 +0000
Subject: [PATCH] Nbase: make checksum functions const, avoid undefined
 behavior in shifts

---
 nbase/nbase.h      |  6 +++---
 nbase/nbase_misc.c | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/nbase/nbase.h b/nbase/nbase.h
index 7b29d9e9b..f9691aa0d 100644
--- a/nbase/nbase.h
+++ b/nbase/nbase.h
@@ -480,11 +480,11 @@ int block_socket(int sd);
 int socket_bindtodevice(int sd, const char *device);
 
 /* CRC32 Cyclic Redundancy Check */
-unsigned long nbase_crc32(unsigned char *buf, int len);
+unsigned long nbase_crc32(const unsigned char *buf, int len);
 /* CRC32C Cyclic Redundancy Check (Castagnoli) */
-unsigned long nbase_crc32c(unsigned char *buf, int len);
+unsigned long nbase_crc32c(const unsigned char *buf, int len);
 /* Adler32 Checksum */
-unsigned long nbase_adler32(unsigned char *buf, int len);
+unsigned long nbase_adler32(const unsigned char *buf, int len);
 
 double tval2secs(const char *tspec);
 long tval2msecs(const char *tspec);
diff --git a/nbase/nbase_misc.c b/nbase/nbase_misc.c
index 20e122b88..9280f177f 100644
--- a/nbase/nbase_misc.c
+++ b/nbase/nbase_misc.c
@@ -491,7 +491,7 @@ static void make_crc_table(void)
    if (crc != original_crc) error();
 */
 static unsigned long update_crc(unsigned long crc,
-                unsigned char *buf, int len)
+                const unsigned char *buf, int len)
 {
   unsigned long c = crc ^ 0xffffffffL;
   int n;
@@ -505,7 +505,7 @@ static unsigned long update_crc(unsigned long crc,
 }
 
 /* Return the CRC of the bytes buf[0..len-1]. */
-unsigned long nbase_crc32(unsigned char *buf, int len)
+unsigned long nbase_crc32(const unsigned char *buf, int len)
 {
   return update_crc(0L, buf, len);
 }
@@ -520,7 +520,7 @@ unsigned long nbase_crc32(unsigned char *buf, int len)
  */
 
 /* Return the CRC-32C of the bytes buf[0..len-1] */
-unsigned long nbase_crc32c(unsigned char *buf, int len)
+unsigned long nbase_crc32c(const unsigned char *buf, int len)
 {
   int i;
   unsigned long crc32 = 0xffffffffL;
@@ -551,7 +551,7 @@ unsigned long nbase_crc32c(unsigned char *buf, int len)
   byte1 = (result >>  8) & 0xff;
   byte2 = (result >> 16) & 0xff;
   byte3 = (result >> 24) & 0xff;
-  crc32 = ((byte0 << 24) | (byte1 << 16) | (byte2 <<  8) | byte3);
+  crc32 = (((unsigned long)byte0 << 24) | (byte1 << 16) | (byte2 <<  8) | byte3);
   return crc32;
 }
 
@@ -569,7 +569,7 @@ unsigned long nbase_crc32c(unsigned char *buf, int len)
  * be initialized to 1.
  */
 static unsigned long update_adler32(unsigned long adler,
-                                    unsigned char *buf, int len)
+                                    const unsigned char *buf, int len)
 {
   unsigned long s1 = adler & 0xffff;
   unsigned long s2 = (adler >> 16) & 0xffff;
@@ -583,7 +583,7 @@ static unsigned long update_adler32(unsigned long adler,
 }
 
 /* Return the Adler32 of the bytes buf[0..len-1] */
-unsigned long nbase_adler32(unsigned char *buf, int len)
+unsigned long nbase_adler32(const unsigned char *buf, int len)
 {
   return update_adler32(1L, buf, len);
 }