From a35225d3e16fa719a4219a9097511ab53167bec0 Mon Sep 17 00:00:00 2001
From: dmiller <dmiller@e0a8ed71-7df4-0310-8962-fdc924857419>
Date: Wed, 15 Apr 2026 21:28:34 +0000
Subject: [PATCH] Fix some memory leaks in arg parsing

---
 nping/ArgParser.cc |  2 +-
 nping/NpingOps.cc  | 21 ++++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/nping/ArgParser.cc b/nping/ArgParser.cc
index f78199ad2..a54516a25 100644
--- a/nping/ArgParser.cc
+++ b/nping/ArgParser.cc
@@ -1012,7 +1012,7 @@ int ArgParser::parseArguments(int argc, char *argv[]) {
         if(strlen(optarg)==0)
             nping_fatal(QT_3,"Invalid network interface supplied. Interface name cannot be NULL.");
         else
-            o.setDevice( strdup(optarg) );
+            o.setDevice( optarg );
     break; /* case 'e': */
 
     case 'N': /* Don't capture packets */
diff --git a/nping/NpingOps.cc b/nping/NpingOps.cc
index 933815c8b..eb677f5f8 100644
--- a/nping/NpingOps.cc
+++ b/nping/NpingOps.cc
@@ -2368,8 +2368,10 @@ if( this->getMode()!=TCP_CONNECT && this->getMode()!=UDP_UNPRIV && this->getRole
                 /* If that didn't work, ask libpcap */
                 if ( (dev = this->select_network_iface()) == NULL)
                     nping_fatal(QT_3, "Cannot obtain device for packet capture");
-                else
+                else {
                     this->setDevice( dev );
+                    free(dev);
+                }
                 /* Libpcap gave us a device name, try to obtain it's IP */
                 if ( devname2ipaddr(this->getDevice(), this->af(), &ifaddr) != 0 ){
                     if( this->isRoot() )
@@ -2390,8 +2392,10 @@ if( this->getMode()!=TCP_CONNECT && this->getMode()!=UDP_UNPRIV && this->getRole
             char *selected_iface=this->select_network_iface();
             if(selected_iface==NULL)
                 nping_fatal(QT_3, "Error trying to find a suitable network interface ");
-            else
+            else {
                 this->setDevice( selected_iface );
+                free(selected_iface);
+            }
         }
     } /* CASE 2: User did actually supply a device name */
     else{
@@ -2403,8 +2407,10 @@ if( this->getMode()!=TCP_CONNECT && this->getMode()!=UDP_UNPRIV && this->getRole
   char *selected_iface=this->select_network_iface();
   if(selected_iface==NULL)
     nping_fatal(QT_3, "Error trying to find a suitable network interface ");
-  else
+  else {
     this->setDevice( selected_iface );
+    free(selected_iface);
+  }
   nping_print(DBG_2, "Using network interface \"%s\"", this->getDevice() );
 }
 
@@ -2755,6 +2761,7 @@ int NpingOps::cleanup(){
 
 
 char *NpingOps::select_network_iface(){
+    char *devname = NULL;
     char errbuf[PCAP_ERRBUF_SIZE];
     pcap_if_t *pcap_ifaces=NULL;
 
@@ -2857,10 +2864,10 @@ char *NpingOps::select_network_iface(){
         }
 
     }
-    if(candidate==NULL)
-        return NULL;
-    else
-       return candidate->name;
+    if(candidate)
+       devname = strdup(candidate->name);
+    pcap_freealldevs(pcap_ifaces);
+    return devname;
 } /* End of select_network_iface() */