CERBERUS/nmap
1
0
Fork 0
mirror of https://github.com/nmap/nmap.git synced 2026-09-21 07:38:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid iterating over probes if caller doesn't ask for mayincrease

Browse source
This commit is contained in:
dmiller 2024-02-26 18:29:07 +00:00
parent c8cd68444a
commit 9c6daa5b9c
1 changed files with 18 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

34
scan_engine.cc
View file

@ -682,26 +682,28 @@ unsigned int HostScanStats::allowedTryno(bool *capped, bool *mayincrease) const
tryno_mayincrease = false; /* It never exceeds the cap */
} else if (capped) *capped = false;
/* Decide if the tryno can possibly increase. */
if (tryno_mayincrease && num_probes_active == 0 && !freshPortsLeft()) {
/* If every outstanding probe is timedout and at maxval, then no further
retransmits are necessary. */
for (probeI = probes_outstanding.begin();
probeI != probes_outstanding.end(); probeI++) {
probe = *probeI;
assert(probe->timedout);
if (!probe->retransmitted && !probe->isPing() && probe->get_tryno() < maxval) {
/* Needs at least one more retransmit. */
allfinished = false;
break;
// Only do this work if the caller needs to know
if (mayincrease) {
/* Decide if the tryno can possibly increase. */
if (tryno_mayincrease && num_probes_active == 0 && !freshPortsLeft()) {
/* If every outstanding probe is timedout and at maxval, then no further
retransmits are necessary. */
for (probeI = probes_outstanding.begin();
probeI != probes_outstanding.end(); probeI++) {
probe = *probeI;
assert(probe->timedout);
if (!probe->retransmitted && !probe->isPing() && probe->get_tryno() < maxval) {
/* Needs at least one more retransmit. */
allfinished = false;
break;
}
}
if (allfinished)
tryno_mayincrease = false;
}
if (allfinished)
tryno_mayincrease = false;
}
if (mayincrease)
*mayincrease = tryno_mayincrease;
}
return maxval;
}